Message-ID: <9011348fd53b35857afb6a65f5d3163adec9a923.camel@perches.com>
Subject: Re: [PATCH v7 2/2] Driver for ON Semi AR0521 camera sensor
From:   Joe Perches <joe@perches.com>
To:     Jacopo Mondi <jacopo@jmondi.org>,
        Krzysztof =?UTF-8?Q?Ha=C5=82asa?= <khalasa@piap.pl>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Sakari Ailus <sakari.ailus@iki.fi>
Date:   Sun, 09 Jan 2022 11:01:52 -0800
In-Reply-To: <20220109153439.bfnfigocaeeeghmp@uno.localdomain>
References: <m3czl9eylt.fsf@t19.piap.pl> <m34k6leyb1.fsf@t19.piap.pl>
         <20220109153439.bfnfigocaeeeghmp@uno.localdomain>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1ubuntu2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 2022-01-09 at 16:34 +0100, Jacopo Mondi wrote:
> Hi Krzysztof

Hi Jacopo

Can you please trim your replies to just the sections that
you are commenting on?

Finding the reply in the duplicated reply content isn't easy.

> > +	// access the sensor only if it's powered up
> > +	if (!pm_runtime_get_if_in_use(&sensor->i2c_client->dev))
> 
> As you correctly do not access the chip's registers if it's powered
> off, you have to call __v4l2_ctrl_handler_setup() at power on time to
> make sure controls are actually set.

It was 25 pages down in the reply to find this.