Date:   Sun, 9 Jan 2022 22:22:51 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     William Breathitt Gray <vilhelm.gray@gmail.com>
Cc:     Jonathan.Cameron@huawei.com, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Syed Nayyar Waris <syednwaris@gmail.com>
Subject: Re: [PATCH] counter: 104-quad-8: Add COMPILE_TEST depends
Message-ID: <20220109212251.xzwilquctuij5lev@pengutronix.de>
References: <20220105094137.259111-1-vilhelm.gray@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="bkgn73cgzbxbpdam"
Content-Disposition: inline
In-Reply-To: <20220105094137.259111-1-vilhelm.gray@gmail.com>
Precedence: bulk


--bkgn73cgzbxbpdam
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 05, 2022 at 06:41:37PM +0900, William Breathitt Gray wrote:
> 104_QUAD_8 depends on X86, but compiles fine on ARCH=3Darm. This patch
> adds support for COMPILE_TEST which is useful for compile testing code
> changes to the driver and Counter subsystem.
>=20
> Suggested-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> Cc: Syed Nayyar Waris <syednwaris@gmail.com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> ---
>  drivers/counter/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> index 3dcdb681c4e4..5edd155f1911 100644
> --- a/drivers/counter/Kconfig
> +++ b/drivers/counter/Kconfig
> @@ -14,7 +14,7 @@ if COUNTER
> =20
>  config 104_QUAD_8
>  	tristate "ACCES 104-QUAD-8 driver"
> -	depends on PC104 && X86
> +	depends on (PC104 && X86) || COMPILE_TEST

The driver uses inb and friends. Without looking I wonder if there is
something like HAVE_IO or similar this needs to depend on for that?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--bkgn73cgzbxbpdam
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmHbUhwACgkQwfwUeK3K
7AntkQf8CoKrukB0Gp8iUYseyEAZ1uruINCrIfotxW3JSmkoVM3+9daB+UM2ajWy
ycQ6797YTbMBeXfTedkPrUL8Zkb+BshG6jkAZ7R08GWsWwP5l8Kz4PmgycPSZGj8
DPd3iuZvaAXjJ+A7uq9Tf6rW0CTPq86x8CSnHJ5Z5mrxB1iHrxv+0p+7fPH0Ky8N
PbtVdu/vBdZg3WeGxAOCXrAe9Jqzle35h+D4wOw1SnQu7BDaQDWGj7XB5ZIXwmR0
oYiqxP/XTEpNTfU8ynMGBuct6tbOOLITYgsj7PfICMhezB4DzEKSDBEqYd4JtegO
Y3O9AIp4peR/0tzmWVdYH/ceA+Yndg==
=i/AB
-----END PGP SIGNATURE-----

--bkgn73cgzbxbpdam--