Date:   Sun, 9 Jan 2022 14:21:45 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Andrew Melnychenko <andrew@daynix.com>
Cc:     netdev@vger.kernel.org, virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, davem@davemloft.net,
        jasowang@redhat.com, mst@redhat.com, yan@daynix.com,
        yuri.benditovich@daynix.com
Subject: Re: [PATCH 1/4] drivers/net/virtio_net: Fixed padded vheader to use
 v1 with hash.
Message-ID: <20220109142145.54447b38@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <20220109210659.2866740-2-andrew@daynix.com>
References: <20220109210659.2866740-1-andrew@daynix.com>
        <20220109210659.2866740-2-andrew@daynix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun,  9 Jan 2022 23:06:56 +0200 Andrew Melnychenko wrote:
> The header v1 provides additional info about RSS.
> Added changes to computing proper header length.
> In the next patches, the header may contain RSS hash info
> for the hash population.
>=20
> Signed-off-by: Andrew Melnychenko <andrew@daynix.com>

You can't break build in between patches:

drivers/net/virtio_net.c: In function =E2=80=98page_to_skb=E2=80=99:
drivers/net/virtio_net.c:398:15: error: =E2=80=98struct virtnet_info=E2=80=
=99 has no member named =E2=80=98has_rss_hash_report=E2=80=99
  398 |         if (vi->has_rss_hash_report)
      |               ^~