From:   Colin Foster <colin.foster@in-advantage.com>
To:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc:     Vladimir Oltean <vladimir.oltean@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH v1 net-next 1/2] net: mscc: ocelot: add ability to perform bulk reads
Date:   Sun,  9 Jan 2022 17:06:17 -0800
Message-Id: <20220110010618.428927-2-colin.foster@in-advantage.com>
In-Reply-To: <20220110010618.428927-1-colin.foster@in-advantage.com>
References: <20220110010618.428927-1-colin.foster@in-advantage.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uMqnhqUOz9GQ/GLEWLv5qk8FUbwFX4AJBiEp1fLw062LX7LifORqPUU29NHk?=
 =?us-ascii?Q?8GE0eh9Y9pd5Q3e5tR3mYDiKUb5JzPO+s2OvPhJ0wu+yQWGucAmHy07VPP4/?=
 =?us-ascii?Q?hhzjfYNPoGONhybDhXwJkHNjMVJ+wJokjmmYjQABrnk9ParBWae7zVAHmnOz?=
 =?us-ascii?Q?1N0Msur+0Imaps6+Hlz14zI7d4nYNgwFF5w4jYvGN67c1H+zzxXRrFzEpL1K?=
 =?us-ascii?Q?I6Kz11x5Y5oc4ymx5NcvesWWcpPAyqE/oM6ApBeKHfuS5bMsMQrPcnqXPptF?=
 =?us-ascii?Q?Ht/lz2TCQG9a9JfUIyX0KZfWwxcohv9Nze1yTgLmpssW3amHoRqaecgs9A2V?=
 =?us-ascii?Q?aQl80zPCKPJdEbA8MFOeKPlEsPRWrA9svVLePI/EPDiX7JkEAnnIm88wp381?=
 =?us-ascii?Q?jj3KGvr0e4W3fM0WEYnIbvnGHyHCdeRzbig0ddUiXYiYYwHoOXvUsSPX9Lfg?=
 =?us-ascii?Q?FqZ34LdKXyZG0WSkK/vTtgZD5Cud0YlxtU1kJWWF9Gm/Nn2+1Ow9oZLjo8B1?=
 =?us-ascii?Q?/SsArvxXiiBzom4XBwtOvd7OLusZPSklfEKZA8f4sEuyRPmBZGhLJczQSd+l?=
 =?us-ascii?Q?L6+ukg2u/tlMCuVuZ6Kx7+CfO/MV1hmcJLPGSEfPmgbmDuYrECrzCsgt/Pc8?=
 =?us-ascii?Q?mBOJ2a9orjxLwSwUa1lE4zoTEpAE9DrayuG+CjggbZxGyv6jgIQGKvcPldkX?=
 =?us-ascii?Q?Nprc0qQFAw9jpsDGjDHU6wKur3E6EAVpqIy97+EPuU5qAxXHvZvkwyTk9e44?=
 =?us-ascii?Q?mLiPMn2osGvlG5+CCFVB8w9FgtxyTBWtBJwIWU3FqbO4CT40mXLYHnqBnXtP?=
 =?us-ascii?Q?c66GaqJ1cPEEDZHBg2PZQNrQabQLUQBX76VruSAEapgXCwH8AHcDxxkwKWel?=
 =?us-ascii?Q?PF4UPqOI2FUUXbFBivOrnqbvNbCjAUXSPgM0g3DMKdCcM/QYQaC5UnqF4cPa?=
 =?us-ascii?Q?3241PN61f9WQSqojeTIP5C5pfLy6mcxS595Kk+GSiGQRdnotyh6ybHVH2BG3?=
 =?us-ascii?Q?uiHcSsZvGdek7lDHa6tHQpdWX4TeWxsNQombWB+HV0JM/+Qt2IGUFGrX3yeJ?=
 =?us-ascii?Q?Nm2Gd+7GFvBBT0qPt6lMmVXnUzABphWFdpghl2hkEvtJGRk5uFAsTjVjc4RX?=
 =?us-ascii?Q?0OG9hf5V+LFV2ziPv8OPRm296A94PPPQP+EtNk/UB1pta/V4fGVZ1zdLz8GH?=
 =?us-ascii?Q?QXID4ZnwbTLsrQzCTnxg9m4uea7lrZ9dtyFU/Krr/ZkUa10jVIe5Y+D1L6Ca?=
 =?us-ascii?Q?kkybXgVDFXNvcGz1SWU8+T62nYmV9R8daRe9kd4uLuAsNqEvWcWijU6Ty2YC?=
 =?us-ascii?Q?F/Pv+HnfZtSeSeish6a1tV7OKAbQuhPKVyk98BWpV2U56sjdXEGSHJCrqhCI?=
 =?us-ascii?Q?eYKCWhg3cx0Iy4Sj/CiT48B2cScDVtyzQIAADhvTBEaeL4LfomtE1vIW/i0p?=
 =?us-ascii?Q?IThhDFKrn5WgykqOieg7JNNxKxDNPKJozSK8ElqWdF8zeOTWeXDRq8qGrvFl?=
 =?us-ascii?Q?/cFMzCOPoMj7nX0P/PZquGBvOltwPQSaKsGnTlPIarGDCiwWbGLwSf0Ecq8K?=
 =?us-ascii?Q?+LvzGBthS+FQaMN/dLIp8wxAofxLlfNva9YfW27vdHedIap8N2Z3HSVW/zB1?=
 =?us-ascii?Q?/L7yNDlu21YDReAPL0f7bjp569eMdNhcHlfw0LZcFcXdFroFKggNqZz15xJd?=
 =?us-ascii?Q?XMIprQ=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0ba4832-f2fe-4a9c-f7cc-08d9d3d5706b
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2022 01:06:31.8348
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1msxV4mwdwvRxrZ34bLHwgitpBDimbpWJvnZRicoNmUPTEIsuPdoAIJECPkcumOt/YhAWt11WAvfsvlyRubzFop9v98CNbeNXPc3XkYPcgM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5810
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Regmap supports bulk register reads. Ocelot does not. This patch adds
support for Ocelot to invoke bulk regmap reads.

ocelot_update_stats loops over continguous memory regions. Performing bulk
reads over these regions will allow drivers to optimize bulk optimizations
to thrive.

Specifically, SPI operations for Ocelot chips will be improved drastically.
The process of transitioning from subsequent register reads removes the
need to de-assert CS, re-assert CS, send 3 address bytes, and send N
paddings bytes. With one padding byte, that is an overhead of 100% for the
protocol alone. This overhead will no longer need to be incurred.

This patch should have minimal effect on existing systems. There is a small
memory hit (maybe 1KB) and linked-list navigation runtime performance. The
runtime penalty is probably offset by lower-level lock cleanup, so it is
entirely possible that this patch actually improves runtime performance of
existing systems.

Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
---
 drivers/net/ethernet/mscc/ocelot_io.c | 13 +++++++++++++
 include/soc/mscc/ocelot.h             |  4 ++++
 2 files changed, 17 insertions(+)

diff --git a/drivers/net/ethernet/mscc/ocelot_io.c b/drivers/net/ethernet/mscc/ocelot_io.c
index 7390fa3980ec..2067382d0ee1 100644
--- a/drivers/net/ethernet/mscc/ocelot_io.c
+++ b/drivers/net/ethernet/mscc/ocelot_io.c
@@ -10,6 +10,19 @@
 
 #include "ocelot.h"
 
+int __ocelot_bulk_read_ix(struct ocelot *ocelot, u32 reg, u32 offset, void *buf,
+			  int count)
+{
+	u16 target = reg >> TARGET_OFFSET;
+
+	WARN_ON(!target);
+
+	return regmap_bulk_read(ocelot->targets[target],
+				ocelot->map[target][reg & REG_MASK] + offset,
+				buf, count);
+}
+EXPORT_SYMBOL_GPL(__ocelot_bulk_read_ix);
+
 u32 __ocelot_read_ix(struct ocelot *ocelot, u32 reg, u32 offset)
 {
 	u16 target = reg >> TARGET_OFFSET;
diff --git a/include/soc/mscc/ocelot.h b/include/soc/mscc/ocelot.h
index 5e6b9d6c4c1b..6f74015032fc 100644
--- a/include/soc/mscc/ocelot.h
+++ b/include/soc/mscc/ocelot.h
@@ -744,6 +744,8 @@ struct ocelot_policer {
 	u32 burst; /* bytes */
 };
 
+#define ocelot_bulk_read_rix(ocelot, reg, ri, buf, count) __ocelot_bulk_read_ix(ocelot, reg, reg##_RSZ * (ri), buf, count)
+
 #define ocelot_read_ix(ocelot, reg, gi, ri) __ocelot_read_ix(ocelot, reg, reg##_GSZ * (gi) + reg##_RSZ * (ri))
 #define ocelot_read_gix(ocelot, reg, gi) __ocelot_read_ix(ocelot, reg, reg##_GSZ * (gi))
 #define ocelot_read_rix(ocelot, reg, ri) __ocelot_read_ix(ocelot, reg, reg##_RSZ * (ri))
@@ -786,6 +788,8 @@ struct ocelot_policer {
 u32 ocelot_port_readl(struct ocelot_port *port, u32 reg);
 void ocelot_port_writel(struct ocelot_port *port, u32 val, u32 reg);
 void ocelot_port_rmwl(struct ocelot_port *port, u32 val, u32 mask, u32 reg);
+int __ocelot_bulk_read_ix(struct ocelot *ocelot, u32 reg, u32 offset, void *buf,
+			  int count);
 u32 __ocelot_read_ix(struct ocelot *ocelot, u32 reg, u32 offset);
 void __ocelot_write_ix(struct ocelot *ocelot, u32 val, u32 reg, u32 offset);
 void __ocelot_rmw_ix(struct ocelot *ocelot, u32 val, u32 mask, u32 reg,
-- 
2.25.1