Date:   Mon, 10 Jan 2022 14:36:54 +0900
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc:     Jonathan.Cameron@huawei.com, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Syed Nayyar Waris <syednwaris@gmail.com>
Subject: Re: [PATCH] counter: 104-quad-8: Add COMPILE_TEST depends
Message-ID: <YdvF0teoR/ymJJ7e@shinobu>
References: <20220105094137.259111-1-vilhelm.gray@gmail.com>
 <20220109212251.xzwilquctuij5lev@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ANM/I4XkLOKhQBIc"
Content-Disposition: inline
In-Reply-To: <20220109212251.xzwilquctuij5lev@pengutronix.de>
Precedence: bulk


--ANM/I4XkLOKhQBIc
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 09, 2022 at 10:22:51PM +0100, Uwe Kleine-K=C3=B6nig wrote:
> On Wed, Jan 05, 2022 at 06:41:37PM +0900, William Breathitt Gray wrote:
> > 104_QUAD_8 depends on X86, but compiles fine on ARCH=3Darm. This patch
> > adds support for COMPILE_TEST which is useful for compile testing code
> > changes to the driver and Counter subsystem.
> >=20
> > Suggested-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> > Cc: Syed Nayyar Waris <syednwaris@gmail.com>
> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> > ---
> >  drivers/counter/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> > index 3dcdb681c4e4..5edd155f1911 100644
> > --- a/drivers/counter/Kconfig
> > +++ b/drivers/counter/Kconfig
> > @@ -14,7 +14,7 @@ if COUNTER
> > =20
> >  config 104_QUAD_8
> >  	tristate "ACCES 104-QUAD-8 driver"
> > -	depends on PC104 && X86
> > +	depends on (PC104 && X86) || COMPILE_TEST
>=20
> The driver uses inb and friends. Without looking I wonder if there is
> something like HAVE_IO or similar this needs to depend on for that?
>=20
> Best regards
> Uwe
>=20
> --=20
> Pengutronix e.K.                           | Uwe Kleine-K=C3=B6nig       =
     |
> Industrial Linux Solutions                 | https://www.pengutronix.de/ |

If I'm not mistaken, on unsupported architectures include/linux/io.h
will pull in include/asm-generic/io.h which has default implementations
for inb and friends if they are not otherwise defined. It doesn't look
like these default implementations are guarded by a Kconfig setting so
we should be fine in this case.

William Breathitt Gray

--ANM/I4XkLOKhQBIc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmHbxfYACgkQhvpINdm7
VJLyVBAAoJe+migjeZDIOiRWJUsmvSxd9df68w7iRU2LfCGeoX+kDWx9txgsnWyD
MjBzxiILN+I20JxtG+TOZDLfGkN74s8kBnE+tnPp4YEnFtpCbJ1atk5VF1pS82g9
+Ki/RBEVILRM/HsA0Ej/7HbeoQQYp0QO/rSYRvQlp980f6uVeIoHt29DCyGXuzfK
fQEmIrlwC2Tlz/tVmK+ZdHB9Cvo11labhayeuUWt7LSZMIw7Covi3aJBraQPvw1P
/bPEYBTql6Xq0qGsq8jRjWQi0ObU85w+ZxItPEcP89P7ik0GU3O270NSolhEnQpm
1I8w8bgZ1sKc30xrvNHtkSgkEvpfgAgLweRnIPWoYpPZLYrww92lTPwMGwgDYlef
KxF78ljboTCbQfwizDbKVESolRfkN5bHKOVXhpswoN3wWdgpXnqX4YkCizjiB3rH
OxXGHgpk9PiecxP5pyLs/hiT681FEf9k5x4t9uH5zUXoEzFTybYnZfdWYRxzhCdn
JxuD6toO5Xu1b0v84hRD9u3p1XBI1HMC3NqRer8ePJjXcsWegCQ71t8/MS8U1G2G
3y1AKma8Mjx4O7vmA1uPsWumSp8DysdsnK56L11M16W2QsLk4ha4oCbuTwqyg1bN
0aIk0bF5y2jVMCRgnrEdgrKVEMK8gta2LhrpK+FZdJOijXds1zg=
=ll8+
-----END PGP SIGNATURE-----

--ANM/I4XkLOKhQBIc--