Date:   Mon, 10 Jan 2022 09:17:13 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Chen Yu <yu.c.chen@intel.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ACPI: pfr_telemetry: Fix info leak in pfrt_log_ioctl()
Message-ID: <20220110061713.GA1951@kadam>
References: <20220107073407.GG22086@kili>
 <20220107134617.GA895400@chenyu-desktop>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220107134617.GA895400@chenyu-desktop>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Yr7LUWDRQmSf0BePcnymKu1EEt7rflabrMc/60i3EOrsdAUT15unCMdh9KfO?=
 =?us-ascii?Q?oF5Dk2KN2jF+3T4iEk4rIS9ja7H1dKaTYpwzonKA1k9VXOkT2uW6mi0UVVDC?=
 =?us-ascii?Q?ny7vZTGL/ne6UaypHeei1US/4VdIJB+RDZNuZC/P1fwPpOrno3PyxsDH3r1U?=
 =?us-ascii?Q?eLukU4+oewSBrk2V2Xmwq0LJ8YXZRIfP0JF5KPfSoLjPQlLqIi7511pr/8eO?=
 =?us-ascii?Q?0QKdBXhZeMQqiR5tiwuNRv2RKZQKKaXDxa7yIJwVqQCQzSpbW3i5x4O78Mpr?=
 =?us-ascii?Q?cOoW8XcnHnuPLqhm6iNZCAtvQa7UQuNBSGOrfhxGAqZsEQHQXPi2xHMOYGTe?=
 =?us-ascii?Q?dNxCw4nc7fDU3IntSbJK+5zQhzf/bEEdIyHgNK9K0KIiVLioUeTpsv3rUCvu?=
 =?us-ascii?Q?q7bOPy1gMV9WCJCwqYpRevxdlbxxaOnRkcY2Ky30upwsyTKRH06Lrc/4RMm0?=
 =?us-ascii?Q?vkXUGYyOC3fq3owd9Kd8/Ssg/LVx/RCaBLPzXSzStJzbwDcbPsxC/epzV1FR?=
 =?us-ascii?Q?m3V399UxZxb9TFztGV8ruStWJD2VQbN9zrVCrfaDQr4fu+DlRs8+75CL6OdO?=
 =?us-ascii?Q?FyvlCAmJiYwqZZwMllVEYLG/XlsjW9jsLNxbt6gOyal2crCcuz7UsDqsggDq?=
 =?us-ascii?Q?m9hnKCkaFyxGIzdD5/xInfVkgD+FOX6XhPSUNywEAeWxVZM1c2kf3fl0Pwle?=
 =?us-ascii?Q?gznOgeFFoJ5OmpaKkfZ6spXABrsWvWxvoQHHZrJHMM7T4MuAGkwAAn4sWPcx?=
 =?us-ascii?Q?c+nDX5qQapuIE9V/FWbQlKZwyHrcgIBKnSoA+FSp/krzqVWq8XSjvDswFAn2?=
 =?us-ascii?Q?7kg9gZsQHYtRE5hAGodQHdy+5U/Ggo+urTU8Yx7f2odLsUVJUm4LfyvMZIQq?=
 =?us-ascii?Q?P/Cj97lgmeZxDSnPr53TsmWJN5QFRdMAIn2VNwcKQQuCAQer1khhWzFwCJVJ?=
 =?us-ascii?Q?iM+zfIwHpeNtbmOE3wXCoR4xHsdElHygPwuDHD30Efytytl1/z6TyEumD3Wc?=
 =?us-ascii?Q?eBQT2AtpIPMzI1SCmuAwxpfMdURyArTQyXXRwOVNJRW68oDT9RiTLb2f9Ujg?=
 =?us-ascii?Q?N7RkDWr/d2Ti3cyfObd5Jh6otP8hSnhvjtYfMM+miBV/OfJSbfvwTvTKoLVT?=
 =?us-ascii?Q?1KG+j2SkmILvmka1PvMm4t9Xne5k3NJCmKRWkwe5H0sBvBaW6LSiZm/TWo5G?=
 =?us-ascii?Q?ACuIPM4B8wJKSw8yzN4CyeReTmimI3QFrP6mVVA14EdAAJ6cgkv+V4B9SimX?=
 =?us-ascii?Q?Sd0YYf7HOlyOMGymCNWUYfHn6W76S1ZapQW3ozx5dod9ToUcAoFQy/67pvuC?=
 =?us-ascii?Q?JV80XIQKWFCsPXucqlnbm8HQZSnk7hebCg6osEz4Z1xa1rn6FuBVOFrxx0B+?=
 =?us-ascii?Q?CD1/F2jDXagVhAnnL/bkY+dNENymB0MZN6DwbXw57B7Hbr1u4yGCVS63McA2?=
 =?us-ascii?Q?TC5TQQVHgwwXqBoh2XIvOAlxt40+oJvv4sj5OClciCmXhTch8zj59aRkaSTw?=
 =?us-ascii?Q?9PWWq0RxcbynHBKAIp9z9L1SI+Y/InkhR5WZif3jrxs8A9ZDQasBTvFXRG6G?=
 =?us-ascii?Q?cTQ8XG3CjcJPg1V/kK9c+uXznvJZttes3kndRIhXFl4HoNwme51bbQygh9F3?=
 =?us-ascii?Q?8tA2mSI+M1Ljyx/5hz1VNED9MbhkIQpBiIRXrp8l2W3OuYCxiG5X98cIehbm?=
 =?us-ascii?Q?IEnokQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e712ed3d-15ac-4244-04c9-08d9d400e35d
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1001MB2358.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2022 06:17:33.1748
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EZrqYWCAu5HTnPNHSIBwFbKQ/nOXMYDdxxAtVCki8yjB64mrEKwUH904tomskrHlawhSMQ1zFgvSNenUq1wlRXYp+SI5cu4Oqo/q8bDktyw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1286
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10222 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 spamscore=0
 mlxlogscore=999 adultscore=0 phishscore=0 malwarescore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201100043
X-Proofpoint-ORIG-GUID: g4U1g8gjB42-2tTWqSE4meyE6dh2orZ2
X-Proofpoint-GUID: g4U1g8gjB42-2tTWqSE4meyE6dh2orZ2
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 07, 2022 at 09:46:17PM +0800, Chen Yu wrote:
> On Fri, Jan 07, 2022 at 10:34:07AM +0300, Dan Carpenter wrote:
> > The "data_info" struct is copied to the user.  It has a 4 byte struct
> > hole after the last struct member so we need to memset that to avoid
> > copying uninitialized stack data to the user.
> > 
> > Fixes: b0013e037a8b ("ACPI: Introduce Platform Firmware Runtime Telemetry driver")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > When you're adding a new driver to the kernel then please use the new
> > driver's prefix instead of just the subsystem prefix.
> > 
> >  Bad: ACPI: Introduce Platform Firmware Runtime Telemetry driver
> > Good: ACPI / pfr_telemetry: Introduce Platform Firmware Runtime Telemetry driver
> > 
> Thanks for pointing this out.
> > Otherwise it's just up to me to guess what prefix you wanted.
> > 
> >  drivers/acpi/pfr_telemetry.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/acpi/pfr_telemetry.c b/drivers/acpi/pfr_telemetry.c
> > index da50dd80192c..9abf350bd7a5 100644
> > --- a/drivers/acpi/pfr_telemetry.c
> > +++ b/drivers/acpi/pfr_telemetry.c
> > @@ -83,6 +83,7 @@ static int get_pfrt_log_data_info(struct pfrt_log_data_info *data_info,
> >  	union acpi_object *out_obj, in_obj, in_buf;
> >  	int ret = -EBUSY;
> >  
> > +	memset(data_info, 0, sizeof(*data_info));
> Just one minor question, how about moving above before:
> data_info->status = out_obj->package.elements[LOG_STATUS_IDX].integer.value;
> after the sanity check of the _DSM result?

I guess I wanted to keep all the memsets together.  I feel like if the
data is invalid, then it's going to be a slow path and it's not worth
optimizing that case.  If the data is invalid then a little slow down is
the least of our concerns.

regards,
dan carpenter