Date:   Mon, 10 Jan 2022 07:42:01 +0100
From:   Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
To:     Dominique Martinet <asmadeus@codewreck.org>
Cc:     v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org,
        Eric Van Hensbergen <ericvh@gmail.com>,
        Latchesar Ionkov <lucho@ionkov.net>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Stefano Stabellini <stefano@aporeto.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] 9p/trans_fd: split into dedicated module
Message-ID: <a168c7a0-aeb5-4eb1-8b26-751c0560b7ed@t-8ch.de>
References: <20211103193823.111007-1-linux@weissschuh.net>
 <20211103193823.111007-3-linux@weissschuh.net>
 <YduEira4sB0+ESYp@codewreck.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YduEira4sB0+ESYp@codewreck.org>
Jabber-ID: thomas@t-8ch.de
Precedence: bulk

Hi Dominique,

On 2022-01-10 09:57+0900, Dominique Martinet wrote:
> Hi Thomas,
> 
> it's been a while but I had a second look as I intend on submitting this
> next week, just a small fixup on the Kconfig entry
> 
> Thomas Weißschuh wrote on Wed, Nov 03, 2021 at 08:38:21PM +0100:
> > diff --git a/net/9p/Kconfig b/net/9p/Kconfig
> > index 64468c49791f..af601129f1bb 100644
> > --- a/net/9p/Kconfig
> > +++ b/net/9p/Kconfig
> > @@ -15,6 +15,13 @@ menuconfig NET_9P
> >  
> >  if NET_9P
> >  
> > +config NET_9P_FD
> > +	depends on VIRTIO
> 
> I think that's just a copypaste leftover from NET_9P_VIRTIO ?
> Since it used to be code within NET_9P and it's within a if NET_9P it
> shouldn't depend on anything.
> 
> Also for compatibility I'd suggest we keep it on by default at this
> point, e.g. add 'default NET_9P' to this block:

Yes, you are correct on both points.

> diff --git a/net/9p/Kconfig b/net/9p/Kconfig
> index af601129f1bb..deabbd376cb1 100644
> --- a/net/9p/Kconfig
> +++ b/net/9p/Kconfig
> @@ -16,7 +16,7 @@ menuconfig NET_9P
>  if NET_9P
>  
>  config NET_9P_FD
> -       depends on VIRTIO
> +       default NET_9P
>         tristate "9P FD Transport"
>         help
>           This builds support for transports over TCP, Unix sockets and
> 
> 
> I'll just fixup the commit with a word in the message unless you have a
> problem with it, please let me know! :)

Looks good, thanks!

Thomas