From:   Liu Ying <victor.liu@nxp.com>
To:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     linux-imx@nxp.com, Rob Clark <robdclark@chromium.org>,
        Sean Paul <seanpaul@chromium.org>,
        Zain Wang <wzz@rock-chips.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
Subject: [PATCH] drm/self_refresh: Don't trigger the entry timer for self refresh work if CRTC state is inactive
Date:   Mon, 10 Jan 2022 16:09:52 +0800
Message-Id: <20220110080952.3345674-1-victor.liu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MbxTH8iTDYJ1Z2bu2TnG9l5hpTZdapbh8j8eN9+rhemtYwS3uiTWE1KSfZV3?=
 =?us-ascii?Q?/kE+2cYbqAw49/HvLqzApfrw6f2iMKShYLVhCvOwoEGJOjsNeb0BWhaVKzwq?=
 =?us-ascii?Q?g2P0YiuDMwvZ1kYgIkNkgle5Lz2u+iQgTg60FluT0MtKoxdLWtPoulyhvAIJ?=
 =?us-ascii?Q?7mseIwBm8giMzAgO51DsQRCdJshuhcfnZuiVvHn0rrukZAZxpwbn0ugZD7Mu?=
 =?us-ascii?Q?VWUS7OGhu+DZp8lYPNKacDXGPYkkRpObL9MWm7h4WJDl5CwVuuDEv4+cMWLT?=
 =?us-ascii?Q?K1FAeOqQXyoG25vGNRxtjHGFPi6OK0eMGX9yPYh3zG7Z3kgX5Eh+koYpRWbh?=
 =?us-ascii?Q?DIX4glXfklFsR1nU10vl0ze1pMVNABSvRWvyaIADgPTOKe7lLL1NsmaZ8LgC?=
 =?us-ascii?Q?NxEoHfHq7/Rnjl64vwRlTmIYXJzksF3YqIzNKXoIY0kmKMI7JGvsN3a9Tf34?=
 =?us-ascii?Q?tcpbNw9xmAXE5Qn6Dozl88dBb4wZQiCiUfJu1JOfiLJq7IPUPxytKVm6eI+7?=
 =?us-ascii?Q?+oIw1YzskzC76X4ayf8YDfe77ioPSuZ8YRIRaJYSZ6yxIhPJ1p5Bh6GIj6PH?=
 =?us-ascii?Q?QORkFeDVGIZ7w3r0eQSi7kpWS/VTuGZJ02ffrtKzoEg+MyVWC8YQR5CzuIFb?=
 =?us-ascii?Q?OgG6rwX4ajAFP9RDHnImsV0bVh70UXpji+Slc3M5Yf7bFRvbdGqqyt3N0YqJ?=
 =?us-ascii?Q?5bByNEj5Dth0fAQp15HTRU5e6Uq+dOlHWhUu7ibaZJa1QdFQujaMJeIx4uLN?=
 =?us-ascii?Q?2Ioh2qe/Za1vR13X56hDeX4t6KwntThQmFw3LjMo85ax5lQvYhPfP1iuGk//?=
 =?us-ascii?Q?DxoybNJg6d2YcSF4/b7O8B4O9HUzJHplqmxXM1k6g6RBn05gglG8IqdSaVaS?=
 =?us-ascii?Q?7dLvqO96u+8TY9icTjiaXiRmaz6GiA8diwAD/6n0vgq4acUKP2fHX9uGsAnt?=
 =?us-ascii?Q?iWriXASX7G0OVW1X8gsqSfrAJT8vNB/HYXSCpBSZu2Wo2SqXOyk19qeF2SuR?=
 =?us-ascii?Q?1g4zp9V7yg6fuzBW3m0Oyr+3kaLoh/Hq7ACMXd68st0OO92SIi/W35iJghm6?=
 =?us-ascii?Q?JOXX5gTTjiNgDgvQeOmpI7+Gybby+Q+0lmp0lQYvRf13fxwhH6xC1xb49ZeM?=
 =?us-ascii?Q?/gzhJUTvUKb+7Vf8CZfqVLCIP3hQlrwiPkTMFwZcF3oXkHsvaqzyX2GcqsG0?=
 =?us-ascii?Q?dNyZXzVaR9eOZDf7CSfOSkX2Bi9fMKOUvHpLLky0AKfLCVBy1ayoYaZShQED?=
 =?us-ascii?Q?4lkzdlqioRXIwNipnVJpLDnAH2KEWelHrfCRsZhr1+vt67u0RjWue1V4ckZu?=
 =?us-ascii?Q?Fa0nWZZAynrB58zi7t3QpTcoomfa5KLI4WkjKqc3SzJxPqDRutXkXevJrWu1?=
 =?us-ascii?Q?WEKi/H2ZbMcpSEaoPHhjiDjHyoBpG5AGTDDJQHiLtERrfZiGazwUyypnI51s?=
 =?us-ascii?Q?bIvmI+8Swuw1xG5vNq+Q6+Pq25YApMPsVUyGHPNsnOCoRiq4nl136zvbsV8P?=
 =?us-ascii?Q?4Z9293HNpZCqZyTU/s9ENIlTRF0KzmsGaOAYZ7I/wEHAPLH3oJ/+kfqNx346?=
 =?us-ascii?Q?8Y2QZMwFoUZ0chr5PNi+3Coel3El4S48ZYTZpIA3wgkPx6SEaT/LEDt1/XVb?=
 =?us-ascii?Q?6Iegz3WR7R098/pT0FfOi44=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71fd7f19-8837-4054-7d88-08d9d410b738
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2022 08:10:51.1101
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rZeLbfLDyhUNGfmgTu52xqZO94kBvqErfng1DdIEBbJtDz95hbOFmqtspo/2i3tKYmnpJNmc3gp0wK9ZcP77lA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5512
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

If the CRTC state is already inactive, it doesn't make sense to trigger
the entry timer for self refresh work to make the display enter self
refresh mode, because the disabled CRTC hints that either the entire
display pipeline is disabled or the previous atomic commit is triggered
by the self refresh work(the CRTC is disabled, while the relevant encoder
and bridges could be disabled or not depending on the drivers).

Cc: Rob Clark <robdclark@chromium.org>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Zain Wang <wzz@rock-chips.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
 drivers/gpu/drm/drm_self_refresh_helper.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_self_refresh_helper.c b/drivers/gpu/drm/drm_self_refresh_helper.c
index dd33fec5aabd..e76eb3cd22c7 100644
--- a/drivers/gpu/drm/drm_self_refresh_helper.c
+++ b/drivers/gpu/drm/drm_self_refresh_helper.c
@@ -204,8 +204,12 @@ void drm_self_refresh_helper_alter_state(struct drm_atomic_state *state)
 		struct drm_self_refresh_data *sr_data;
 		unsigned int delay;
 
-		/* Don't trigger the entry timer when we're already in SR */
-		if (crtc_state->self_refresh_active)
+		/*
+		 * Don't trigger the entry timer when we're already inactive.
+		 * Note that the inactive state hints that either we're already
+		 * in SR or the entire display pipeline is already disabled.
+		 */
+		if (!crtc_state->active)
 			continue;
 
 		sr_data = crtc->self_refresh_data;
-- 
2.25.1