Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 580E1C433F5 for ; Mon, 10 Jan 2022 08:40:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241793AbiAJIjc (ORCPT ); Mon, 10 Jan 2022 03:39:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241817AbiAJIhW (ORCPT ); Mon, 10 Jan 2022 03:37:22 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 755FBC029828 for ; Mon, 10 Jan 2022 00:37:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DpKvSwxbbfQbLZApW/SnZkrEtdEJ/1VZArTMlGDXrSM=; b=Y7BsiipGKK2DffmCmd+iLr0YAk V6JtBSMvnBLFpbxfWYrUkKYID7QJs3IFPJks+isIeD8pDYZx0VHkqLLKE4nhn5sjXCADItWkKgquQ 2shiUoZFHPNvciDHeWQaOK3tc4Oc/Iv5RuzmxuK42ea5NgCs7CJw9tnKZ81i5ofmWG5ZR4Oc/OUai 4SmqWj9ldQ4UiTsh+0B96aWwz2UgLYsXaVVJ/Y/SPdbRdDbdJS/8PSVzYuIMcRfh+w8FLqpwQplca 4NWpcN1RVFrvkMZFOEYnrWnfDOk5MIZX8ZDQZ5rgH6wlmSBJg2N4HwD/rTQ/w/vvW1bGSIQjubkX+ Su0VXJjQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6qB5-009vpK-1N; Mon, 10 Jan 2022 08:37:19 +0000 Date: Mon, 10 Jan 2022 00:37:19 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, John Hubbard , Christoph Hellwig , William Kucharski , linux-kernel@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH v2 20/28] gup: Convert gup_pte_range() to use a folio Message-ID: References: <20220110042406.499429-1-willy@infradead.org> <20220110042406.499429-21-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220110042406.499429-21-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 10, 2022 at 04:23:58AM +0000, Matthew Wilcox (Oracle) wrote: > We still call try_grab_folio() once per PTE; a future patch could > optimise to just adjust the reference count for each page within > the folio. Looks good, Reviewed-by: Christoph Hellwig