From:   SeongJae Park <sj@kernel.org>
To:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc:     SeongJae Park <sj@kernel.org>, Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        rust-for-linux <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH] init/Kconfig: Specify the interpreter for rust-version.sh
Date:   Mon, 10 Jan 2022 08:41:16 +0000
Message-Id: <20220110084116.4589-1-sj@kernel.org>
In-Reply-To: <CANiq72muzMPVUNJQU7Vcx0uCSEZc7Y_67LuX7PB=xNkCJ+NX7A@mail.gmail.com>
Precedence: bulk

On Sun, 9 Jan 2022 21:38:40 +0100 Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:

> On Thu, Jan 6, 2022 at 1:34 PM SeongJae Park <sj@kernel.org> wrote:
> >
> > Some common tools like 'diff' don't support permissions of the files.
> > Due to that, 'rust-version.sh' in some trees including '-mm' result in
> > having no execution permission, and therefore build fails like below:
> 
> Do you mean the Quilt workflow? From a quick look:
> 
> https://lists.nongnu.org/archive/html/quilt-dev/2008-01/msg00000.html
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749069
> 
> Is that the issue? I am surprised it loses that information...

Right.  I once encountered similar issue with DAMON kselftest[1], and as a
result we made kselftest deals with such case[2].

[1] https://lore.kernel.org/mm-commits/YRJisBs9AunccCD4@kroah.com/
[2] https://lore.kernel.org/linux-kselftest/20210810164534.25902-1-sj38.park@gmail.com/

> 
> > It's not a big deal, but not so fun.  This commit fixes the issue by
> > specifying the interpreter for 'rust-version.sh' in the Kconfig file.
> 
> Other script calls do not do that, so I would prefer to avoid it. But
> I can take it temporarily to help you (until we are in mainline, if I
> understand correctly the issue), but I would prefer to have a comment
> nearby it justifying the workaround and explaining when we can remove
> it.

Fully agreed.  I will send v2 with the comment.


Thanks,
SJ

> 
> Cheers,
> Miguel
>