From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     jiabing.wan@qq.com, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] regulator: qcom_smd: Add of_node_put() before return
Date:   Mon, 10 Jan 2022 17:29:14 +0800
Message-Id: <20220110092915.1444044-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TuO1Klo69svqQWEgqWqjidtqXozOUQPKl/7qKogTBRk2ptXbL+bBR5S+PHOh?=
 =?us-ascii?Q?W5jISkXycJhlNzLNUjcyGRF1NfEGnVDWcadDw/Jpx+zRYqwdHgXJEMY6Zigp?=
 =?us-ascii?Q?IcVtWFN0+csM/MXge1SuGcXtZ8IaJxrPVGWPe/PSMPKJvaRuRQ0fmK0qRUU6?=
 =?us-ascii?Q?Xrq3B6VmuLnG1aXLkKtpVNNcUv0wDspQ5TH8lwSD+wFbcCns8FZbttt7UR59?=
 =?us-ascii?Q?4dU0ONQSot3YlJBJSmAwlh6uobmHmR5H/soUCq/mNdVcSl5SFwA2jm+JSnpS?=
 =?us-ascii?Q?uMmOws1SdsgjL1ybZAIUEtQlTd33g5eG+IFKdKNt17L7TQwDYUF5W6BmtGyh?=
 =?us-ascii?Q?BzQ1LhP6SRpUaVCi+xHIiAG/Jc3sLTcJA1bfa4K8/+7ekNhhu9zXGWF+++jX?=
 =?us-ascii?Q?DLBhUYFnao6aA49FMJNeesvKaIeLbIU1YFRLV17bSutXVE6TzhVLtEkwEuWm?=
 =?us-ascii?Q?6C9UIpjbouAcwvbyzYl5saBPJcc9O5KrjzJXhgz1Qs99FTor1GCR2FdQeD66?=
 =?us-ascii?Q?kz3Y8zUXxhHrS8SCYJbRyG99lzW6ICsffFvr6D7w59CHsJnYsuTtV35WuNmq?=
 =?us-ascii?Q?uCT7tGqPOHsHSQRc8LgKjhjpBStMXIFfRR+DVMyqL8mywyVEHsRfZLLYBave?=
 =?us-ascii?Q?KZnmS7JgrWWSLsBNrkGgfvRCdHzp0Bzz2ZnBuZdn/lMdYjQgzZk88ldP+rLt?=
 =?us-ascii?Q?v5CI3UmRPCrgr3h0vrejkeWskEDkBu5icB3Xk7EvzGxB+8w4JpcBFU5bJFQy?=
 =?us-ascii?Q?nOoF3JEOaOoQssfzk3vNdziashuDUJFrtfIAisX9RvBK8FjuEBV+ugccENNc?=
 =?us-ascii?Q?HCI02V8tRHVgHLDWBbw4WPExRPg9GAbC8JOmVepCqNAmvEtmN5gbYBImTHYe?=
 =?us-ascii?Q?lDbr8gpSAecNory8puM92HNStyKCf6r3CPTL7J+xBWeJD9/niqm10egPJpHv?=
 =?us-ascii?Q?cYvzR9rQuYV9o5ZUjJZCwe7kh2gmSYgzmiLueAgrhK8nn51BfH1dAiiWYKMi?=
 =?us-ascii?Q?I9McXi5EJuS85WXO2W7oXnbdKwVXm+LcH7V89hNszCP4rtbZTcOxecF4ZbQu?=
 =?us-ascii?Q?2B83Zh+rK7A/eYWrWWQVTjeO/NIvDOGlov9jS1PLxhdRzrSsRkVULDYhW60s?=
 =?us-ascii?Q?CIMrZeJ9P5J0Y96AB/N5uUyFBrVR3in4qEVOOMvwh1/LH3hAVSPKtgG3Kp9Y?=
 =?us-ascii?Q?kOGxSHiHJb/z8MyhGWsQi0QeKQ/WNS60bIDYIhtwDOc1XnH4BerWvvsAYcJm?=
 =?us-ascii?Q?EV//qIHu4YJF+Gp2Pmm4J+jV3HpvkOJi9NqqQN+A2/p5i/43ATM/lTsfCTsx?=
 =?us-ascii?Q?licmvxjIjlSRTZbXCg0EBN/5k69aa50Z4k81QsvalIsVURAZVEFKrslZAovn?=
 =?us-ascii?Q?Ktb1Y1AGPr88bIZizXFyU1xMioGTTk/v2WR+tN4m6wboPga81hcmlbeS0a2A?=
 =?us-ascii?Q?e1grMWhvsBnLG00XyA9Ks8FRKhdNne9V9zZoGSX+9hJI5VoueTkVqyKLlgRq?=
 =?us-ascii?Q?0EMrKypVmYgEMGR16Ih+tKxB2bftZfVdF5ZYTDkWJDqnXn6KejG1HBTG1qlB?=
 =?us-ascii?Q?nLVksBBeaB49S5jg326fWwzfqW7tGodQojohhznRlSxqVbq93l/oVzmi8ukK?=
 =?us-ascii?Q?lV8Xvj7Zn5gdHBfqKmsV1fc=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40f1a26b-a01d-42b7-c7ef-08d9d41bbda1
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2022 09:29:46.5181
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ON3qzlTbwE7nUB0LhvPUBqyxMXw85s91W6Mfu3CjNlniTzujeLwyeMSlzNh4kJS2mVwU9l9tkZJDtWGTVXVHmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3451
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/regulator/qcom_smd-regulator.c:1318:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before return.

Early exits from for_each_available_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/regulator/qcom_smd-regulator.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
index 9fc666107a06..8490aa8eecb1 100644
--- a/drivers/regulator/qcom_smd-regulator.c
+++ b/drivers/regulator/qcom_smd-regulator.c
@@ -1317,8 +1317,10 @@ static int rpm_reg_probe(struct platform_device *pdev)
 
 	for_each_available_child_of_node(dev->of_node, node) {
 		vreg = devm_kzalloc(&pdev->dev, sizeof(*vreg), GFP_KERNEL);
-		if (!vreg)
+		if (!vreg) {
+			of_node_put(node);
 			return -ENOMEM;
+		}
 
 		ret = rpm_regulator_init_vreg(vreg, dev, node, rpm, vreg_data);
 
-- 
2.34.1