Subject: Re: [PATCH V4 0/5] the UART driver compatible with
To:     Yu Tu <yu.tu@amlogic.com>, linux-serial@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>
References: <20220110085604.18042-1-yu.tu@amlogic.com>
 <1f4b9288-c7ff-c895-425c-187d058642b9@baylibre.com>
 <a19771e6-d1d4-d1ef-9819-21e2147aad16@amlogic.com>
From:   Neil Armstrong <narmstrong@baylibre.com>
Organization: Baylibre
Message-ID: <d14fdcd5-99c2-6aa0-085e-5355ecc0febf@baylibre.com>
Date:   Mon, 10 Jan 2022 10:43:02 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <a19771e6-d1d4-d1ef-9819-21e2147aad16@amlogic.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/01/2022 10:35, Yu Tu wrote:
> Hi Neil,
>     Thank you very much for your reply.
> 
> On 2022/1/10 17:27, Neil Armstrong wrote:
>> [ EXTERNAL EMAIL ]
>>
>> Hi,
>>
>> On 10/01/2022 09:55, Yu Tu wrote:
>>> Using the common Clock code to describe the UART baud rate
>>> clock makes it easier for the UART driver to be compatible
>>> with the baud rate requirements of the UART IP on different
>>> meson chips. Add Meson S4 SoC compatible.
>>>
>>> Yu Tu (5):
>>>    dt-bindings: serial: meson: Drop compatible = amlogic,meson-gx-uart.
>>>    tty: serial: meson: Request the register region in meson_uart_probe()
>>>    tty: serial: meson: The UART baud rate calculation is described using
>>>      the common clock code.
>>>    tty: serial: meson: Make the bit24 and bit [26,27] of the UART_REG5
>>>      register writable
>>>    tty: serial: meson: Added S4 SOC compatibility.
>>
>> Weird, the subjects are fine in the cover letter but are all truncated in the email thread:
>> [PATCH V4 0/5] the UART driver compatible with
>> [PATCH V4 1/5] dt-bindings: serial: meson: Drop
>> [PATCH V4 2/5] tty: serial: meson: Request the register
>> ...
>> Only the last one is OK.
>>
> I saw the subject was a little long, I changed it manually, do I need to regenerate and send?

yes please, the mail subject will be the commit title so it must be short but descriptive enough.

"dt-bindings: serial: meson: Drop" is too short.

"dt-bindings: serial: meson: Drop compatible = amlogic,meson-gx-uart" is ok but formulation is wrong,
and remove special characters like "=", "[", "]"...

The best title could be :
"dt-bindings: serial: meson: Drop legacy amlogic,meson-gx-uart compatible"

If the subject it too long, reduce it and enhance the commit message with the details.

Neil

>>
>>>
>>> V1 -> V2: Use CCF to describe the UART baud rate clock.Make some changes as
>>> discussed in the email
>>> V2 -> V3: add compatible = "amlogic,meson-gx-uart". Because it must change
>>> the DTS before it can be deleted
>>> V3 -> V4: Change CCF to describe the UART baud rate clock as discussed
>>> in the email.
>>>
>>> Link:https://lore.kernel.org/linux-amlogic/20211230102110.3861-4-yu.tu@amlogic.com/
>>>
>>>   .../bindings/serial/amlogic,meson-uart.yaml   |  10 +-
>>>   drivers/tty/serial/meson_uart.c               | 244 ++++++++++++------
>>>   2 files changed, 177 insertions(+), 77 deletions(-)
>>>
>>