From:   "Bhandare, KiranX" <kiranx.bhandare@intel.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
CC:     Song Liu <songliubraving@fb.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Yonghong Song <yhs@fb.com>, Martin KaFai Lau <kafai@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        "Andrii Nakryiko" <andrii@kernel.org>,
        =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "Jakub Kicinski" <kuba@kernel.org>, KP Singh <kpsingh@kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH v4 net-next 4/9] ice: don't reserve
 excessive XDP_PACKET_HEADROOM on XSK Rx to skb
Thread-Topic: [Intel-wired-lan] [PATCH v4 net-next 4/9] ice: don't reserve
 excessive XDP_PACKET_HEADROOM on XSK Rx to skb
Thread-Index: AQHX7D0HTX5HBo8JUESTUj5tOMV396xcPJ1w
Date:   Mon, 10 Jan 2022 10:13:17 +0000
Message-ID: <DM6PR11MB3292FE1773DEDE04685C35FAF1509@DM6PR11MB3292.namprd11.prod.outlook.com>
References: <20211208140702.642741-1-alexandr.lobakin@intel.com>
 <20211208140702.642741-5-alexandr.lobakin@intel.com>
In-Reply-To: <20211208140702.642741-5-alexandr.lobakin@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?15qYl2sKOlengDS9WHg8+qfQFh5pLjNF+/geUr7fiN3Zu4hAau36MINTsd?=
 =?iso-8859-1?Q?l9l4r5E5GZ/l1fwJaQ712lojvfZFNv0GetCEJWMFZm3fhDSPQpeqqn11TV?=
 =?iso-8859-1?Q?+y2G5Hvldcc7C12zuKYVIaeGUCHYKi7xbQuPkvPWPd/rDn/3HD9lpUNMrT?=
 =?iso-8859-1?Q?GqZ42oAzI2ZkvoL9sjKUsXMfL5k7KuPhmhUrxfFjB0xMMDqtHtwwDM5bs+?=
 =?iso-8859-1?Q?resH87j/TFYpHXS0XWewls+5pFLd8zGCEOcdS1vLaeSbK6nzJLA1znoUua?=
 =?iso-8859-1?Q?+k5BstLGJk5yYVBjKUcVPFIVgmgts8PXeSiYYwnufZ9UvkqYhr6HV2bImj?=
 =?iso-8859-1?Q?IwXxIzKgWm56b8OEjhqvj4Xcj52ZDFwqyYRh1XWwfaVZ5Gyqbh+rHVxF2m?=
 =?iso-8859-1?Q?VjJjCcIPicX0o4hWE5/mQ1QtbBoR2S2uV0LcJ+UiAjYusb0Uo82nsyPwzg?=
 =?iso-8859-1?Q?KnjigHZtXZ9NGujhHcD6AfkT4y3c940+b5zpKzTfe9pV8rAjHe3CfjVWsy?=
 =?iso-8859-1?Q?zRpljWZOSuSVSoSPSXKMv4T+f+1Q2vi238IPKZ84vFJk3UPF9zuLvkTZ89?=
 =?iso-8859-1?Q?Bd2JzVS8EuSW3IMtWEV3SZ9+ayRp30VIWQdfOXs/YpbPXMhEacb30A0Qyo?=
 =?iso-8859-1?Q?dTCHwcNgl5YDzQ3IgdgIQwbKZJ1Nf9DiAICfYi0WOTfLWvyidx8EHXrZgv?=
 =?iso-8859-1?Q?/uX7AxHeAJUhGfIKbv4z7SLvaCFei0CbGhTZuoyt+W8xRHqeXJtnwMq/xk?=
 =?iso-8859-1?Q?Rfe3a3EIVCbEtA+LmfvE4Oas5kFng2T5UN/QYykZxNwtE28AkaAYXihvoj?=
 =?iso-8859-1?Q?H7OcGEx339R1PHj9eZte1qLtUPdsiP2No5AAtuWUMe2z+ckkqch1ZCy40q?=
 =?iso-8859-1?Q?cilgZjFL8bA9TymDlFiFDKeHVBCOhbE0AOGSLoRo+UiLxinxsans+hykrR?=
 =?iso-8859-1?Q?xLLnQRvzQ5NYjg4y1hyGRhjyhsgHx3+0/96scAs1Bvp3gkvgP4AALHG2gH?=
 =?iso-8859-1?Q?3YxiHiUtyBJ7lfofEXTsfKozWIJXggFqRo5Xs0tymu4UPIKy5GHWUwnItC?=
 =?iso-8859-1?Q?OHF2L5zoxPMwC7UL0M3Es6DOe2x/wvaRCsogjT/FKI7BXVFruHGyGO7FkR?=
 =?iso-8859-1?Q?1wJUrMEk8upXHgm8fWOckTID6vbQSk0YUJHQ2PRjxWse6oXflD0PnOcccU?=
 =?iso-8859-1?Q?l6bM5oU49V8YGcpease6qLsIyxwbwOeWDLWGbWzxp3sD/GwCUFFnZaX5LS?=
 =?iso-8859-1?Q?CX7SqUM56WlnuFj3l8mUQ5a6O1uBWF3TouyUD56YNkyGgWoOy1fF/6Kbjf?=
 =?iso-8859-1?Q?iFEpVeG8W+zWWE8IDd5+kOq/3syQbFK4FRO4KlOZoVLtQAjJrTFl3SrAhS?=
 =?iso-8859-1?Q?9JlizQMMv0+ypDjS8XKhmKA4G1YgqjNaA09Qd22hzModabPXGXGPUG+23l?=
 =?iso-8859-1?Q?8Jww1h5aJ3ighOvlzPMTsXL15vfgFi64nHywnP9GFykULZWCgUPC3x9PRG?=
 =?iso-8859-1?Q?w7zr41aBRniXa1hRvQ4tG5paYMyfy0bNhRWWm+5rkW8DpWC9/DoTMfcweH?=
 =?iso-8859-1?Q?rTnthIjUkP3ma4RLboa0DxZEjZInBr1u4Cj5lr/SD4O3HW9oXNcOluPsiq?=
 =?iso-8859-1?Q?FB1qgJjST46acV0r2hA7DgRxAq508bei6T6Ig4KKq+U4JctFgu0eD3MiLc?=
 =?iso-8859-1?Q?lQoUPWRIIGKZonYJL2DKkvhR2/tCLNSi07w7jzbDda+jmqPVHn4fds+mHL?=
 =?iso-8859-1?Q?NWbw=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3292.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71ca4535-703f-49e6-1dc4-08d9d421d25c
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2022 10:13:17.7428
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PGcgUDQ+0MVN7d/6WO2reiA5QtL7DsPyn4F7HYxefBp8inxzvPzl8JcX8EbdnA6xZdZisBoQubHp3aMACrrxu4wsJlA6tWZimoskGwmZrVY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4153
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Alexander Lobakin
> Sent: Wednesday, December 8, 2021 7:37 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Song Liu <songliubraving@fb.com>; Jesper Dangaard Brouer
> <hawk@kernel.org>; Daniel Borkmann <daniel@iogearbox.net>; Yonghong
> Song <yhs@fb.com>; Martin KaFai Lau <kafai@fb.com>; John Fastabend
> <john.fastabend@gmail.com>; Alexei Starovoitov <ast@kernel.org>; Andrii
> Nakryiko <andrii@kernel.org>; Bj=F6rn T=F6pel <bjorn@kernel.org>;
> netdev@vger.kernel.org; Jakub Kicinski <kuba@kernel.org>; KP Singh
> <kpsingh@kernel.org>; bpf@vger.kernel.org; David S. Miller
> <davem@davemloft.net>; linux-kernel@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH v4 net-next 4/9] ice: don't reserve exc=
essive
> XDP_PACKET_HEADROOM on XSK Rx to skb
>=20
> {__,}napi_alloc_skb() allocates and reserves additional NET_SKB_PAD
> + NET_IP_ALIGN for any skb.
> OTOH, ice_construct_skb_zc() currently allocates and reserves additional
> `xdp->data - xdp->data_hard_start`, which is XDP_PACKET_HEADROOM for
> XSK frames.
> There's no need for that at all as the frame is post-XDP and will go only=
 to the
> networking stack core.
> Pass the size of the actual data only to __napi_alloc_skb() and don't res=
erve
> anything. This will give enough headroom for stack processing.
>=20
> Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_xsk.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20

Tested-by: Kiran Bhandare <kiranx.bhandare@intel.com>  A Contingent Worker =
at Intel