From:   "Bhandare, KiranX" <kiranx.bhandare@intel.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
CC:     Song Liu <songliubraving@fb.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        John Fastabend <john.fastabend@gmail.com>,
        "Brouer, Jesper" <brouer@redhat.com>, Yonghong Song <yhs@fb.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        KP Singh <kpsingh@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "Martin KaFai Lau" <kafai@fb.com>
Subject: RE: [Intel-wired-lan] [PATCH v4 net-next 3/9] ice: respect metadata
 in legacy-rx/ice_construct_skb()
Thread-Topic: [Intel-wired-lan] [PATCH v4 net-next 3/9] ice: respect metadata
 in legacy-rx/ice_construct_skb()
Thread-Index: AQHX7D0Gy8Fb3GycJE2mAj1DNm0MGqxcPZ2Q
Date:   Mon, 10 Jan 2022 10:16:24 +0000
Message-ID: <DM6PR11MB32929E15779B9451D1CE5E98F1509@DM6PR11MB3292.namprd11.prod.outlook.com>
References: <20211208140702.642741-1-alexandr.lobakin@intel.com>
 <20211208140702.642741-4-alexandr.lobakin@intel.com>
In-Reply-To: <20211208140702.642741-4-alexandr.lobakin@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?7+kCUp7byhrC7avxDNm4QNfyYLxk8i4bMVRfqVegU9awdfvZajA1yvuXoM?=
 =?iso-8859-1?Q?jPFbNuVhpHjBQYMf9Vm5dV70VDrprN/lnoXa1DmulermgglGsEIvzqDxvc?=
 =?iso-8859-1?Q?+p236wy++Yvv+IAnBT0edihJ7xun4vlmiyVgjM864RQAnCyBfJrCFP0fkp?=
 =?iso-8859-1?Q?jI3lM/sTQ63l0ZkZXze/GqCxGNXbhLpjn9pMTIk6BUpgQCiPSbJG+nbHrc?=
 =?iso-8859-1?Q?4OQbJ7EHQkrdRxm8QZ2er/yJTd3uL4vcy3wMcfTy1kHPB4Di/GzJdoC5LX?=
 =?iso-8859-1?Q?Pyme/L4TXCh7JoWE6LPzDbGD6+lUyJJGhrfFZbLbvgMAtggXnHgzKWXqMz?=
 =?iso-8859-1?Q?GX/xU+WYUKPoQ45SAyUQYqsz/yTR7LgYuCldiKT5rcLbEfiGiHTpT5syVN?=
 =?iso-8859-1?Q?swsSMsirmaptxYeTTZMGEyhUgnyI99haEqamCVoXWXY5DBjYUnX0x+8K2I?=
 =?iso-8859-1?Q?KbjVjvJeiL7sMUdnR6m/k94cXY9cbJ0Sw4N9oyhEFpvjLqUSHh8ERIEP+t?=
 =?iso-8859-1?Q?fdNRgOscvS6JwhZPNtk446sKLqkUdd+e3xL5ryWB9Em1ADDnOK0VhL2unq?=
 =?iso-8859-1?Q?n41X+1rHBr/yhqPVIOehG+ji5CBDLYx6xXUXCQcA3kIHA0JnGcqwW6X3KT?=
 =?iso-8859-1?Q?iBlcdhkHE0mOl2oVZSx9cHHGzevVCLc0hTI6RDd+6A92/h1V4ouLyp2yO9?=
 =?iso-8859-1?Q?F8y+83rCwTzifjevwvV2TDfd1hqIf16M0pa0DG6u7v7AYKLJv7mvQrH86n?=
 =?iso-8859-1?Q?UX/JBsZNBpkRqIIiQ9LyYH0TG6GvauhvJDr4z0FjBDs+J+eKi1HHEm6AlX?=
 =?iso-8859-1?Q?5YQeU6jfU+08z0g5pHHMklw+2YV43Gd0JvWVsdfzTYoHZSdB959UrzQOhL?=
 =?iso-8859-1?Q?PbtTr5wWLc1mg/gi9XQbo8odw+n6iqJG1q9e4rhclOg06/eom+t2bySnGQ?=
 =?iso-8859-1?Q?QWkhowJKZMnujOIhMe0xTWd+wngOzA0ujmTUZZHRGp/qCQCx1AGUS4QKl2?=
 =?iso-8859-1?Q?g7gbCf1f8cmEXH5slKQf03QbiVNJvKEd3vVuK5H8EzKTLBJKpNGJfXyhHI?=
 =?iso-8859-1?Q?xZ7E/Ypygovbh5+e7i+j3nMUx4zYVT0adzYaymqD/T938hvNGDBGZe7WlQ?=
 =?iso-8859-1?Q?t5jPoH2ERDnVsrmDeVrZvTDk16q/PRfeldtMAQA3i3+Nz4lay8GffQgw+e?=
 =?iso-8859-1?Q?aoqyNMftnKzDOwk3401ZzW56J14mtkt7vw7iUPQzS/FEU7myLUZFrIQw7x?=
 =?iso-8859-1?Q?IU5g3u2OuW/bCz+Xqxskky6AYndpCy658LweRmEAVjSFQCxVTE34wEYpHK?=
 =?iso-8859-1?Q?zC6o6C/X67JiHtluTAnBoIPJND+m9y9bTEP6+rVG9CBKAKUQRJeIxhDiFx?=
 =?iso-8859-1?Q?morCnywsasyVWmMRroYiS3D9mFPWmrAoOhtpLBi4XZFXkEzh7PKjo4ezKk?=
 =?iso-8859-1?Q?CKp03H4M747juKgYLth6+6pE7Zl3X24hEZHAUBIYppbVB1goq16aHM/QVe?=
 =?iso-8859-1?Q?6D3iE/KIb7kuO5y9RRxeIPNgmRacwrpgd7S27viHvnj4pnpv0kzBaw9MJU?=
 =?iso-8859-1?Q?Ppug/l7q+Yqg9oS/GDTpjJtmLN4PwF3XNMWLbYz+XvljQJe1cShpINha0M?=
 =?iso-8859-1?Q?NbxtRCMAIHB7/lwRfaS6ArqY8XIS31VVm9nadW06SnZfNZIqSrcnXUGZ4f?=
 =?iso-8859-1?Q?FuS8yhFGN3ZAfOcOW5Jbp2ZTr9Gsp+ugSckjfX8dr+YQV2oqJ61j5cFG2X?=
 =?iso-8859-1?Q?RPTg=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3292.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b7ecf88a-c6c4-4102-b224-08d9d42241dc
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2022 10:16:24.7657
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: A131+tSg5/SG7Gx0xl7MMC2DjaqqYk9vRNzs6xGU3KYG/OACABEUWypYOy/LVuowuy771rUoI9RCWVzyBGfaI/5U86ayneMdleGJZrgUxwI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2713
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Alexander Lobakin
> Sent: Wednesday, December 8, 2021 7:37 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Song Liu <songliubraving@fb.com>; Alexei Starovoitov <ast@kernel.org>=
;
> Andrii Nakryiko <andrii@kernel.org>; Daniel Borkmann
> <daniel@iogearbox.net>; John Fastabend <john.fastabend@gmail.com>;
> Jesper Dangaard Brouer <brouer@redhat.com>; Yonghong Song
> <yhs@fb.com>; Jesper Dangaard Brouer <hawk@kernel.org>; KP Singh
> <kpsingh@kernel.org>; Jakub Kicinski <kuba@kernel.org>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; David S. Miller
> <davem@davemloft.net>; Bj=F6rn T=F6pel <bjorn@kernel.org>;
> bpf@vger.kernel.org; Martin KaFai Lau <kafai@fb.com>
> Subject: [Intel-wired-lan] [PATCH v4 net-next 3/9] ice: respect metadata =
in
> legacy-rx/ice_construct_skb()
>=20
> In "legacy-rx" mode represented by ice_construct_skb(), we can still use =
XDP
> (and XDP metadata), but after XDP_PASS the metadata will be lost as it
> doesn't get copied to the skb.
> Copy it along with the frame headers. Account its size on skb allocation,=
 and
> when copying just treat it as a part of the frame and do a pull after to =
"move"
> it to the "reserved" zone.
> Point net_prefetch() to xdp->data_meta instead of data. This won't change
> anything when the meta is not here, but will save some cache misses
> otherwise.
>=20
> Suggested-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Suggested-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_txrx.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
>=20

Tested-by: Kiran Bhandare <kiranx.bhandare@intel.com>  A Contingent Worker =
at Intel