From:   "Bhandare, KiranX" <kiranx.bhandare@intel.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
CC:     Andre Guedes <andre.guedes@intel.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Krzysztof Kazimierczak <krzysztof.kazimierczak@intel.com>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        "Alexei Starovoitov" <ast@kernel.org>,
        "Brouer, Jesper" <brouer@redhat.com>,
        =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@kernel.org>,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Vedang Patel <vedang.patel@intel.com>
Subject: RE: [Intel-wired-lan] [PATCH v3 net-next 2/9] i40e: respect metadata
 on XSK Rx to skb
Thread-Topic: [Intel-wired-lan] [PATCH v3 net-next 2/9] i40e: respect metadata
 on XSK Rx to skb
Thread-Index: AQHX66z+/1NOFVPHTUGKdB0neu/5fKxcQxTA
Date:   Mon, 10 Jan 2022 10:31:26 +0000
Message-ID: <DM6PR11MB32929AFBEAB5A2F42AC17543F1509@DM6PR11MB3292.namprd11.prod.outlook.com>
References: <20211207205536.563550-1-alexandr.lobakin@intel.com>
 <20211207205536.563550-3-alexandr.lobakin@intel.com>
In-Reply-To: <20211207205536.563550-3-alexandr.lobakin@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?nQoxPISnmUuGNMourHL5DIdrxMvglmEhtHnff++pGnY2ONe4Z2AK1CnTnv?=
 =?iso-8859-1?Q?5NQL+rXQNevN3cFJFm9SvcD0TG8Fg3u2qwGfSP7uuPO//ADBkTjhRwupWi?=
 =?iso-8859-1?Q?87SCh7vUDj6YXYbA98UQLVr0z1lDbEdlvCOF3nmisE+1wriTFl5FIFqFK1?=
 =?iso-8859-1?Q?knINMPjkbOC7TEdT1t+/D0ZKigEST/z1+H8Djlwzf36VKM+EY4LmOjp8Eb?=
 =?iso-8859-1?Q?QajwBnUSEvlbb2cdm0gdi0iRD4J+Pacxe5e0ytZgv7P/nVHfmbdQPZch5t?=
 =?iso-8859-1?Q?CGXpPDUvGdo0sAnC5z1hM55Hxid7yGH57acYpwJDwAdy8vyd5720ZODUqa?=
 =?iso-8859-1?Q?4Rllv+oTj/izc/60zTPzaKwAJWisLHANIe1Cg9sGXuXbtsq7lmoFgd+QsI?=
 =?iso-8859-1?Q?VCoPxS3E1tZA60y472USd0puBkahe8vn+vsJpTNiEdYZHNq29ogyIx9eBF?=
 =?iso-8859-1?Q?UFwN+Mvg7lrCmdhD8lSEwx3r1CdfaJQiUqTQR91eHECbbeoJM30es2SJLv?=
 =?iso-8859-1?Q?eNojnKHp7zpeYtPTY1NGZydpRPsenYG/wGnDZo79Youicq2z4RnfA6x+i9?=
 =?iso-8859-1?Q?j3FrVDKVtuWKgg2uwyvOb+xsqQUHhZdgu6OlWqu7z6azPq9+CNasmiwYnP?=
 =?iso-8859-1?Q?Q5lJROOIBFHtjrm+4c3uUut3V/Ls0XiBH4RFO/iuZAGeVlbL/a25A9cLlj?=
 =?iso-8859-1?Q?aQMM+Z1UvjwpVgrjlo+l1tMDOSgpS5QGXsnAvRH2nPKEGgHF40P5+cYvos?=
 =?iso-8859-1?Q?EFUSaWeifFjIZNAiUIDYXJEgFtYB6vg4wFhQ0XUxfNdYbREKFY/7KnHcE9?=
 =?iso-8859-1?Q?yQmNPyCMsjVHQTtWEYgyjoYUw6ChDbTLirkwh1+iX/Zy7/9ANUeC6Mv8oN?=
 =?iso-8859-1?Q?1/5p2rhetaFyFlaNIXZlzCEBZBpIToe2FJ79siAUP3t4ZI1YBa0kmJgZFF?=
 =?iso-8859-1?Q?WBZx9EKJ5N/C98HmjxEJ4nMtUE64164DHCOUYsj7cxVRUFzm1vM2P1kzdT?=
 =?iso-8859-1?Q?J61JQpXSShWFsZIbwdw6wn9XSKJCIIoa/uxEsajMqEwnVCMlvHukMXWPAC?=
 =?iso-8859-1?Q?24HmwC+7MA7OMVP1LOJGtqwD5cWHpNmk4E4HUpFP/0U3FyIhabPmS8xUPP?=
 =?iso-8859-1?Q?uFge81y0TOk1OZPomwxyJ1CQ8zlDl2f9I0mSbuC1RwpHZJek0nuAF7U9eF?=
 =?iso-8859-1?Q?1RQe4HhEPvuK59/NyP+RiXvvc3q7cgtLkcBsBFKSFJYOOHbg+AqqtJocoS?=
 =?iso-8859-1?Q?kQkTyW609OiygXsElvvkwP4Hg74/Th8EkQevrmgvBLPFJXDtvqOK/+xq8X?=
 =?iso-8859-1?Q?eqWpwMBVxNX/Iy4+kVGq7zw11uMDPDTzeDjYR8f4BlEOjr8jDQbntn+54B?=
 =?iso-8859-1?Q?Uj0zy0+AoLzS6KhIUxYGVmmO+wR4yw4G9y4x4EEkdIj44G15TA28g/dhDr?=
 =?iso-8859-1?Q?8y4SAO0Vjo9VZ3jtB2LsJiZ8p7vtpjWAP1WoRhlo6+00Q4idXP0GMEVJdN?=
 =?iso-8859-1?Q?ZDM25a2obNA+Gj4HBhFDvQ7hI0XN9r+AEFK7HtPBy9glWuujuDDz2xG2O8?=
 =?iso-8859-1?Q?pAFnVOVQFZbcA9mcpDCgCmm31So0KVFM9V9uOSoYpp4Jjv7ewJ5d5q297X?=
 =?iso-8859-1?Q?9jnpQn3sZmjJjoAofa56StOJ5YtoFNFr/anvVjqjRZio/xnDm7MPJuWf2T?=
 =?iso-8859-1?Q?T1aSdDRcrUt2omuwCSexj/cJv19jPyiU5YbWTonVT8M8EqYSplvCN3cJvC?=
 =?iso-8859-1?Q?jeSA=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3292.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2ba02e2-c4d0-4352-acc1-08d9d4245b60
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2022 10:31:26.5828
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: f3p4EvspL9090RyNvxE+0E8Vbx9wymAwrWvRpXdtB6jsqvS/vK7afPrDJWc0cdf8q7znDGiU3/L5Wzegh/Qk1vK/kXqeOuhGXuCT/3h674Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3148
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Lobakin, Alexandr
> Sent: Wednesday, December 8, 2021 2:25 AM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Andre Guedes <andre.guedes@intel.com>; Jesper Dangaard Brouer
> <hawk@kernel.org>; Daniel Borkmann <daniel@iogearbox.net>;
> netdev@vger.kernel.org; Krzysztof Kazimierczak
> <krzysztof.kazimierczak@intel.com>; bpf@vger.kernel.org; John Fastabend
> <john.fastabend@gmail.com>; Alexei Starovoitov <ast@kernel.org>; Brouer,
> Jesper <brouer@redhat.com>; Bj=F6rn T=F6pel <bjorn@kernel.org>; Jeff Kirs=
her
> <jeffrey.t.kirsher@intel.com>; Jakub Kicinski <kuba@kernel.org>; linux-
> kernel@vger.kernel.org; David S. Miller <davem@davemloft.net>; Vedang
> Patel <vedang.patel@intel.com>
> Subject: [Intel-wired-lan] [PATCH v3 net-next 2/9] i40e: respect metadata=
 on
> XSK Rx to skb
>=20
> For now, if the XDP prog returns XDP_PASS on XSK, the metadata will be lo=
st
> as it doesn't get copied to the skb.
> Copy it along with the frame headers. Account its size on skb allocation,=
 and
> when copying just treat it as a part of the frame and do a pull after to =
"move"
> it to the "reserved" zone.
> net_prefetch() xdp->data_meta and align the copy size to speed-up
> memcpy() a little and better match i40e_costruct_skb().
>=20
> Fixes: 0a714186d3c0 ("i40e: add AF_XDP zero-copy Rx support")
> Suggested-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Suggested-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
>=20

Tested-by: Kiran Bhandare <kiranx.bhandare@intel.com>  A Contingent Worker =
at Intel