Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422877AbXBANw1 (ORCPT ); Thu, 1 Feb 2007 08:52:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422879AbXBANw1 (ORCPT ); Thu, 1 Feb 2007 08:52:27 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:51187 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422877AbXBANw0 (ORCPT ); Thu, 1 Feb 2007 08:52:26 -0500 To: torvalds@linux-foundation.org Subject: [PATCH] __crc_... is intended to be absolute Cc: linux-kernel@vger.kernel.org, vgoyal@in.ibm.com Message-Id: From: Al Viro Date: Thu, 01 Feb 2007 13:52:23 +0000 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1517 Lines: 42 i386 boot/compressed/relocs checks for absolute symbols and warns about unexpected ones. If you build with modversions, you get ~2500 warnings about __crc_. These suckers are really absolute symbols - we do _not_ want to modify them on relocation. They are generated by genksyms - EXPORT_... generates a weak alias, then genksyms produces an ld script with __crc_ = and it's fed to ld to produce the final object file. Their only use is to match kernel and module at modprobe time; they _must_ be absolute. boot/compressed/relocs has a whitelist of known absolute symbols, but it doesn't know about __crc_... stuff. As the result, we get shitloads of false positives on any ld(1) version. Signed-off-by: Al Viro --- arch/i386/boot/compressed/relocs.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/i386/boot/compressed/relocs.c b/arch/i386/boot/compressed/relocs.c index 468da89..881951c 100644 --- a/arch/i386/boot/compressed/relocs.c +++ b/arch/i386/boot/compressed/relocs.c @@ -43,6 +43,8 @@ static int is_safe_abs_reloc(const char* sym_name) /* Match found */ return 1; } + if (strncmp(sym_name, "__crc_", 6) == 0) + return 1; return 0; } -- 1.5.0-rc2.GIT - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/