From:   "Bhandare, KiranX" <kiranx.bhandare@intel.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
CC:     Song Liu <songliubraving@fb.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        John Fastabend <john.fastabend@gmail.com>,
        "Brouer, Jesper" <brouer@redhat.com>, Yonghong Song <yhs@fb.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        KP Singh <kpsingh@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "Martin KaFai Lau" <kafai@fb.com>
Subject: RE: [Intel-wired-lan] [PATCH v4 net-next 5/9] ice: respect metadata
 on XSK Rx to skb
Thread-Topic: [Intel-wired-lan] [PATCH v4 net-next 5/9] ice: respect metadata
 on XSK Rx to skb
Thread-Index: AQHX7D0b2J0zbA5oYk25b00TVMSFGaxcVB8g
Date:   Mon, 10 Jan 2022 11:37:21 +0000
Message-ID: <DM6PR11MB3292226E5E815F1F335437F8F1509@DM6PR11MB3292.namprd11.prod.outlook.com>
References: <20211208140702.642741-1-alexandr.lobakin@intel.com>
 <20211208140702.642741-6-alexandr.lobakin@intel.com>
In-Reply-To: <20211208140702.642741-6-alexandr.lobakin@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?n0HBeTU2NpWfLtATkCOT6Eodpm7tHCbB/8dxVlnOD/2P7yTijT5tFwTK3L?=
 =?iso-8859-1?Q?hEWMd3cfP1bwBwPEBz5oL8tkq7DiDfp/97dhGAdVdWGNlbdypSwfu8nSPB?=
 =?iso-8859-1?Q?L+xmWPG5Nx78igf68IDZX2HAIw+xX/SQc5zS2m8HPOrxi9q0RpBUD04PZG?=
 =?iso-8859-1?Q?s9Q2a5K/Zv2QS+gifQTj/rhGdNHqplMGmiGB9w0yDKaOU6PvNgzB/M+v1A?=
 =?iso-8859-1?Q?O0rKEKey6itCijxS3F894VLe515mqDIAN5z38R0EumqfgVSRw/h4ia/Gfn?=
 =?iso-8859-1?Q?XbsvS7GHf7enQQeI6BoxrYRXf55QY5kPU99+ZdyfAzDysF0BSY6p1ob1If?=
 =?iso-8859-1?Q?z/HST713x6d1qY0kr9h0mGijsCsTOxBI4vuB7ktkxBVCa7uH43VYKE8khB?=
 =?iso-8859-1?Q?B2HPbYlC2DCpb8MG0iDbRglmLf9dJNWMISmwa2KhSuyLxscX9d+muD8uDe?=
 =?iso-8859-1?Q?yGS3wTzWOtp+RkaUPoh2/Hp01dGqifxifsiLc1NqHqPdenjC4ZzQDPaBNU?=
 =?iso-8859-1?Q?0lf9l0/yt8sUXDLLBNOoZ4KLL4yZoDQV5R1QKADwYjRy4E5bZHJxBa7dud?=
 =?iso-8859-1?Q?BP474ieGtmMBO8uY+jCzF4gNxsSUa+//DmE4fMNd9uo/cHanjtqydtIN3X?=
 =?iso-8859-1?Q?uP8g/XSSK31don7PtORea666RxZ49FrxmwJccOPVyFU9oMI1IRv9BuTLXS?=
 =?iso-8859-1?Q?0x2FKz/wvSyE+BlR7dnL4IVuiPr3kqAohuX3VDb/eh2bIsf8AWhrZQkOg0?=
 =?iso-8859-1?Q?fW4gffJcmGTXTKv5m5dPq799ulQKHJY9S17werpygDdfcSE/AmtW99u00O?=
 =?iso-8859-1?Q?0SHEftnm1NxwzNGoK/ekW1s1JMgzaMGBpeIkVB+vjQx9WJCp9PRWCdKccI?=
 =?iso-8859-1?Q?0/PmWAA0ChY7jrevuyWTwdY7nRGBo3zw5PthhhexFfZy93DQnFrldgcRTo?=
 =?iso-8859-1?Q?XaWwcycnlhnVWH59ZbJsdGC0uiXvWFDg+3QImgKpyqyHZi/Rl+6xvwzQml?=
 =?iso-8859-1?Q?vgSZ3EbIoauhrGHm6u81Z1QJsm9qcbSGHZQzDrCOjNPoNq08Cde4PImLDS?=
 =?iso-8859-1?Q?tUttyyU9IM/oXdC9j4eUpPAPf6WoSxEjVveD0LLAx/z1kUyf1jJuLy36I6?=
 =?iso-8859-1?Q?ci9UMK3RX24aTcm3LB704Og9NQxG+Lyp0FkI/D8okS9anu+SmClqcuXCQS?=
 =?iso-8859-1?Q?NOQ85tm6IYaHVGV+A51PZfQPxtt3zaGr1u4GNTUI5TL/hS/NeOCGrhr6Zx?=
 =?iso-8859-1?Q?AnrQ44fNYvZrgu3HN8HXeqByawWlxZC7vqiBFZjh/AHD56HakAKHg84Kvw?=
 =?iso-8859-1?Q?nUuBzKqHfylrDzCnYfs5X/8kWLzEpzkAKAca9B/GD6rIDIH7kJZeWCmEqS?=
 =?iso-8859-1?Q?Rf/de/ijL64fG3DnOS60Cqfahsqvlo/OT2yaxUcoWVpyzRDRh5Zg5r4/Cl?=
 =?iso-8859-1?Q?WgrSfgPLVo2UIREQdvTbCuHLV+z+aEN6PGxe3NCHOXZh55F8cyRsl+3oln?=
 =?iso-8859-1?Q?0ChtfZw1xZmPDUKOABDjwDBJKVMBdWbD4Z53btE85aTkwCiEw1XGb4bX3s?=
 =?iso-8859-1?Q?/GQoVoqnq0wsREKuCfrBj1QPtDTsXg1u2noZ/DS7vnk3LuV2NcKhYspjS8?=
 =?iso-8859-1?Q?+ZnnwHQgCH4/2cP8Ul/wGWvvXQLEuggN/cCTZ9thMwWmwvb0vudgTrIPRG?=
 =?iso-8859-1?Q?wQoRkePGFNTxXuVbowk7ZJH2+s29unSK/I9hajG62ovzQ5tIauHwfsJRvF?=
 =?iso-8859-1?Q?9V4g=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3292.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0af93922-5d8a-4173-44d5-08d9d42d90bb
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2022 11:37:21.2694
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HG6Qph+mEOkif0oR1xLqCf3Jv4pUTfnbW/roWZ+OS/TvMBoE//eUvmPl9qJFUgNzcPMB8mBkaAk5KhIfH2QrTB37gDfWpKatPl5QqI0f7TY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4756
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Alexander Lobakin
> Sent: Wednesday, December 8, 2021 7:37 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Song Liu <songliubraving@fb.com>; Alexei Starovoitov <ast@kernel.org>=
;
> Andrii Nakryiko <andrii@kernel.org>; Daniel Borkmann
> <daniel@iogearbox.net>; John Fastabend <john.fastabend@gmail.com>;
> Jesper Dangaard Brouer <brouer@redhat.com>; Yonghong Song
> <yhs@fb.com>; Jesper Dangaard Brouer <hawk@kernel.org>; KP Singh
> <kpsingh@kernel.org>; Jakub Kicinski <kuba@kernel.org>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; David S. Miller
> <davem@davemloft.net>; Bj=F6rn T=F6pel <bjorn@kernel.org>;
> bpf@vger.kernel.org; Martin KaFai Lau <kafai@fb.com>
> Subject: [Intel-wired-lan] [PATCH v4 net-next 5/9] ice: respect metadata =
on
> XSK Rx to skb
>=20
> For now, if the XDP prog returns XDP_PASS on XSK, the metadata will be lo=
st
> as it doesn't get copied to the skb.
> Copy it along with the frame headers. Account its size on skb allocation,=
 and
> when copying just treat it as a part of the frame and do a pull after to =
"move"
> it to the "reserved" zone.
> net_prefetch() xdp->data_meta and align the copy size to speed-up
> memcpy() a little and better match ice_costruct_skb().
>=20
> Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
> Suggested-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Suggested-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_xsk.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
>=20

Tested-by: Kiran Bhandare <kiranx.bhandare@intel.com>  A Contingent Worker =
at Intel