Message-ID: <3f89059b-13cd-d632-1ef0-489e698d7b12@suse.com>
Date:   Mon, 10 Jan 2022 12:39:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH 1/3 v3] net: usb: r8152: Check used MAC passthrough
 address
Content-Language: en-US
To:     Aaron Ma <aaron.ma@canonical.com>, kuba@kernel.org,
        henning.schild@siemens.com, linux-usb@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
CC:     davem@davemloft.net, hayeswang@realtek.com, tiwai@suse.de
References: <20220105151427.8373-1-aaron.ma@canonical.com>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20220105151427.8373-1-aaron.ma@canonical.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HYYpBLVFz2yPghxpVT62GuU74H2yPW4m5anHURt0aO88dWpJ6dtka26ECT9A?=
 =?us-ascii?Q?qKCJE1tElOderrU++z/Lv8pwkIGx0Ma1YYYQNKp3MeFOf9GQX75EDSraXeSQ?=
 =?us-ascii?Q?RJhIq8kmvJyojNJCLFCO+uz6fzv/vu8Cc7yKWlwVKwZ2z5wQVeOr7tyj2qUo?=
 =?us-ascii?Q?dYqERcLXRr0X4+iZfb7SbsxlLNh8NPic0RSWv7LWkutqDFP5jeAYOsXcfZ7u?=
 =?us-ascii?Q?7PZFvFqktr8/F70trMlcRrrvm3GupWQJyBiY8gDYHXz0KshwG5eiPOf/0Vur?=
 =?us-ascii?Q?q91KTTdQCiaH9z+iQZSVzYRFToDmytVcpRDdox5hEnF/zx4cfBXaTNV1BB9I?=
 =?us-ascii?Q?ssOwbcOOUL+mg/yzZreIv9he+Y05KC55eXx7whyhGcS9POJbFS6iMIQyGHEO?=
 =?us-ascii?Q?T5Z8zTkDmqwLfgYZy2huI+eJbsbMX2ZAJQQPhMiPqnJ9JyTYa7DCrAoaw7rM?=
 =?us-ascii?Q?cjraIrsk6FoQnKvCulDYa8ug9Hjk6svuPT66KuO5c4S2mQs4mVXt+zk0SN2O?=
 =?us-ascii?Q?gFRJ4ZZC94BnxUBtRE5XHhUtfbLXhJ2ayNHYd5Ni26RU7XrxcUFWbTxDRu4R?=
 =?us-ascii?Q?D/tIHMql/jrcnTazXyvoQ21lkWQN8utKQeqLdjQEPAkDIZlVyPIBYK89fdFc?=
 =?us-ascii?Q?/ipCyA9xdZacZ8SUN5fVx+x2nGSNtmYH4O0SOFGLM0pC6FsEnpHwkalcYiQj?=
 =?us-ascii?Q?AvRpgHxMRREsObXWPSUmJTLjazvwgAQPvmFw9bWynY9fRBEjYS38K1MSe1Ik?=
 =?us-ascii?Q?QMXiQ87Eto+CAqZhdyZ8ZMvIWXnvyxOuzsTjWRepyaIq9+6m/3L059e7lPou?=
 =?us-ascii?Q?wMPLoSPGc9vNrXg2wMx425n5jJGhYkCSAbuCqlR3b5RwsF+W/rHjuOPBAD8O?=
 =?us-ascii?Q?pW91I+IrC8UB/oC2EVhBQatZn4MiBvPEbgyx7dej9qjBclgahisBl2BCfWTO?=
 =?us-ascii?Q?zaIVluCJIHHMAr1P6WaAc7OOyCUlQNIQfbyOVNEB61W5j+EvHWADPa52ZIJf?=
 =?us-ascii?Q?aHjymeitk8NQeN8v06QEArD4sI2aHZKrd0K/aleswAJ+s3x1ZkbNFTuj7l9o?=
 =?us-ascii?Q?t3goPc2Tl7yMolCxY/XIRrCNncYJiA8pWFv2WlO3SsXewqCGcCe1BOzNto3O?=
 =?us-ascii?Q?6ytZOCLzm/hcV7qBibHaCNRo/uejAXiRyw6lPXxQJKSz74K2e2uJZ/hadmLE?=
 =?us-ascii?Q?5h71gw03tqq+8fVPyhjkGCWnWjZf9i544ZVWgGvrcAsl9cKK+MEr5bGbpGNo?=
 =?us-ascii?Q?Zs64TddhQUg+Fny4UkW+9pmqRCLumyuPMT/r/R8DBZnXxsYUaMNul+Ob0q0l?=
 =?us-ascii?Q?57GSjL8cfUn3NZmQT2FnqX8nQ2k+yX5MPSIrP6sp4u9FdVy3whz1bWo2SO9C?=
 =?us-ascii?Q?SUZQHD+yq6wSVo7GigdJ3I5ABtgdCZxz7XiSzRXOY0jXadtRJ/55aIth0rXI?=
 =?us-ascii?Q?3oMB2xRfXOFKufGVT4P+2BZ4VH3hXRMQqgC/HbwBE9YBni50miqdMoP+70UG?=
 =?us-ascii?Q?+9mwni1NMJNl+txhNL0kR8eS0uU5CuQ7rNcdbW77R7nsaSf8S66EFifE7hKh?=
 =?us-ascii?Q?pktadJmAjsXabY+hYnyWBTMHpOETEvp/TueoJs2Dz03p5wfjplt+Oxs1+x4q?=
 =?us-ascii?Q?Gi4vlcFjaI6Z3iE9N9zrttI5ohZckafJJPDM8WEBkzaeLli5RzsS8eemlhHh?=
 =?us-ascii?Q?KWKRt7Cg7nFxWLj5sgVUXgeUwVE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2524d520-9fff-43de-9bcd-08d9d42ddbd4
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5050.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2022 11:39:27.9521
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b9KA1WfFNjre9VDnIoD26p3o9zXcLkvpiFs6vF7rFex6CvsdoKs725+zg8hWtPg286qYyA6JI63NMWVqrhAepQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3238
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 05.01.22 16:14, Aaron Ma wrote:
> When plugin multiple r8152 ethernet dongles to Lenovo Docks
> or USB hub, MAC passthrough address from BIOS should be
> checked if it had been used to avoid using on other dongles.
>
> Currently builtin r8152 on Dock still can't be identified.
> First detected r8152 will use the MAC passthrough address.
>
> v2:
> Skip builtin PCI MAC address which is share MAC address with
> passthrough MAC.
> Check thunderbolt based ethernet.
I am sorry and I may be dense, why are you comparing
MACs? The pass-through is done per machine. All you
nee is a global flag, or if you want to be even more
formal, a reference count.

=C2=A0=C2=A0=C2=A0 Regards
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 Oliver