MIME-Version: 1.0
References: <20220110111036.1380288-1-sergio.paracuellos@gmail.com>
 <20220110111036.1380288-4-sergio.paracuellos@gmail.com> <c88e81067826f04e2301b52eddb84ec84bbd1c9d.camel@pengutronix.de>
In-Reply-To: <c88e81067826f04e2301b52eddb84ec84bbd1c9d.camel@pengutronix.de>
From:   Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date:   Mon, 10 Jan 2022 12:41:28 +0100
Message-ID: <CAMhs-H9q=hP2GMU5QEU5791HfcCchrek6m9L4UdKzMyLg4nZBw@mail.gmail.com>
Subject: Re: [PATCH v7 3/4] clk: ralink: make system controller node a reset provider
To:     Philipp Zabel <p.zabel@pengutronix.de>
Cc:     "open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
        John Crispin <john@phrozen.org>, linux-staging@lists.linux.dev,
        Greg KH <gregkh@linuxfoundation.org>,
        NeilBrown <neil@brown.name>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Stephen Boyd <sboyd@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jan 10, 2022 at 12:37 PM Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> On Mon, 2022-01-10 at 12:10 +0100, Sergio Paracuellos wrote:
> [...]
> > +static int mt7621_rst_xlate(struct reset_controller_dev *rcdev,
> > +                         const struct of_phandle_args *reset_spec)
> > +{
> > +     unsigned long id = reset_spec->args[0];
> > +
> > +     if (id == MT7621_RST_SYS)
>
>         if (id == MT7621_RST_SYS || id >= rcdev->nr_resets)
>
> I forgot to mention that with .of_xlate set, the driver needs to check
> whether id < nr_resets on its own.

Oh, ok. I checked 'drivers/reset/reset-k210.c' as example and there
was only a similar check that I sent. Let me add this also and send
v8.

Best regards,
    Sergio Paracuellos
>
> regards
> Philipp