From:   Christophe Leroy <christophe.leroy@csgroup.eu>
To:     Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>
CC:     Christophe Leroy <christophe.leroy@csgroup.eu>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "Naveen N . Rao" <naveen.n.rao@linux.ibm.com>
Subject: [PATCH] powerpc/bpf: Always reallocate BPF_REG_5, BPF_REG_AX and
 TMP_REG when possible
Thread-Topic: [PATCH] powerpc/bpf: Always reallocate BPF_REG_5, BPF_REG_AX and
 TMP_REG when possible
Thread-Index: AQHYBh2+PoHCxCSIk0C7aiUG8hGF4Q==
Date:   Mon, 10 Jan 2022 12:29:42 +0000
Message-ID: <b04c246874b716911139c04bc004b3b14eed07ef.1641817763.git.christophe.leroy@csgroup.eu>
Accept-Language: fr-FR, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?FbnoQd3avsHkdBPAvpYzw2OzHn0A7KojETnsuF9HdWBAFi/4NkDESwv0OU?=
 =?iso-8859-1?Q?N9C5n4+ZECx2HWbPYnGnkJIDygtbMc4HODeBPTYCBiaXBI0KiiZw4lZhQ0?=
 =?iso-8859-1?Q?nMkh+oG3+nrPV9DJLupaiNcPOQX9DczJ2A2fFNo2pEWkb2E1kqkT+A4v01?=
 =?iso-8859-1?Q?ICtLfTlnJZ21XLh/Ef0kA0/doXmx5qPab6TmhscfjSm3ylv542Un7iYNM4?=
 =?iso-8859-1?Q?jU0Q8KQ+o4P+0D3u9h6dhtQ5V2vgEDQl7XxvhkD66mni+RrXux2Pi8e8Oe?=
 =?iso-8859-1?Q?wWyv1DUA7i2RW1w56E//jnRkkug8B+V++Q0qqkL0hheSAqWYeSdb21Mj2e?=
 =?iso-8859-1?Q?0jD/O09xuVvRDL4VFv2jFrkZT1v/KKxFMAlnfklhJaH+2AmhU2LSPlGSLy?=
 =?iso-8859-1?Q?cNBnyoaBnk+D3P2/sRkSLZWd8L3ZmeSEf9vnV06tpkYhRTVStxPBMUtqsF?=
 =?iso-8859-1?Q?meuvHnP7DoeeB9swSoz00koDb8QMFillGm6ooLgaRtYfP5xnbVt9g8MezJ?=
 =?iso-8859-1?Q?BXAyzfUDIrwVD2g8UFy1fB9/OwFBaFW1TkiatPrg5n4CuqnsebxIfozIR8?=
 =?iso-8859-1?Q?WodqscPVH1EJhwsMRFdfHH23nRKXCarN7diPssubhzpBzr14Tnr582SoOf?=
 =?iso-8859-1?Q?3HK57Vo19rSi7AgLy8ATG4gt7lZpxPoqhiWrbX7IbE1BgZS30fTS182YLk?=
 =?iso-8859-1?Q?N5AJ4IZdECdNeTo2xwQ0UD1N1GNettgmVa55YsyxcYgFNTuNt2wyhXwFGh?=
 =?iso-8859-1?Q?dNu2lBv4kGn8I3lRyPHHmyDe9Ns5UoTiw75OatN9bOaDnA/DopP3JY9aUE?=
 =?iso-8859-1?Q?ZbKfFie9yeg6QLE6TV5JGYzs3GlI0NIJeJkQgDFuUkV6xSZl5n1KkZUKyg?=
 =?iso-8859-1?Q?c5v918U+fPgyja0QcfBD6HVihd9Ff6AGCGMQ75jHt90iWBJneCgad/+RBS?=
 =?iso-8859-1?Q?/jtCpm//saoLZIXsA8Ek4Y4nOKsL7x3A7KP79BaoNx2ISAtkBgXcvYohmx?=
 =?iso-8859-1?Q?CPRsuITM9JTWIn5ySzJKEm0QCh0UZqDOPpbr36UXngqfpPJGav2yDXPlw9?=
 =?iso-8859-1?Q?5c1HDZtlWpGHKN1QAmbTzR/oAVccq14z962gdIgX4N5qfAaO3x6lzd3vzK?=
 =?iso-8859-1?Q?XWCfvSXuAxm6In1aKT1E10luaIxLB7PQTO3KjZ/g19CCvCiGCKyGnb97mk?=
 =?iso-8859-1?Q?csb1P3Kz/Zk62Zg5bHJQg4HtfZlZKM5AwtyWLCrEuhUrVAq8EdKfjMyxpQ?=
 =?iso-8859-1?Q?O9d8etp6mwkeHZyaS9GoMxg2PEXfeS2SbMvSJeLaRShp+Xj5O/uGyRBVhL?=
 =?iso-8859-1?Q?ZQzWGBVUou7btwFTzflhLu0qKxO7X3jEvFVo2sdIrQwLDBQft+Gz3tU9re?=
 =?iso-8859-1?Q?hRPTIhCV3N09uLq/ZAhraxYSWH/M16VKY0iueaor/1MD59tn94XK+urq64?=
 =?iso-8859-1?Q?xa4fi3eDqPt43bPyffX8BlFBPQ/P/PpVk51pxxFuqBYMVRdMonFaS/Rey5?=
 =?iso-8859-1?Q?UAccAmZeoZWbNzUqAux9PqsG1v2E0dd/jiEtj6+DCzjN8w8P9Oqd9IyeEu?=
 =?iso-8859-1?Q?JAHB2Z7DUs4IL8Ums4KFRSbyQXSgbRnDyM/BB3Chx2Ru2hL5TjLOc9mbQb?=
 =?iso-8859-1?Q?QCLIn1a7C+HgdNCc1ABYACRRBnmSaYvEozSaEWqnIeJAjT+W1bt6kyWLpN?=
 =?iso-8859-1?Q?ClLooGKP9hLUjgRv8XyAkQRwdQ0aOt4qfeq3XftBMvB8gUVqo0rt1OlZJU?=
 =?iso-8859-1?Q?tJKRANCsoofLYts2zsRuaK1d4=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-OriginatorOrg: csgroup.eu
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MRZP264MB2988.FRAP264.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: ea293112-d8d9-476a-5d3d-08d9d434e0d5
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2022 12:29:42.4165
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 9914def7-b676-4fda-8815-5d49fb3b45c8
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: le+zUe7fjsdW6zZGR6FoDYk8rhD0b9K5TfPAEdVWG2gmM2qL+UYHUJo4vxijsSW8wCOozMIK+Z+ZhRassC1Gr8UQT7q228RFEDH/jxKnJWk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MRXP264MB0552
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

BPF_REG_5, BPF_REG_AX and TMP_REG are mapped on non volatile registers
because there are not enough volatile registers, but they don't need
to be preserved on function calls.

So when some volatile registers become available, those registers can
always be reallocated regardless of whether SEEN_FUNC is set or not.

Suggested-by: Naveen N. Rao <naveen.n.rao@linux.ibm.com>
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
 arch/powerpc/net/bpf_jit.h        |  3 ---
 arch/powerpc/net/bpf_jit_comp32.c | 14 +++++++++++---
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/arch/powerpc/net/bpf_jit.h b/arch/powerpc/net/bpf_jit.h
index b20a2a83a6e7..b75507fc8f6b 100644
--- a/arch/powerpc/net/bpf_jit.h
+++ b/arch/powerpc/net/bpf_jit.h
@@ -127,9 +127,6 @@
 #define SEEN_FUNC	0x20000000 /* might call external helpers */
 #define SEEN_TAILCALL	0x40000000 /* uses tail calls */
 
-#define SEEN_VREG_MASK	0x1ff80000 /* Volatile registers r3-r12 */
-#define SEEN_NVREG_MASK	0x0003ffff /* Non volatile registers r14-r31 */
-
 #ifdef CONFIG_PPC64
 extern const int b2p[MAX_BPF_JIT_REG + 2];
 #else
diff --git a/arch/powerpc/net/bpf_jit_comp32.c b/arch/powerpc/net/bpf_jit_comp32.c
index d3a52cd42f53..cfec42c8a511 100644
--- a/arch/powerpc/net/bpf_jit_comp32.c
+++ b/arch/powerpc/net/bpf_jit_comp32.c
@@ -77,14 +77,22 @@ static int bpf_jit_stack_offsetof(struct codegen_context *ctx, int reg)
 	return BPF_PPC_STACKFRAME(ctx) - 4;
 }
 
+#define SEEN_VREG_MASK		0x1ff80000 /* Volatile registers r3-r12 */
+#define SEEN_NVREG_FULL_MASK	0x0003ffff /* Non volatile registers r14-r31 */
+#define SEEN_NVREG_TEMP_MASK	0x00001e01 /* BPF_REG_5, BPF_REG_AX, TMP_REG */
+
 void bpf_jit_realloc_regs(struct codegen_context *ctx)
 {
+	unsigned int nvreg_mask;
+
 	if (ctx->seen & SEEN_FUNC)
-		return;
+		nvreg_mask = SEEN_NVREG_TEMP_MASK;
+	else
+		nvreg_mask = SEEN_NVREG_FULL_MASK;
 
-	while (ctx->seen & SEEN_NVREG_MASK &&
+	while (ctx->seen & nvreg_mask &&
 	      (ctx->seen & SEEN_VREG_MASK) != SEEN_VREG_MASK) {
-		int old = 32 - fls(ctx->seen & (SEEN_NVREG_MASK & 0xaaaaaaab));
+		int old = 32 - fls(ctx->seen & (nvreg_mask & 0xaaaaaaab));
 		int new = 32 - fls(~ctx->seen & (SEEN_VREG_MASK & 0xaaaaaaaa));
 		int i;
 
-- 
2.33.1