Message-ID: <97e5c59a-ac8e-ffee-b5d5-55883932b8df@suse.de>
Date:   Mon, 10 Jan 2022 23:53:10 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: Re: [PATCH] bcache: use default_groups in kobj_type
Content-Language: en-US
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Kent Overstreet <kent.overstreet@gmail.com>,
        linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220106100004.3277439-1-gregkh@linuxfoundation.org>
 <7cbca83d-bcac-464e-d2e4-c54b2d53eead@suse.de> <YdlL4YAScYp9XxkI@kroah.com>
From:   Coly Li <colyli@suse.de>
In-Reply-To: <YdlL4YAScYp9XxkI@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/8/22 4:31 PM, Greg Kroah-Hartman wrote:
> On Sat, Jan 08, 2022 at 02:16:28PM +0800, Coly Li wrote:
>> On 1/6/22 6:00 PM, Greg Kroah-Hartman wrote:
>>> There are currently 2 ways to create a set of sysfs files for a
>>> kobj_type, through the default_attrs field, and the default_groups
>>> field.  Move the bcache sysfs code to use default_groups field which has
>>> been the preferred way since aa30f47cf666 ("kobject: Add support for
>>> default attribute groups to kobj_type") so that we can soon get rid of
>>> the obsolete default_attrs field.
>>>
>>> Cc: Coly Li <colyli@suse.de>
>>> Cc: Kent Overstreet <kent.overstreet@gmail.com>
>>> Cc: linux-bcache@vger.kernel.org
>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> It looks good to me.
>>
>> Acked-by: Coly Li <colyli@suse.de>
>>
>> I assume you may take this patch directly in your maintenance path, but if
>> you want me to take this, just let me know. Thanks.
> I can take it myself, or you can, which ever is easiest for you, just
> let me know which you prefer.  Thanks for the review!

It will be faster for this patch goes into mainline in your path, I am 
on vacation now and will have a latency...

Thank you.

Coly Li