MIME-Version: 1.0
References: <20211226082530.2245198-1-nikita.yoush@cogentembedded.com> <20211226082530.2245198-2-nikita.yoush@cogentembedded.com>
In-Reply-To: <20211226082530.2245198-2-nikita.yoush@cogentembedded.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 10 Jan 2022 16:58:23 +0100
Message-ID: <CAMuHMdV+Yb1As-2fjq+1eeUEiTo21OH+aUQwEcSCAEErDh2A7w@mail.gmail.com>
Subject: Re: [PATCH 1/3] staging: most: dim2: update renesas compatible string
To:     Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc:     Magnus Damm <magnus.damm@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Christian Gromm <christian.gromm@microchip.com>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, linux-staging@lists.linux.dev,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Nikita,

On Sun, Dec 26, 2021 at 9:25 AM Nikita Yushchenko
<nikita.yoush@cogentembedded.com> wrote:
> Use "renesas,rcar-gen3-mlp" instead of "rcar,medialb-dim2"
> - the documented vendor prefix for Renesas is "renesas,"
> - existing r-car devices use "rcar-genN-XXX" pattern.
>
> There are currently no in-tree users to update.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>

Thanks for your patch!

> --- a/drivers/staging/most/dim2/dim2.c
> +++ b/drivers/staging/most/dim2/dim2.c
> @@ -1086,7 +1086,7 @@ static const struct of_device_id dim2_of_match[] = {
>                 .data = plat_data + RCAR_H2
>         },
>         {
> -               .compatible = "rcar,medialb-dim2",
> +               .compatible = "renesas,rcar-gen3-mlp",
>                 .data = plat_data + RCAR_M3
>         },

Looks sane, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

But there is no DT binding documentation covering this block :-(

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds