To:     Eric Wheeler <bcache@lists.ewheeler.net>
Cc:     Kent Overstreet <kent.overstreet@gmail.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Coly Li <colyli@suse.de>, linux-block@vger.kernel.org,
        Jonathan Corbet <corbet@lwn.net>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:BCACHE (BLOCK LAYER CACHE)" <linux-bcache@vger.kernel.org>
Subject: Re: [PATCH] bcache: make stripe_size configurable and persistent
 for hardware raid5/6
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1fspvshbw.fsf@ca-mkp.ca.oracle.com>
References: <d3f7fd44-9287-c7fa-ee95-c3b8a4d56c93@suse.de>
        <1561245371-10235-1-git-send-email-bcache@lists.ewheeler.net>
        <200638b0-7cba-38b4-20c4-b325f3cfe862@suse.de>
        <alpine.LRH.2.11.1906241800350.1114@mx.ewheeler.net>
        <8a9131dc-9bf7-a24a-f7b8-35e0c019e905@suse.de>
        <fdb85dc1-eee6-e55e-8e9c-fa1f36b4a37@ewheeler.net>
        <yq15yqvw1f0.fsf@ca-mkp.ca.oracle.com>
        <c9abd220-6b7f-9299-48a1-a16d64981734@ewheeler.net>
        <98aa1886-859-abb9-164f-c9eb9be38a91@ewheeler.net>
Date:   Mon, 10 Jan 2022 11:14:29 -0500
In-Reply-To: <98aa1886-859-abb9-164f-c9eb9be38a91@ewheeler.net> (Eric
        Wheeler's message of "Sat, 8 Jan 2022 13:51:22 -0800 (PST)")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VyTD7W5sMHy98EhqSxv4e8jnEAYYqqIe+MTVUEx+VpzsxixaJtpavoGl1MUB?=
 =?us-ascii?Q?xED/Ggref6qfJ5td/3OHwTkaa1LLMMu6ctEfLvfFZ3kQGaVgWa3ZcgeD9hSk?=
 =?us-ascii?Q?gVlwdh8ne640GMpXlwkDmt0SHm0KZ6BDh4prLkYnNdaW9Xj3vrHMs9HmPOW8?=
 =?us-ascii?Q?JfttyuWf3rpseT0/UCG8JoqJOuf5TXhjFYD+P2IbmyID0qrNQTw/hQ0Rw8BG?=
 =?us-ascii?Q?41V5hkt13BJ0qSOPvxLbJwA5QkHl9gfmTragiFf5NbouxeWn9V4sJJhffymM?=
 =?us-ascii?Q?tIvb3ZEbkRT13n8GF9BeIwBMGPqCvJI5CejbTSenuL30gv+Cx7fyNooOxh77?=
 =?us-ascii?Q?I73O4OMPQch77khMZ0l3EYWtXSkvHSIcME/U6V/VMqvWjE0kBTdJ9IVi4SI1?=
 =?us-ascii?Q?jST8cx2EDfAvbb0YyP6n0xxgv0WfP6jZrH/0NNewZ2RdLO35VVxZlehCrabw?=
 =?us-ascii?Q?CBS6pF2mzSqtYvZvWaMgMkdjPSfslvO8cjr0hCv8wesbnIfi5djM8LjICOiV?=
 =?us-ascii?Q?SYGsYaAOfQn4w0XcLBAzZC3gKPsooxos/MU5ZlpDQ9ldIUEb0WNt8xtAgqmp?=
 =?us-ascii?Q?erFgF08FF+MybT73zgI10zKQv1l2/DiBcQ75bnfK9MovKT9eoXWxLKEBuBgp?=
 =?us-ascii?Q?KrhZ5Ikf2j5m1dbPQeJp0XMbs+LIgXjaLsHuT/wFDQ1O59jVHN3WFnywCa3u?=
 =?us-ascii?Q?+tnnfnjdOKyFNQpevnmPd3wU3R5+nbkM4tToQ5d+NxUjAQ3arL6xyAmbHUjv?=
 =?us-ascii?Q?koMA36p0adzbj//hPw2vnkcW3EffKkUuyKQhBvGeQSfzdXdgGJ5exZUwQ2Rj?=
 =?us-ascii?Q?nNPOvqSlut96MPJI7CmPyCNP/ltm5B/GEP5JJ/lncPQ7CwfoYazCzon8IpHd?=
 =?us-ascii?Q?0noC3j5DNaBtjTv9jzBFFY4LOzS6r/cjzcge3TIxje7FtDZ4dzVF2c6MP1KX?=
 =?us-ascii?Q?VGAlakn72pxlsRXMW3CCkf8CjuUSPccVUE7ENFGSVloZCbElhY8rC+zPklG5?=
 =?us-ascii?Q?O/1Uck2XkCRw7phSkz/XdZhgE03Yw9tMsVY9lCl8VTGZpBlrg96XtObShWp6?=
 =?us-ascii?Q?QX6qvIE03aLp/CCgRW26hxHCjaO78pHprh8kzz+Xm3cluKjloW4ARl/otjhU?=
 =?us-ascii?Q?8jP4YNyI5mpCVrvVn/7+88CSLx9Iq3ArLr5kTLumF1HVgIJm/0DNhhvBY9hw?=
 =?us-ascii?Q?m5ED68kq0lgpoGIqYRIWug0E2GwNUue2zaYfmuljKm4/yPxsfvTutTisnMmt?=
 =?us-ascii?Q?FOPGpekLukW1RGAb5gddk1/6wxP5ujFhfGVbHyhYo7G0Re6veHgvh0m2/UEd?=
 =?us-ascii?Q?qo3u4dPHR+JADlbDjM5eaeshKVgFCW/pOclyBjzh8oc3hg71oq63x34oGXsj?=
 =?us-ascii?Q?rhBdUf4GruOWD+CBB+17jmaP63+ut5+Sdesz75j4b3j2pAXHx7A/ZcDAEkZG?=
 =?us-ascii?Q?PXFEr5bJdwQCzWYoJ7iiHtlsez2iseZgpHMTDkuE6Bb9CO5ROXiVgGbSZcNx?=
 =?us-ascii?Q?RY6hBlpNmnrmqnStH35QDidfYl/P57aku5SUppmOSZTlio+sRcMdVuD+mdRN?=
 =?us-ascii?Q?kmMJJM7m+Z52mM7xZRepU8+z7vApATo9sU4EbTlISeq8MG8GWNpcKinFCZqT?=
 =?us-ascii?Q?oqG9gngZurfsZMTpw5lnoTF1QfrxY3o5b3jLjbVh3qv5Tn7NDeCp/zgwmxxQ?=
 =?us-ascii?Q?prBd7kAmxF0UF3Q2ZgVwnEUWTmQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e61efba-0054-4203-198f-08d9d454487b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2022 16:14:30.9098
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /jsJaZs/6bLGFKTR2IZ1vg70qLoxXKr+dMuCuWgFR4Ju+vdvtddmK644Gbb94cL+lUXNZ6EPTeaC2Zya1ygh9lWr+t3NiH56MnpfYytHKyM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4455
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10223 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 adultscore=0
 suspectscore=0 mlxlogscore=823 bulkscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201100113
X-Proofpoint-GUID: pq0ERfFr93DWdD4JG4ExAfVdH4Pf_2Zm
X-Proofpoint-ORIG-GUID: pq0ERfFr93DWdD4JG4ExAfVdH4Pf_2Zm
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Eric,

> Ok so `git blame` shows that Kent added this to md/raid5.c in 
> c78afc6261b (Kent Overstreet 2013-07-11 22:39:53 -0700 7526)

Yep.

> Do you think we should leave the md-specific
> raid_partial_stripes_expensive setting and require users of RAID
> controllers to set the bit themselves in bcache---or---remove all
> raid_partial_stripes_expensive code and always treat writes as
> "expensive" when `opt_io` is defined?

I'd prefer the latter since that was the very intent of exporting the
device topology in an abstract and protocol-independent fashion.
However, I don't know enough about bcache internals to know whether it
is always the right choice, what the trade-offs are, etc.

-- 
Martin K. Petersen	Oracle Linux Engineering