Message-ID: <25f49c99-3feb-dfdc-1077-2f3552ce2ef1@intel.com>
Date:   Mon, 10 Jan 2022 17:31:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.3.0
Subject: Re: [PATCH] drivers/soundwire: remove redundant val variable
Content-Language: en-US
To:     <cgel.zte@gmail.com>, <agross@kernel.org>
CC:     <bjorn.andersson@linaro.org>, <vkoul@kernel.org>,
        <yung-chuan.liao@linux.intel.com>,
        <pierre-louis.bossart@linux.intel.com>, <sanyog.r.kale@intel.com>,
        <linux-arm-msm@vger.kernel.org>, <alsa-devel@alsa-project.org>,
        <linux-kernel@vger.kernel.org>,
        Minghao Chi <chi.minghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
References: <20220110104749.646995-1-chi.minghao@zte.com.cn>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <20220110104749.646995-1-chi.minghao@zte.com.cn>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LytRZDJDVnYwaFFHYzJNM0s4TTFhcThESE9rRzloU0tzWE41YkNvTDZGWFZU?=
 =?utf-8?B?QWVabGtRY2lEankwcDh3NlRKaVFtTlE5QlpTN25nbVpadjBacGJ5SHlzNTVw?=
 =?utf-8?B?Unk5dDRzOGtiMFhwNW5ua1ByMFVuUTF1S0Y5V3lEOVJWMzhxMzVxWkloZVRi?=
 =?utf-8?B?SEFUNG9HR2t6YXlPb1B3UjhNbi9SeitlbE9ybStNVXJRUm5FWlBuRVdjNGRm?=
 =?utf-8?B?QWwyZDlwbjF5OWVoR0kvejVkdGQrWFQweUxHdXQ3RTJVM1prNThlYWFNcVdR?=
 =?utf-8?B?MzcyckdoRlppa0lyQ1ZDZnhNbG5xY3VqTkpnejJkWndlVHZsTTJzWVdXb0VX?=
 =?utf-8?B?MWhRRG16ODdiM0dSRldRY0t2WXhhT3h3VTlyTnVMc0FpdHJBS2ZvZjZ1L1Rq?=
 =?utf-8?B?aUgxZ0N1MlpxWnlEdndvMDNQR3FXK2xJZ1BiTE01aXlHQlV5b1l6eW1iQkcw?=
 =?utf-8?B?SVN4Vi9WQUJaazFRdHZZeFE1K0NWcXNudGdPZjF2aGd0ZVhsOHhNQ3JOazJD?=
 =?utf-8?B?RzJVdStRU3Y2Z2tiY2NjbVBsZWw5K0VxQjdSYWcrcnJtSysyYjQzbkMrTzhT?=
 =?utf-8?B?NzFHYkFHUzlDQ29SMHhrU201S0pibk43WDA3ZnFjNm5wQ1BNdVdCbUFXQ3Bv?=
 =?utf-8?B?Qm9LYXI3YXprc2thcUNZSHFkUFRPR2IyNENxQmdsWmVrUSs4Z01TcEVoZ0Vm?=
 =?utf-8?B?RzlDeUxHOWV3LzhuRFo4NkhyNm1ERUU3YVB0L0RTRFFxUTNCVy9lZnlhQjJT?=
 =?utf-8?B?bVZxU05sZjhjSEdzSU4wZk95YzBqdUtFNVJjaW1NckxHdS9SV0hYUVY2YjhB?=
 =?utf-8?B?bFNEVUpiMW5LNG93TVIzSnlBNTRIUEZhVVh5ZTR4enh1Vm53Y0tBUGExdExn?=
 =?utf-8?B?ajlQRGdkejRuTm41QWxxQXo1TnhObDRuU1Z5K1c3OVVZOHZuQlBBVmc5N29x?=
 =?utf-8?B?N0k2Y05wWG82dEdhR3lGWnUzeGZMU3pxL2I3TDZSUU1NN3gzT1FFZEc1dExr?=
 =?utf-8?B?N0VpK0ZoNjJ4cVVVbnlOYzlSa3JSWnVUUmxIS2JsYXhkK1VzY1pnUHczVGJG?=
 =?utf-8?B?RTByL2kxd2dPVFVFeFpYNGtuK0pQQlVLZ1lMMThjK0RWOVo2cng4VGx3NTJl?=
 =?utf-8?B?VG0rbkVqN1pmVlpZcm5QMDRJMElISjRldHF5d2N6ZHZwTnVaMklnQzMrR3hm?=
 =?utf-8?B?bmtLVzFnbk1ERS9lLzBncGE5Qy9JTlNlU2c1cUpWcTV4SFA4NDNSeEg1UW4r?=
 =?utf-8?B?S0FSZVNFYlVLd3huazdqQ2YrZFpVWXhTeTBpN1hObWIvTzFBU2JQbjBpTjEr?=
 =?utf-8?B?ZTNTTFJDRmZ1eGRUanlmNmVydmovbTBickMxaHM2T0tGY3dXbkppYTNFdHp1?=
 =?utf-8?B?VnJHYlhJNkljQnVsSG54ZnorYWtIOTNwNnFIeUZtbVQ2YkNUMXZTdjZ0ZkQ3?=
 =?utf-8?B?ZzgxcE5JRVdtUHhWVVNzczVsTis1OUpDQVhKbzBzUURPV1RBU09vMkpVaW9n?=
 =?utf-8?B?WXROVmMySURrS1VhazNkb2hLQ1hQTC9vMjhuY1BqblVMcVB5MGhmcnpISE9S?=
 =?utf-8?B?RlNNMm9LZ3pmK2s0OUg2RXN3V0FxcGJXcXBlbTFyZndGeGFUV0tlaHJJNHRM?=
 =?utf-8?B?bEc4dU9ZT1F0eFBidVMrNjVJZHJRbjFSRXZqU29ENnRKTFJIQTcxdUViV09u?=
 =?utf-8?B?QjQyczRCcnJlc1k1dTAwcEFvSC9XTlBWTEpHbWZPSkwvcjdVV2JveUVkOXQ3?=
 =?utf-8?B?Zm1renhiak9BVTdWdE02R1FpUnJHRUdTWG1kNjhjeHFVTmNqdmg0SkVBSXN6?=
 =?utf-8?B?UU5ZVW1OdlR1cW9uUTdyMFRjZWxQQUF5S1lyWGEzV09lMWhjR20xbVZjRm0v?=
 =?utf-8?B?WDZRNjBQcTV5S2N4SU5GVmcvSmpINkdEakFZUFhTMllFSjlQcFJlUmZQaHYv?=
 =?utf-8?B?MXNRUHZwNkRTNDNYRG9IZldDWlp3VTRpVDZ5dm43WjBSSkZ2SC9sU2lqOElk?=
 =?utf-8?B?d2JNTzFvbTNJQVRKMUh6aHdzWDdqYVMzREhqVFRhYjA2L3NxdXoxNHVIVkxx?=
 =?utf-8?B?VGx3U0wwT2tGYitJbng2aU90cUYwcDRRWjl2bHJ0c2plaXhZdWs3anMzeTMr?=
 =?utf-8?B?b3ZMVlZ0U3VPdDBBa3BqMURvc1puVEdqVnhRNVVRYXB3dGNDRTNoNEhFaWdK?=
 =?utf-8?B?KzI5enpQT1p0d3p5QlU3ODh1RDdiV0MraE81K296VlhkaEhLRCtMSGJ5Z1dK?=
 =?utf-8?B?akFuUGo5TWZLSjNkbjlqRk5qeUVRPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 75dbf3e2-2733-4c6e-1050-08d9d456b084
X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB4049.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2022 16:31:44.5315
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qzXxIQwm3a4wH4nNLZ8c4A4Hbkls5zwUl2c96LD4TmCyBZUT/ZwTUYiwoslmvM0sayitYFSDoLEUU1U+w3/Eht5x62KV29wphs3YLR3Izbs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1475
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-01-10 11:47 AM, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Return value from SWRM_REG_VAL_PACK() directly instead
> of taking this in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
> ---
>   drivers/soundwire/qcom.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index 54813417ef8e..77f9c90370be 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -235,7 +235,6 @@ static int qcom_swrm_cpu_reg_write(struct qcom_swrm_ctrl *ctrl, int reg,
>   static u32 swrm_get_packed_reg_val(u8 *cmd_id, u8 cmd_data,
>   				   u8 dev_addr, u16 reg_addr)
>   {
> -	u32 val;
>   	u8 id = *cmd_id;
>   
>   	if (id != SWR_BROADCAST_CMD_ID) {
> @@ -245,9 +244,8 @@ static u32 swrm_get_packed_reg_val(u8 *cmd_id, u8 cmd_data,
>   			id = 0;
>   		*cmd_id = id;
>   	}
> -	val = SWRM_REG_VAL_PACK(cmd_data, dev_addr, id, reg_addr);
>   
> -	return val;
> +	return SWRM_REG_VAL_PACK(cmd_data, dev_addr, id, reg_addr);
>   }
>   
>   static int swrm_wait_for_rd_fifo_avail(struct qcom_swrm_ctrl *swrm)
> 

Hello,

While the change looks good, the subject (commit title) seems off. 
Please take a look at commit titles found in drivers/soundwire, you'll 
find several good candidates there.


Regards,
Czarek