Message-ID: <139784cd-6cb7-18e0-bb09-b35113bd83ef@amd.com>
Date:   Mon, 10 Jan 2022 11:34:44 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] drm/amd/display: invalid parameter check in
 dmub_hpd_callback
Content-Language: en-US
To:     =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>,
        shenshih@amd.com
Cc:     sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch,
        nicholas.kazlauskas@amd.com, Anson.Jacob@amd.com,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220109184245.124850-1-jose.exposito89@gmail.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20220109184245.124850-1-jose.exposito89@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REpYcXhiNXJsRzkrSVk0NFZMdE90eUVYdmQxS0JVRThNSjhySEsveWx6YXZh?=
 =?utf-8?B?VjVRa1drNHo2Z1lYTGp1UmU1dWhMMnJ4OFRFUjZOK2w4VHVHVy9Ca3ptK05X?=
 =?utf-8?B?MnpiV293NlNmWHlnZVY3bE13T0lpbEdSaWt4VHFRNytHdnNZczk0dUtIVXMy?=
 =?utf-8?B?Um4zSU8wc0xBNThPa0RNdEVYakJMMGl3NnFSQ0tTL1U3bGp1cWtoWG55amUz?=
 =?utf-8?B?VGZKMW1EWDZEb0g5UVNrYThsZms2UlBvRHNWcmRnYmNkb25kRUpjM29iL3FE?=
 =?utf-8?B?Zk1RbnJoZ1QxNGFvcXdVdUFwYlJ0a1hBTnlkY1E5Sk41Y0gwL2xYOElYaVpV?=
 =?utf-8?B?bmxZUlBsNzFtNCtzUmRxdFg1Vi9iYXB3NGpnTnBsWXVBQkhOQzN2Ymx4K3hh?=
 =?utf-8?B?KzF5Z3JmazJocWZFdW0yK1JzcHJKMmwwZVJVSDV5L1M5enlVR3VDbHltOWds?=
 =?utf-8?B?T1RybzN3WjRHaWY2RFpqT3dqL2FLSkhGQjNqNWNDbklPL0g5OWdtcVB0bm5o?=
 =?utf-8?B?c0dNNUxjR2ErODQ3UTZ0S2RtczV1b3NHZTZQeTVTYzBjcnY4cENBN2FiNDhU?=
 =?utf-8?B?bWtNSUdkbmZCbVFJMUN2Y0pEdE80NnlUM2N2Qkcydi9KV3RlZXFHODlhaFA5?=
 =?utf-8?B?TEhYMG5xbTFob3haNzY4RWl1NG5yTzI4QmFEbFcwYkxvVDRiTm0yZldpM3R0?=
 =?utf-8?B?M1ZzVmpuOUFsRkZXRDlJTFRFanhSZHZ1cnBSV2JhdDdCR2tNNE1hZCtNdWlj?=
 =?utf-8?B?WDFGRFR3ZEY4aTlSNFRtNVhRQ3c5aWsyY2REbys2bzBHOHBOMjMwa2pGQU1J?=
 =?utf-8?B?bEJibW5QQ1lzRlNCZnlVbUNCWjJyL3ZOOUJNa2tOUXNsdUNSM3VOaVZqejlP?=
 =?utf-8?B?d0tyVjBuSDQwcTVqRjJuT3lxcHNCUmFEZ0xWVXN1aHVQMlBPd1ZvWmxKbnZr?=
 =?utf-8?B?MjNnNWkvQTA1MitvYjJhYXQzN3dHSnVCK2tmR2owS2xqR2tHZlRiNGg1azRF?=
 =?utf-8?B?dXRseGk2U0JPN0VJTGNkdU0vZkNtQWJ4aXh3Tm1Qd2l0YS9vdGlKVGNreHFT?=
 =?utf-8?B?N1hjcG8yTTlrb1h1ZXk3N3VmSzFFaHMyYVpjeTF0OGFsejArSXl4NS8wL3BY?=
 =?utf-8?B?dXd3Vi9zc3RJY0EzQzYxVWRIbWlocDQ3UmVYVkZocUd1T0tBcUIrSExMS1RP?=
 =?utf-8?B?YW94K1VSUlAxdzVjMi85Q1lhNFNzaE5CZlFNTTZCOVNaaDZkOCs0N3JZcGxr?=
 =?utf-8?B?WlNPWDZoR2liSjdmMHBpZkk3dDE1cXBnSzJCU1dBMndzb2dsMVRkdHR4Y0lZ?=
 =?utf-8?B?akF2SzVYbExmRkJUN3ZhZGF2T0dkQWZVY0E0emp2a2JGYjRHNnd3QlVsUmx3?=
 =?utf-8?B?RUtnSURjcGMxYjIwNUVQNlpMRnp2emYxZ1dJQ0dyaWkwb0VrZ2E1eW95NWwy?=
 =?utf-8?B?OXVIME01NE5KMFVUMStPVVd0OWRKZUdoUFExMERqdTYvMDE5ZjcvcUoxUVVU?=
 =?utf-8?B?MnhwQjdyMlFSQXg3WTNwWk0wNnkwOU9nYUI2eS83UmtzMGNydUVqTWxWR2JW?=
 =?utf-8?B?b1NmbVQ2RHk4aVlqY09pc00valVRSmFibVI4aUtvYVZSOWs5YmVoMlVITzJp?=
 =?utf-8?B?TWRDa043eTNkYk1qb2phd0VIWE13RnZxUWJlT3BqR2JLaTZhYVpWOXFyYUIy?=
 =?utf-8?B?bW5rallGdEtCNzJpRUJVeVB3Skovd0F3MzhzY0g4N1NXbWZ2aWl5L2NETTJ4?=
 =?utf-8?B?T2NJUTlldHFkaVhsMVZJMmpQTlBBTW5PTmd6STk4Ty9NS2Z6Y1lDYTdRMVY4?=
 =?utf-8?B?WFl2WG45Qm85UnlYVFNsYVU2TnRSWXhoMEVlMEg1c3JiZVd1aCtNZ0xkWTdM?=
 =?utf-8?B?OFkxMHlGbXBGL1BkN1VnTVZTOFlSWkovaVdiYzNpeG5OTFhSREVHL3BueHlq?=
 =?utf-8?B?M1k5bUNXSGRpcU5WRElMT0RNZHNPaDhRaXVzM2RLSUpXMXQzRmJHdDhXWkgr?=
 =?utf-8?B?TW9tMy9OdjRTd3ZYeXRBeUMxL0ZGYjd4V3lvazRoWlBrWk1YM2k5Y1VVaXhS?=
 =?utf-8?B?WDhNVDZReFNiRWhTRHgzZXZRR2lHaWlyb29CVk5BdURadVppZXVHemFZbXdQ?=
 =?utf-8?B?R1FQZy9Zem9PSVpSNEIzUnlWZVdFSFlvVTJSV3dQTmNhb0wwRkp4dkdwVjdK?=
 =?utf-8?Q?5NF07E+T1gudNJIJihAPsoQ=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6523867a-b1e5-4f31-a69f-08d9d4571e5e
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2022 16:34:49.1866
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2ma69dTfjEYKJwfnrghoJwuy7u40xp16HCDnjcPNl+pRrC5XZVxA6X8i/+KGN+yTAjoRiPwByKEx7/7gVNiT5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5393
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-01-09 13:42, José Expósito wrote:
> The function performs a check on the "adev" input parameter, however, it
> is used before the check.
> 
> Initialize the "dev" variable after the sanity check to avoid a possible
> NULL pointer dereference.
> 
> Fixes: e27c41d5b0681 ("drm/amd/display: Support for DMUB HPD interrupt handling")
> Addresses-Coverity-ID: 1493909 ("Null pointer dereference")
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index e727f1dd2a9a..7fbded7a6d9c 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -656,7 +656,7 @@ void dmub_hpd_callback(struct amdgpu_device *adev, struct dmub_notification *not
>  	struct drm_connector_list_iter iter;
>  	struct dc_link *link;
>  	uint8_t link_index = 0;
> -	struct drm_device *dev = adev->dm.ddev;
> +	struct drm_device *dev;
>  
>  	if (adev == NULL)
>  		return;
> @@ -673,6 +673,7 @@ void dmub_hpd_callback(struct amdgpu_device *adev, struct dmub_notification *not
>  
>  	link_index = notify->link_index;
>  	link = adev->dm.dc->links[link_index];
> +	dev = adev->dm.ddev;
>  
>  	drm_connector_list_iter_begin(dev, &iter);
>  	drm_for_each_connector_iter(connector, &iter) {