Message-ID: <516d939c-1c2b-315d-28d3-d55c6c4b6eb3@intel.com>
Date:   Mon, 10 Jan 2022 17:51:17 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.3.0
Subject: Re: [PATCH] ASoC: codecs: lpass-wsa-macro: Check for error pointer
 after calling devm_regmap_init_mmio
Content-Language: en-US
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>,
        <srinivas.kandagatla@linaro.org>, <bgoswami@codeaurora.org>,
        <lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>,
        <tiwai@suse.com>
CC:     <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
References: <20220110064259.4175705-1-jiasheng@iscas.ac.cn>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <20220110064259.4175705-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c29ZMENDTElkNXdweUU3SlBaQTJLNkc2NFROdC90eHRvZ0tlRmlSM21XMExR?=
 =?utf-8?B?S04xRVdHSkR5eTF3bEFCdDN3TXZ2ZEVKTnI0NmdwV1Z4dWJETVRkS0RjbjQ1?=
 =?utf-8?B?RDU5R1pIT3RRNU5hYmRzVThJMXFiYVRvRHo5WTN2alBOOS9iV0FWQVdWb25Y?=
 =?utf-8?B?TXVqTVpJVWQxNFZUMGtwYnJKbVU0NXJPMHU0UXRlaWI4Y0VOVVpNTFlwbzdY?=
 =?utf-8?B?L1BSZ3diREcvOHg1RnB6Z1dBMUs2L0JyUHNQWWhvQ3VEZm1qa29qMDZIYzFz?=
 =?utf-8?B?MUZEa1FEejZHbi9iT0NTZDJLazdJTGIrcTNFanZ3WnFoVmNCeDBiTlNyRXJa?=
 =?utf-8?B?TzNuN1lnWm9xZCtLOUJWTmdIZ0pzMFFoc3JWd2ZQcmhHR0VpM3ZmUENJSTRF?=
 =?utf-8?B?NWZMR2toTDlOME9oM3dWd2hRNVhabXRiUkdCQTNrbjI2T0JiQVJDZTNPV1E1?=
 =?utf-8?B?MS9mT2lObmVwNWZqejc4TFFORHVSTnMvMkNubGtPaHgwd2ExWEZKdlptR080?=
 =?utf-8?B?bUw0cXgvMTBocjZOZnExdkxJcUVrRXdkVldvU2IxVmZQSStWSU5zakxRaWRa?=
 =?utf-8?B?QndsMXpDYURVYUVHTkJJdVgycEFpZktiakRJT1hWLzc3V0NXVlZmN3JyQVhY?=
 =?utf-8?B?MG9oMmZxZmpQUStQYUxTUnVBNlhOU2tpRmk3L1pPUktsTS9yQ0c4NFdFZys3?=
 =?utf-8?B?MXlURHZoUTlMNUhiTE54ellxZXlDSDJCaGRvVEFscnlvQ0FRaWpiUnQ2LzVv?=
 =?utf-8?B?Unc5YmJpOHp0OFZHSHVFV0FWcm9ZWThvdy9rR1Jja1IvdWRyQTMzb2pYUzlH?=
 =?utf-8?B?K1NGV2dZYnVEYmFVcGZRVUh5STI2NG5JT05iZHlhOGtXVDBweS9XeWxaRE1v?=
 =?utf-8?B?NkNCdTJ6QXRldVU5RFlEUFg0OGtLSnYxdHdUVHdoZi9kYzBaWDJRYXpPY2lx?=
 =?utf-8?B?Vy9HcVRGZVZ5Z0JUWTFkQmtPd1NLUVVUMUwydDZEdU1ZV1VlVmdDUCtxWFhS?=
 =?utf-8?B?d29CRnhTN2s5aGlvTG8yYW14MGRUZnFORmFFaFZyMmFxeFoxNytDTjB5TlZv?=
 =?utf-8?B?Mk40Nmk0SWVpV2dZejBQcng2VTVTbnp3UWQwU05GZ2E2b3NWNU5MRitzaHk1?=
 =?utf-8?B?S3gwdlJURTdEazQwa2ZnOFhzSFY2YkVDUys3YS9MWmlZSGN5VzZQdGZBMURV?=
 =?utf-8?B?ZGFadTQvQjdCZ0NMMVlReFpoREEwcEl2WmhWQzB0b1ZyOWRuak9UK2ljTG1H?=
 =?utf-8?B?cmJteEVXVHJKeWxFVlNLTURoaHREYWJoVlRpVE9BRUprRHVMK1J5R1VwSEkr?=
 =?utf-8?B?OXd2U0VTMHM3TW8zUU5LcUkxRkFJMTJrYWY5UnlUTTdRUWUvNHpacXR3RndP?=
 =?utf-8?B?T1JuYWZsV1ludTNOeVI5Ym55VUZsaXR4dVdzWGJpdkJ5Um9vOWM1OW1CWFpV?=
 =?utf-8?B?eVExYmhqb0NlSFhtSVFjbEtXV29lYjkwMHhYejBySG5OSVhRMWtZbXIvcGtC?=
 =?utf-8?B?bGFxZXQ4SmV6dUJQaitmZFhJOTlJVEtZdVo1enppeWRybW9rRmF4QWhxbU03?=
 =?utf-8?B?UUNYRUN3eVNIRWtsVE8yYVdGQ0ZqTnB0VzNVVUJ0NUZRTlE1SUkzV3pLUjBy?=
 =?utf-8?B?dWFTbE5rY3hwUTJkWmtTeXhTTVArQTkxUXpHZElBb2pvUWNCTHVHeFVxUGYx?=
 =?utf-8?B?MTlDc3NvMDV6ZWtLYVd2aFBzbTZ6UjA5c3BOSGxvVzBkQWlyTUFVMlhjUE5N?=
 =?utf-8?B?cUw1TFlscmFzcDNvVS80Nk1LSGJtRFRGejZJaitDTHg4ODFpZm5va2hOU2Nv?=
 =?utf-8?B?dmZDVlljWjJoQkRLSUpENzErdnUrWHM1aWVyRUdwQ1EzSUJROFBQQXc0V1VL?=
 =?utf-8?B?VWpKWXVabmdIK3lRVEZtZUdCc093enNUemg2Mi9vY3QvKytGdlA0M0JFVEZK?=
 =?utf-8?B?SUcvRjdwQTJZUHVRT20wU1BaZUZZUVdIQ0VLdWZ0TDR5TlBsYnpoRW1NbnVI?=
 =?utf-8?B?eklXWXp1U2pHMlg5ejdhd1cyNTdqbmMxelZpNGhjdW5aVEI0K0d5bnozRlRl?=
 =?utf-8?B?UnpVckg1cDJPV0dnTkJYaGJUMGlSdlZSZUJQLzdFd3AzRHJPS3pobFcra0JM?=
 =?utf-8?B?UEdVbC94YTh1WXEyR0lQUE8ra2tuaGRMc3VtNWpobGVXMmxLY3ZPMFMrNit1?=
 =?utf-8?B?dk0yaHRyRmdXck9RSFFLUmczNERrbGl5MXZKTlhGMVVUTjQ2eUk3RkJxZkVT?=
 =?utf-8?B?OXk4NGF1WERVRERXSjl4MjlvZGxRPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c52af352-c8a0-4887-74fe-08d9d4596fae
X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB4049.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2022 16:51:24.2586
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8Er2ZrPrM/RnP4ZR8BwKE2NKpOWqr1xAHLBDRt6fYcKuQCY6JYfBcwpwxLH382EwEl9FfnLzxrzoFn2EwAgz0ikor6eVhp2jhEiQQruBQrs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4035
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-01-10 7:42 AM, Jiasheng Jiang wrote:
> The devm_regmap_init_mmio() may return error pointer in some cases, for
> example the possible failure of the kzalloc() in
> regmap_mmio_gen_context().
> Then the wsa->regmap will be error pointer and be used in
> wsa_macro_mclk_enable().
> Therefore, it should be better to check it in order to avoid the
> dereference of the error pointer.
> 
> Fixes: 809bcbcecebf ("ASoC: codecs: lpass-wsa-macro: Add support to WSA Macro")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>   sound/soc/codecs/lpass-wsa-macro.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c
> index d3ac318fd6b6..dd1a8b7bc794 100644
> --- a/sound/soc/codecs/lpass-wsa-macro.c
> +++ b/sound/soc/codecs/lpass-wsa-macro.c
> @@ -2405,6 +2405,8 @@ static int wsa_macro_probe(struct platform_device *pdev)
>   		return PTR_ERR(base);
>   
>   	wsa->regmap = devm_regmap_init_mmio(dev, base, &wsa_regmap_config);
> +	if (IS_ERR(wsa->regmap))
> +		return PTR_ERR(wsa->regmap);
>   
>   	dev_set_drvdata(dev, wsa);
>   
> 

Hello,

Perhaps the cover-letter did not yet arrive, however, it would be good 
to bundle similar patches together and provide a cover letter for such 
series in the future.

I'm replying to the very first patch sent, but it's quite obvious that 
lpass-rx and lpass-tx patches are related to this one and it is easier 
to get a firm grasp over the changes - from reviewer's point of view - 
if all the related ones are part of a single series.


Regards,
Czarek