Message-ID: <f69a0650-174f-1b0d-ba29-7fe04c7cf211@intel.com>
Date:   Mon, 10 Jan 2022 18:48:39 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.3.0
Subject: Re: [PATCH 1/5] ASoC: sh: rz-ssi: Drop calling rz_ssi_pio_recv()
 recursively
Content-Language: en-US
To:     "Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
        Biju Das <biju.das.jz@bp.renesas.com>,
        Pavel Machek <pavel@denx.de>
CC:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        alsa-devel <alsa-devel@alsa-project.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <20220110094711.8574-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20220110094711.8574-2-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <2f338a37-f2ca-33e4-284e-5d263f7b93da@intel.com>
 <CA+V-a8vz25B=cw_C4YMBRdDxeq7mi8Zc+noqpdHqfMP8eNHYFg@mail.gmail.com>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <CA+V-a8vz25B=cw_C4YMBRdDxeq7mi8Zc+noqpdHqfMP8eNHYFg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2dxNlNVcGxqcVp6dWVCUFpaaHAyYzN2VEcrS2FMUXZZSGVvVkJna3JIMVE1?=
 =?utf-8?B?TnpzNVBFQXRwMEJvaVFiWEhJZ3dPSHFudkxQdXB4RFRjQ1pHOUJFd245TkJU?=
 =?utf-8?B?RVF0WVl6N3BDODludTB4TkE3TVh3WE1wL0NoMCtFeis3WmcvVUVYOXFPV3Zl?=
 =?utf-8?B?OG82MzZ4RkV4VGpLR2V5dTlnU2N2R3YrK3c5eStUNXdVdk5hb3AvR2JYOWZV?=
 =?utf-8?B?UHBvcGRKVnFpWVFhYlhiNS85Qm5sWTZnZkg0bjkzM0l1endvazlQNGV5dERT?=
 =?utf-8?B?UmZ3RjNnNUNxdkRnNnRHb2FTT2VnaURmRUdsVEJHSm9yRmdlY1dwVEUrQm00?=
 =?utf-8?B?N2dlUGo4WUJ0MGZXV2pvZm5UNDJ1TEZ1MVJHQUtXK2czdktrbzZpV1NYK3Nm?=
 =?utf-8?B?OTNFeXl3Q0NnMzAvOGE0MVN0UWg4YlNkOTZKOUpFRHl2dDd2M3JmdkZMY2dI?=
 =?utf-8?B?WWFzNERycHhLcTBxa01kQzhoVU1nTGp0TXlBbU9UenRtQzFRUGp3c2pRdERj?=
 =?utf-8?B?Nk02b0w5dkFsOW85MEVCVnE3TGtnQ25QNFZNaUtEYmFKYzdYcFhiY252VG44?=
 =?utf-8?B?ODFxWTN5bW1UT2FIMW41aEMyM0ZVelI2QTVyRnRPTWJRR1Rha1pzZmtqWGlx?=
 =?utf-8?B?SUU4dGtWTFRVRThNYTNoV1lISWFCTzQ3Y2lRQUdPYndEM0dJUGZmUzM2MTV4?=
 =?utf-8?B?SVpRejBtKzFBT2Y0Lzd3L25ranRPeEwvbkVVMVNicHVwM1V0QUFTbFI1U2M4?=
 =?utf-8?B?YXhYTWllMjVId055TUhaN29jeFlya0tvU0pOTDhPYnNRc3JacHJNYjhKeFZn?=
 =?utf-8?B?K2wzcVRqdVBhOWNWZUpGUUJiTEZpRGxvTU05T1JOVENoZTJJN0RmUFdGZnNM?=
 =?utf-8?B?YWlhWmtESHFRUUgxQWo0WnBvVHhrQ0RpVEQvV3lkZFVVTWxSOEhHdURibzVy?=
 =?utf-8?B?bEVSSFFzUmxoSUVmOHp6d01GQjVpQVNJbVpJSlVrbkdxQzNxK1lkZFRUQ0Vz?=
 =?utf-8?B?YmxtZGpiY0wwamQyMlpoS3FFTk9ISTVGWVJEdWV2czllSHNwNjZIVkxpN21M?=
 =?utf-8?B?RVZFY0FaQ2lpN3NRT0g2bVZOQWhRd0dJRlB0NDdBNHZkQTltdG81RTVONUxt?=
 =?utf-8?B?cTFFR2FjU3h6dGcvNHRyTFN0RFczc2tIRXJOS1dSRFBuV0wvYUhOS1ZEMnlT?=
 =?utf-8?B?YlowZUdMK3ZxR2dxSEg0aHhUcjYwTm9OalMweFNQLys4OHEzL0VSZW8xdUFR?=
 =?utf-8?B?N3BjbXV1eHNDQ0Ywem56aTVsTHMyVUFlczFlbjJMQUQ0MU52VldZVU5oVnJG?=
 =?utf-8?B?YTlNVDFPRWV0cWNxVFdvVE4zSmhsbHJxY0FsdDQwdmI2VWE5aWpzUlhDRXFE?=
 =?utf-8?B?UXB0aS9TRjVLaG9WRFVvKzlIaGN0WnNySDJNQ05DVWdlcGdDb1VBdExjeHFE?=
 =?utf-8?B?Z3VFUUtYMTQ0Z0J1T25aZ2p0cS9OTnRpWEd4TUdYRzI5TXhqOTBwM1VTM3VL?=
 =?utf-8?B?M3k4WHZucGZUWkFiNzVSb3I0Wm91bGxBK3lMSXlKOXJkZTZvNFRXeVgvWG5u?=
 =?utf-8?B?S0NWdkxTQlQ5b044SFJGZ3djNk9YLzk3SjVHUHQ1L2Q1aXovek9YWmlGNWtO?=
 =?utf-8?B?NVVVWTZIK1lta2drVHVsdVNRRHhiVnZxdGY2SExtUkFhWXlHSWNKczlqSmZB?=
 =?utf-8?B?YlA3dUMwZU5vL0lRc1phbi9oWCtmVzRrUUY5UGtEZGJEb1lXbUVHUnZTY3gw?=
 =?utf-8?B?NjhISDBHVU0wcVdpeXpEQ0xIUG1JK2ZrUjRwZHVhTVpoVUhSTXJjNG5mUy94?=
 =?utf-8?B?TEJBenRnc3Z3TFAxaVhndlVycDZMaDVKeWUrWEVTZkdPZ3FRMVR5bkUwRkcv?=
 =?utf-8?B?R25DOEkvSGIvSWEvZGhFdm1NODhNSHkrTHc1Y0xLQW55ajkwcXNNSlZlbk12?=
 =?utf-8?B?blNlTllTY1llcE1SUmJZbXhSakhJbWR4aThNL3BDVXNNZm84LzJoZ3k3aGRN?=
 =?utf-8?B?WFFvQURWdnJNZ1A4NCtqOVQyVEovSzkvamYreEFraWdxdy8rbDVlRXc2bUJO?=
 =?utf-8?B?bGdkRFYwTmszTUM0cTN1YzE2azVNNFZxcDRLaDZSWmRDcmRwZ2xDamJja3RQ?=
 =?utf-8?B?bVhGcXFoS2ovMXE4VGYzV2l5WW54a2c3L1V2NVVzVnFrL3VkVXorL21SbE11?=
 =?utf-8?B?Q3RFbUQ3S1JKUEwxdStZaStLelJ3S0tZclhld0FpdlpHS2RTNllBYTRGMlB4?=
 =?utf-8?B?ZTl5cHM5clpYWDRvRncvTVlJcFNRPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d3220ded-8731-4040-e36c-08d9d46172f0
X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB4049.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2022 17:48:45.6530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /XO90RsK8+IE6Rrfh+mZTYERGOZ1ZS2lqoQ2H9deJ9Xmf+rmE+hVqDInB/bSuC14zV9a7gFYPlk1OG+QYq7hvMZY1JOg8UDstLlBmOdSS/w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2659
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-01-10 5:03 PM, Lad, Prabhakar wrote:
> Hi Cezary,
> 
> Thank you for the review.
> 

...

>> Recursion and loops are means for doing something repeatedly. Could you
>> specify _why_ such change was made i.e. the conversion from one method
>> into the other? I bet the code is not being changed for the sake of
>> changing it, the reason is simply missing in the commit message.
>>
> I had feedback from Pavel "recursion is unwelcome in kernel due to
> limited stack use." which I did agree with as a result I have come up
> with this patch. Also to add this driver will later be used on Renesas
> RZ/A2 SoC's which runs with limited memory.

Adding that reasoning to the commits message will prevent questions 
(such as mine) in the future. Thank you for a quick reply and a 
transparent answer.


Regards,
Czarek