Subject: Re: [PATCH] iommu/omap: Fix missing put_device() call in
 omap_iommu_probe_device
To:     Miaoqian Lin <linmq006@gmail.com>
CC:     Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        <iommu@lists.linux-foundation.org>, <linux-kernel@vger.kernel.org>,
        "Nagalla, Hari" <hnagalla@ti.com>
References: <20220107080428.10873-1-linmq006@gmail.com>
 <de3a3e1c-6c51-e951-cc7f-9ce2ccb3f283@ti.com>
 <20220110022531.GA61@VICKYMQLIN-NB1.localdomain>
From:   Suman Anna <s-anna@ti.com>
Message-ID: <fd659736-2106-1be3-084b-7caddf2dc18e@ti.com>
Date:   Mon, 10 Jan 2022 12:43:57 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20220110022531.GA61@VICKYMQLIN-NB1.localdomain>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Miaoqian,

On 1/9/22 8:43 PM, Miaoqian Lin wrote:
> Hi Suman Anna,
> On Fri, Jan 07, 2022 at 08:42:16AM -0600, Suman Anna wrote:
>> Hi Miaoqian,
>>
>>
>>> Add the corresponding 'put_device()' in the error handling paths.
>>
>> Also, need it in the regular path, not just in error handling path.
> I think after calling platform_get_drvdata() normally, the
> reference will be released in other functions, so don't need it in the
> regular path.
> 

No, it's a local reference and is acquired within omap_iommu_probe_device() and
needs to be released within this function. What other function are you referring
to here?

regards
Suman