Subject: Re: [PATCH] drm/amdkfd: make SPDX License expression more sound
From:   Felix Kuehling <felix.kuehling@amd.com>
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Jonathan Kim <jonathan.kim@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        amd-gfx@lists.freedesktop.org
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org, linux-spdx@vger.kernel.org
References: <20211216094503.10597-1-lukas.bulwahn@gmail.com>
 <642a6389-b8bf-7607-c65a-52d506c240f9@amd.com>
Organization: AMD Inc.
Message-ID: <0058a913-f308-7c29-5d8c-8f8f1186974a@amd.com>
Date:   Mon, 10 Jan 2022 16:22:39 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <642a6389-b8bf-7607-c65a-52d506c240f9@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHkxRmFmRmxkQmUydWx0cjdUMUdmb1Z4d1JLdk1QYUFXcmdYbzJxWTUybmQ4?=
 =?utf-8?B?N2E3VkhhMERpeGpIQ3AzZ2xEU2hTRG1zRllrWUI2ZWYvL0hjQTF1ZWgzUXpy?=
 =?utf-8?B?dWJtdk8xeEhkanFqV0tOd0NGVDlPRGhodlBybTk2MllhVHlTQUl4ODQ5OSs1?=
 =?utf-8?B?R050Q1BVcmkvME1aaVBVMVQ1ZG95NmRjWUVkb1NvS214KzU2ZHY1MFA0eWhr?=
 =?utf-8?B?dTFwZXFJZndTNDdmS0RxT1VtbVY1em1FUnRnZ1hZTG55VVpGMTAvL05aYXFj?=
 =?utf-8?B?VE5BZVNzOE0wTE5pSElvWWRKUERVeGp1OS9zSjF5OXBzaFFMZ3AyRWhwL3dn?=
 =?utf-8?B?WDE0d1c0NktkVUE4U3Y0N20zd0VJbnBCSWRzNVUrdlBIWXFSS0pTVXFKa0Jl?=
 =?utf-8?B?YVhPNUFOa2hJdlRvTE1qQTI3U3F5SU5Xa2g4T0VqTFJYOWJua2ZsZ21IdlF5?=
 =?utf-8?B?MDJUY0tiWkNCRWROMWRGOWFKLzYrWjhxYlhXdG1SY0lraENvWTFuclZaaUpV?=
 =?utf-8?B?LzJlUG1DMy9IK1JpS24rbm42THcvcnlhWE9WMmhXZW9qY3BtOElWaHRoZDdq?=
 =?utf-8?B?RlV6THkzeVpHRTZBZmJyMzRCRWVGaktIVzYrRHVhTnhPTzZNdnk3aTdrQlZF?=
 =?utf-8?B?eHA2eU5neWFtcnZRQkJjOHcrOXhFamxzSGYyNkZmcm9COFJQL0dxcVZPKzRz?=
 =?utf-8?B?YnJoVStCaEdCc21nZUk4cVV6bnJaNzN4WHAxQlhmZllYV2ZaMWVma0orQjJY?=
 =?utf-8?B?UnhJY0U5Z1A0UG1CK3FlM3RLQmxiS281Q1RHaUJ1VUdNTUszUlVnTWs4STc3?=
 =?utf-8?B?TGFTZEZpSHI4dWowZlE0L3cxSjcwQ3JjdkEzVTNTcC9UOVJPUURTZjU5cDF5?=
 =?utf-8?B?cWlUZHpzNTdaSDNyM0FOWmNEMnFqSUJ0b2lxVWY4ZXlOZUFXK1hhZ1FzTTBv?=
 =?utf-8?B?RTdsSnJlRWhja2RSczFSQTFtZHdrU1VkQ1o3QjdSMXZkRmhraWdoWExlUUJR?=
 =?utf-8?B?Vk84UGhVcmNOMzc1RU5UYmNNbEk1Vnc1Y3RqWkpVamV3RTZMOVIrNURQcEYr?=
 =?utf-8?B?VlhjRWF0Y2QrQkI1eDkvZmNpRHh6QUlyeU9tUWFYdTBCV0JqZ1RnQ1pYemFH?=
 =?utf-8?B?N3JpL2h2SEk3ZjJWSU5PVXV6ekdRUlB3aEdaRE9ibVpoNHpJZWxaakpiYkEv?=
 =?utf-8?B?dFVmbTV1WVdCTlFWWXF4RjRPejZ1NUlVSUMzR2tkYWxEYS9YVitZcUFvVnBC?=
 =?utf-8?B?MGYwWkhaZEwzMHR4R3FCa3RGR1J4ZGN0clVjVXhJbHZjWHpkYzdSc0MvY0Uw?=
 =?utf-8?B?NXZVYktwZndtaW95eFNjZmdSM2dKRXFYOTEvbnpLdnQyem1WdCs5N2wzaXd1?=
 =?utf-8?B?S0RYcGd2cEJlVnh2bU9EemJwUEpISGhyU2tWdXllaFFUQmRQakpoMkc3UmV0?=
 =?utf-8?B?MnpaV1pmWk0vVnM0RzRkU3BVMHVDZkxXRURxeERZNkU5amlTV29sY3BQbFk1?=
 =?utf-8?B?T2ErZ2owQWpUMWk3eUNJNmFwZ256WWFGSjFPU0drU2c4MWlrV3ZubzVSLzhD?=
 =?utf-8?B?cy94SkZ5K3ZKNXB5aCtFdnFtS1FJcmZ1cTBSeUlYNWdXSm0vcjd4MGx0OWJj?=
 =?utf-8?B?T3gvVDZzdHh6V2tPb3RHdjAva1Mwd0lucWtRM0Z3OStrR1IrN3dtbld1ay8y?=
 =?utf-8?B?MjlpU0lNdk03VlBQRUFHMkpnczNWdGx1NnAzS1h0eVJ5RVR5WXR1UjFDZ2hr?=
 =?utf-8?B?cHBGMWdndXcyT0l1amU5dHc2SVJaZGJ2SW5pUG45bE96RVVHc1I3WithYWJB?=
 =?utf-8?B?clZsNzVGR2NLYVU2aks2aWdseUlLVzBicUh5MytpeW5meWFTK2F5V3YrUFox?=
 =?utf-8?B?ako2cjhKRzhzeVM5QmpzNEVGS21PbEh0UTA1dk1rbllLbExiS3FhSng2eUdK?=
 =?utf-8?B?NHR0di8zUW9zU3Y5aWdYR3JHdWFlcGd0Ui9ERGZEWFNxaVFqM2MwdS9kQW9H?=
 =?utf-8?B?ZCtvTXd0amZlR1NvVFAzd1llazYwbE5iSzhGdGs4VlpUdkZFck5FMzQycWZT?=
 =?utf-8?B?QVhMdUlJeGhxMTFDK0ZoK29EdXQybDdseHhQN1V4bzRDS2tFRlRpdWx6VlJO?=
 =?utf-8?B?NTJ4cEl6cEZITmtBSTY4UmZrR0tyc3BIU0hwS0RnZzJ2YitqZXlMSHdaZjAw?=
 =?utf-8?Q?K+HAR0Qb3bXun7I1RC1I6sc=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad773bdd-6b4b-4f7c-4173-08d9d47f55a2
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2022 21:22:41.5404
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qPFAdh8OSM/Epiwf/Gw4R0JuB25TjIkkK/+PIpgn8z55aXScfDydWVDSTgnzcmfkyJHby4TIiLakvRiWGht/pA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5260
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-01-05 2:27 p.m., Felix Kuehling wrote:
> Am 2021-12-16 um 4:45 a.m. schrieb Lukas Bulwahn:
>> Commit b5f57384805a ("drm/amdkfd: Add sysfs bitfields and enums to uAPI")
>> adds include/uapi/linux/kfd_sysfs.h with the "GPL-2.0 OR MIT WITH
>> Linux-syscall-note" SPDX-License expression.
>>
>> The command ./scripts/spdxcheck.py warns:
>>
>>    include/uapi/linux/kfd_sysfs.h: 1:48 Exception not valid for license MIT: Linux-syscall-note
>>
>> For a uapi header, the file under GPLv2 License must be combined with the
>> Linux-syscall-note, but combining the MIT License with the
>> Linux-syscall-note makes no sense, as the note provides an exception for
>> GPL-licensed code, not for permissively licensed code.
>>
>> So, reorganize the SPDX expression to only combine the note with the GPL
>> License condition. This makes spdxcheck happy again.
>>
>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>

I applied the patch to amd-staging-drm-next.

Regards,
   Felix


>
>
>> ---
>> I am not a lawyer and I do not intend to modify the actual licensing of
>> this header file. So, I really would like to have an Ack from some AMD
>> developer here.
>>
>> Maybe also a lawyer on the linux-spdx list can check my reasoning on the
>> licensing with the exception note?
>>
>>   include/uapi/linux/kfd_sysfs.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/linux/kfd_sysfs.h b/include/uapi/linux/kfd_sysfs.h
>> index e1fb78b4bf09..3e330f368917 100644
>> --- a/include/uapi/linux/kfd_sysfs.h
>> +++ b/include/uapi/linux/kfd_sysfs.h
>> @@ -1,4 +1,4 @@
>> -/* SPDX-License-Identifier: GPL-2.0 OR MIT WITH Linux-syscall-note */
>> +/* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR MIT */
>>   /*
>>    * Copyright 2021 Advanced Micro Devices, Inc.
>>    *