Date:   Tue, 11 Jan 2022 00:48:10 +0200
From:   Abel Vesa <abel.vesa@nxp.com>
To:     Stephen Boyd <sboyd@kernel.org>
Cc:     Jesse Taube <mr.bossman075@gmail.com>, linux-imx@nxp.com,
        mturquette@baylibre.com, robh+dt@kernel.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        ulf.hansson@linaro.org, aisheng.dong@nxp.com, stefan@agner.ch,
        linus.walleij@linaro.org, gregkh@linuxfoundation.org,
        arnd@arndb.de, olof@lixom.net, soc@kernel.org,
        linux@armlinux.org.uk, adrian.hunter@intel.com,
        jirislaby@kernel.org, giulio.benetti@benettiengineering.com,
        nobuhiro1.iwamatsu@toshiba.co.jp, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
        linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v7 5/7] clk: imx: Add initial support for i.MXRT1050
 clock driver
Message-ID: <Ydy3qvT5w6IWnR7s@abelvesa>
References: <20220103233948.198119-1-Mr.Bossman075@gmail.com>
 <20220103233948.198119-6-Mr.Bossman075@gmail.com>
 <20220105235157.8ED80C36AEB@smtp.kernel.org>
 <89046151-e44e-6828-ad76-8574fba4fca8@gmail.com>
 <20220110201201.C1E37C36AE9@smtp.kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220110201201.C1E37C36AE9@smtp.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6IZzw5J84yaG3gkonz8I+PV/Sgd0wWSUBLQmityPj93Ha1kaTmNF4/rtE9UY?=
 =?us-ascii?Q?e5zqAqHBR1r4aUbrk8xGPxsqcD+PnUU3qMxae/MYIQMf0ontdToQjbO/LS//?=
 =?us-ascii?Q?y3Q1UYlQgHxKMP+Jo3l+TNJ310HaDcdRl+7GAzz8Is+Ci6FzzOOTwGKlAqBm?=
 =?us-ascii?Q?Jzw+4gzGEcRr3gkPx/4ItkFSCcaIvVE8M42HiqLQC8/RXVcrT9sfJ9BKPESk?=
 =?us-ascii?Q?IaOQpTd8KOtTIotUlQSbgnvLKfcdYpDDUg3FtNocWQG96ZJaxTFaOeXOAhYU?=
 =?us-ascii?Q?g712fNkClkxJtS5X7q6cB4XiOL18h3ykVyBkqGTCYNpCRlPjgbi6okH0Wqd5?=
 =?us-ascii?Q?3ZSAVCeQ77IaWqS/A5SA0eVgE3IaVNogCLOOv+xaVEbXiYC6DlpW0v9oCJ+m?=
 =?us-ascii?Q?y7KZCsBn5CH/GiOHOPKG4r0Eg6msYb1MtU3TzrOKx6ZoZVg75PHnj0mKctb2?=
 =?us-ascii?Q?I/7JJ+nbJ79raF+f7+mnIgRp/0ZmXfOc+2Rm5gPO38HSEr7Va7XJqywm1ihl?=
 =?us-ascii?Q?XyKDCewco4boGkAMcUQukl+FUksOedOPSQfSscVsDVIny1X8r6xj908xQhr7?=
 =?us-ascii?Q?c3M+OdJenuJzFxkO7Irg6ZfrncAr7SbqxjDLj0K6RRY6BEdhBcCzKALFcyJg?=
 =?us-ascii?Q?Np6lZseTFqAMLd5yO0TpTap4B0Un4IEyBdyyEy9Z+9s2ijEnTq+mIdLPAobL?=
 =?us-ascii?Q?4xlp06St+Y1Lf+QbbphlrA7FmM9wp4VMqXTRlpRGwrC/BHdIZ3ukL+5kWm0N?=
 =?us-ascii?Q?ei0+ulH/OMwbz96Yy5PfZRouGoUN19W6zRz50HpUkS4+zmkSF32Odbx5TZkY?=
 =?us-ascii?Q?jHLgFfHxEzQEdvo4yCd2GMMS8tSuPlmxMB/P94fy2cBypNv0P7WFH+yvhI4X?=
 =?us-ascii?Q?gTd8/i2jfF1+ssmHLThpB7adbOSUrbRdqh8NCq3w2lp6wY835T2EGqXGObZp?=
 =?us-ascii?Q?8WgalCjawPTiGdNhGIsgWhGF7UhKGIoVW/LRMGAQQnErhVybD4sdauCVJWS8?=
 =?us-ascii?Q?NTt3Vt2g78VGwq5+Bu7mlf3IaNP+l3UXtokoBBF9XxtLgKEKiDjmA+1Ga/mQ?=
 =?us-ascii?Q?Wm5nlI63By/y4uywMgKNvjonyPjA5WoJm9cc++XYH2wKFadWxIuVKBwV/Ndr?=
 =?us-ascii?Q?FzsrCyt8IeTp8jFANfZf+sd4C7AnqQZTch3o1Gj8rUTQSYVAfcQfHTDvRvsk?=
 =?us-ascii?Q?0j8dDr6NKfZiptrSLTOPQyxoy25cMbxS3oWh/1fQyZMG3sIXwj5xw4+te1PU?=
 =?us-ascii?Q?HddbWQjk86TC4kN8V3v8U/BOySfIIcyZdCE1JumSZZvMuJ2KzGQcTweDUUBA?=
 =?us-ascii?Q?76wQ6GklaDwTcVsMrKigvJiogJ57q8qVfa2B3z5aE93GwH95hwDhcEWLWEGy?=
 =?us-ascii?Q?jV2GxpaB/KPXRJJbhSBwtZSIgh3R8AR55/LL/Zx5tFIAaajEGyKtWvy4J9Cm?=
 =?us-ascii?Q?5c5KbyCzHRiLs7t7sJKxjwtOOH3OeEiAoxPoDll9jbnqh+ddbReZrjgoIIGP?=
 =?us-ascii?Q?Dhhxxi2o4Nmm5GslAGusxW3vf7OA6vkT7uKnbNNvgUIMvvd+Y5Ez60uZgsYH?=
 =?us-ascii?Q?c/ywcpH/6S/Zvfo7rM0mGprU6yviPS45iL2Ie16aOsWb/6L4LM0M9nv9xQWa?=
 =?us-ascii?Q?OBxNAU6F9x+eTDTd6F1cHno=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e33278c3-0d7f-4262-5f7b-08d9d48b4823
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2022 22:48:12.9049
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aNMAYIaNOmQBdgcPS3Eiepx8uJxwrLR/BQxzySEQ4SArrjLI3WNKMA2dySOFYbGHth15iIZ/R1ffIfE3vxZl2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2862
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22-01-10 12:12:00, Stephen Boyd wrote:
> Quoting Jesse Taube (2022-01-09 11:07:42)
> > >> +
> > >> +       clk_hw_data->num = IMXRT1050_CLK_END;
> > >> +       hws = clk_hw_data->hws;
> > >> +
> > >> +       hws[IMXRT1050_CLK_OSC] = __clk_get_hw(of_clk_get_by_name(np, "osc"));
> > > 
> > > Use clk_parent_data instead and reference the binding name with .fw_name
> > 
> > Hi Stephen, sorry to bother you again.
> > I'm wondering if adding `clk_parent_data` is necessary as it seems like 
> > it wold be a big change and the other IMX boards haven't implemented 
> > this yet would it be okay if I don't do this, or if it is necessary 
> > could you link to a patch set to change it.
> > 
> 
> Is it a big change because the imx_clk_hw*() APIs aren't prepared for
> non-string parents? Can you make some clk_parent_data based APIs and
> migrate things over gradually? This is really a question for i.MX folks
> to see if anyone is working on moving away from the string names.

I'm currently looking into it. I would suggest we take this patch as is
and I'll switch it later on to clk_parent_data.