Message-ID: <57513f5f-1e66-3758-a56b-1eced486a4df@linux.microsoft.com>
Date:   Mon, 10 Jan 2022 15:12:49 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
From:   Dhananjay Phadke <dphadke@linux.microsoft.com>
Subject: Re: [PATCH] mtd: spi-nor: Add support for w25q512jvm
To:     Michael Walle <michael@walle.cc>
Cc:     Tudor Ambarus <tudor.ambarus@microchip.com>,
        Pratyush Yadav <p.yadav@ti.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20220109044418.4657-1-dphadke@linux.microsoft.com>
 <262a03e185c29583450180e3dc8c4e6c@walle.cc>
Content-Language: en-US
In-Reply-To: <262a03e185c29583450180e3dc8c4e6c@walle.cc>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 1/10/2022 7:10 AM, Michael Walle wrote:
>
>> +    { "w25q512jvm", INFO(0xef7020, 0, 64 * 1024, 1024),
> 
> OTP_INFO(256, 3, 0x1000, 0x1000)
> 
> should enable OTP support, could you please test this using the 
> flash_otp_{dump,info,erase,write} tools and add that line?

The board I've has HW filter between controller and NOR and doesn't seem 
to allow security reg access opcodes (read to be specific).

So long as adding this doesn't affect probe, I can add it. Otherwise, 
will have to leave it for later when that's fixed.


On 1/9/2022 9:07 PM, Pratyush Yadav wrote:
>
> You need to show the dumps of the SFDP and other flash parameters. See
> [0] for an example.
>
> The patch looks fine to me otherwise.
>

Lemme collect SFDP dump and include it in v2.
I ended up sending stale patch that has extra comma between INFO() 
PARSE_SFDP macros, so need to re-spin anyway.

Thanks,
Dhananjay