Date:   Tue, 11 Jan 2022 03:00:12 +0200
From:   Yevhen Orlov <yevhen.orlov@plvision.eu>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Ido Schimmel <idosch@idosch.org>, netdev@vger.kernel.org,
        stephen@networkplumber.org,
        Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        Taras Chornyi <tchornyi@marvell.com>,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 5/6] net: marvell: prestera: Register
 inetaddr stub notifiers
Message-ID: <YdzWnEt4ore0WFVs@yorlov.ow.s>
References: <20211227215233.31220-1-yevhen.orlov@plvision.eu>
 <20211227215233.31220-6-yevhen.orlov@plvision.eu>
 <Yc3DgqvTqHANUQcp@shredder>
 <YdeaoJpSuIzPB/EP@yorlov.ow.s>
 <YdhDZ9Fkkx/moJH5@lunn.ch>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YdhDZ9Fkkx/moJH5@lunn.ch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnNKV09DQlNuMlFnYkZxZzNLMmtkdjhXV2pXMEtyMjR1dy9kRHpQWDFhanNL?=
 =?utf-8?B?ZVRITmhlczg0dzlHZDhnenRtNzh2Wnl6MzNjeFVVVFB2WnROQ0pabVpNU2dG?=
 =?utf-8?B?N0hzZU5lcWwvb3UweFVEd2NTaGJsYkVEdnlYbUNPOGxlalJaWlJZVi9pYWVn?=
 =?utf-8?B?VXM4U2R6RVQ0bjR2Yk95Ri90Z3o2dDlvZUxZMHI1NmprdmgwS3FyM2loOFFF?=
 =?utf-8?B?Q0hPL0YxeFJ5UGlCS3ZYWDNpWjhBYVRzRkE3VmJmRFFmdDcwYW0zVlNYKzd4?=
 =?utf-8?B?QkZkZ1NvNjNXMG9veS9ndVJHZ3RLU0hBd0pGVnNxVWQ3aGc2d1d4cTkxc0Jk?=
 =?utf-8?B?YlpGR0VneDV1M1VKTFpML3dwVXROK1hUWStmbGhjYlNxMDR6aUJNN0ZQOUxi?=
 =?utf-8?B?R3k5MDlsWXA2Szd1VHR4QitMcFFidStrSlRBVXVPa2phZmZBRDVYMnhHT3da?=
 =?utf-8?B?ZDhOVkdzTTN3L21ab3pVVEQ0ZE01WGVBaEZVbFppZDBUeEhiZWJiRU9vdis5?=
 =?utf-8?B?bmtUT3dSbFVSRUN3Z2pEcTFlV29BbTY2b0pwQWhpbkNCeURvVDhsRFNtNmdE?=
 =?utf-8?B?cW1kMi8vT2pOVUU2bjRCVTk2bjB4WmcrSnBaMlVrMzhXVUgxLzZvNFlPMVgv?=
 =?utf-8?B?eC8va3dyc1BFNSt6c0lQMDIrNnJIelgxNVZyUXowVTBOa2JlY0EvZjN0NXN4?=
 =?utf-8?B?SnJ2UUtUeFNwdXFyeWFBUGtxZlJZa2dEQTZQeGpTcnRteVkvaUdwZ3hBMEQv?=
 =?utf-8?B?UUk1RVk0VkFyQ2ZEbE5XdzgweUZYTE1tWWhZTW5jODFmM21ueTcvbENTa0cy?=
 =?utf-8?B?Y3pXamNXa2pKL1NOL1J0YjVtRHlNT2RxaUFpeVdyaUpSZExpVEV1MmJvS210?=
 =?utf-8?B?RTJvYkExRG1uWUNkaEZ6K1J2TFAybEZzV2J2bHByWUFDL3ZYcnBxTU5DK0FT?=
 =?utf-8?B?V2NPYnpKazQ2eHpOUXkzN21YN3pEckNLOHhnS205NlVza3hVdjZnTTk0ZEhz?=
 =?utf-8?B?UXllYzVISHpQSUlQemxuNSt1aU9ucXBpcXN4VmZnYXpKUmJQMzZ4YTJlckVH?=
 =?utf-8?B?R0VxY3dOL0lVemN5SzVGQ01qNEhUNnc5UHlZamNHTkxFazNPNGV5VDZnYjBl?=
 =?utf-8?B?eGVSTzBsMjJYNUtyeU1wUUxBbXc5RUZaL0FESjFCbzdrMFN6bGNiWE9JcElr?=
 =?utf-8?B?czZhYjVUa0VwVmdZMkFIZzQraUtheHFqR3ZyQVVhSWtkeGhWVnRZZ1RFMlpN?=
 =?utf-8?B?dzF2RlRxK0lDN3I4ZmlNakpxTzBsM1RXbEVPYXF6Zm5lWlRtdTRXeWJaN1lP?=
 =?utf-8?B?a0QzNXRiZ1Y3eER2aHZwQndQaTFtMkZjTmROZEJTdVNsOFMrYlplSHRjYXpP?=
 =?utf-8?B?Vk1oNGNmWGQxTVV6M21wekQvSSt6dStkU05tcStzcjhiOTBTSkZMU3B0RXNz?=
 =?utf-8?B?bysvcmRtdlRVVzMxeVcwUUNyUU1KYkZ2UG9YLytCa1lYSVdma2g3RlNYUkg4?=
 =?utf-8?B?bzg1TlFURDJMOTZJT0FJelE0M2d0R1gvbjBBcWZPMzU2dDN3RVh5TGd5Rm1l?=
 =?utf-8?B?c0dQN3ZLSlVEdjhUc1oxSGFsSkd1b2hSVC9kZUFmcUsyOENUMjFSVldBNEhZ?=
 =?utf-8?B?VU9oZWZBVzVNUlZ3dyt6TEFadHFSV0s0NFFscGFWekNVd2NzTHpkb1FtWER2?=
 =?utf-8?B?dzNURnBlZG52UGd3ZGpJRkVDekJsZGhTOHRYeTRQSEtJQXpxeXFKNlQxVXk3?=
 =?utf-8?B?NXNPVHVwdTlTYmFwYTFZVVJKNnk2ZWRvMUNIY1BkUmdjZ2o2QnVUc2Z5WVJX?=
 =?utf-8?B?WE4xVGVzVW5PQklDdEU4OXEvSm1KYnpMQTNPVEYxN1paUlBhSXdkVU1kYlp6?=
 =?utf-8?B?MnNkVTFWcVZwZGVySUxHc0VBSThYSjhad3VyVllrdnhIU2xkTnF2MmJJN2xL?=
 =?utf-8?B?RjlDbjhiQWhPbGcwa29TZ0tTemRqaCtIb2VCOUVQTEVMR3BXV0RpYzR1aWFQ?=
 =?utf-8?B?L3IvOGJEWGVwS2pwSHVuNHJkZTBHaXBIb0JxWE1tcC9CdE1aQkJRQThLREwr?=
 =?utf-8?B?bnhVWFREd20xR3dXRGhLUWZLS2RLVEQ4ZTNLc0ZkOTFZcFJzQStISlVzKzBF?=
 =?utf-8?B?eGhrYlBBbGwxVlBSNHpMU1JLN0wrSFkrSGFWb1lUMnM5RUV0SndGSjA4L05B?=
 =?utf-8?B?cHkwNkZhYjNkNmVjSGRjQU0wcTlCZUxJNXNmZnhGYWxyK2FyWjQzbkd6cGJl?=
 =?utf-8?B?TE91cXNKVURqS0hZSlNhbkRxSG1BPT0=?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: 362f956a-7fbc-4954-0c71-08d9d49dba69
X-MS-Exchange-CrossTenant-AuthSource: AM9P190MB1122.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 01:00:15.4848
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YuMMjc6D3tC1owgUc98odaW5Qvl1P84TCHWucElYYaoU1KY8dbonplyyx/OZj5QMGl+V/HLRH/vXgCvm0f8l0B8fjrkYIVvAvTO+VSF+WS8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4P190MB0099
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 07, 2022 at 02:43:03PM +0100, Andrew Lunn wrote:
> On Fri, Jan 07, 2022 at 03:42:56AM +0200, Yevhen Orlov wrote:
> > On Thu, Dec 30, 2021 at 04:34:42PM +0200, Ido Schimmel wrote:
> > >
> > > What happens to that RIF when the port is linked to a bridge or unlinked
> > > from one?
> > >
> > 
> > We doesn't support any "RIF with bridge" scenario for now.
> > This restriction mentioned in cover latter.
> 
> I did not look at the code. Does it return -EOPNOTSUPP? And then
> bridging is performed by the host in software?
> 

Perhaps this is what you looking for:
> static int __prestera_inetaddr_event(struct prestera_switch *sw,
>                                 ┆    struct net_device *dev,
>                                 ┆    unsigned long event,
>                                 ┆    struct netlink_ext_ack *extack)
> {
>         if (!prestera_netdev_check(dev) || netif_is_bridge_port(dev) ||
>             netif_is_lag_port(dev) || netif_is_ovs_port(dev))
>                 return 0;

We just do nothing for bridge port.
Note: we cannot return ENOTSUPP here, because this will make
impossible to add address on bridge interface at all.