Message-ID: <5de5e884-417b-a884-d1b4-55f6892fad8b@nvidia.com>
Date:   Mon, 10 Jan 2022 17:07:12 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v2 01/28] gup: Remove for_each_compound_range()
Content-Language: en-US
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>, linux-mm@kvack.org
Cc:     Christoph Hellwig <hch@infradead.org>,
        William Kucharski <william.kucharski@oracle.com>,
        linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>
References: <20220110042406.499429-1-willy@infradead.org>
 <20220110042406.499429-2-willy@infradead.org>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20220110042406.499429-2-willy@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0lvSEZtK0I0YXF4dWMwUEFkOEloUWZFajBDSTk4WjIzSEIrQUtXQkJneHZR?=
 =?utf-8?B?OHVQMXB4S3VhZHAxY3BhZVJQT1RyeFFvTm1uTmlQQXlMUXhsbU1NbEZCNitm?=
 =?utf-8?B?UW1HSml5NXBERkxWVjBxY3NCenZPbEdUaW8rQjQrRVgzY01uWVJwU2F4clJM?=
 =?utf-8?B?UGpxRWl2Sm9mU2lQdjBHZU4zT0pnMWdkU2hpOHdWUWU0eFU4TWw5b1k0bVE2?=
 =?utf-8?B?NU43T1ZyUDZmOWdkUVZqR1d4M1B4YnZOS29ldnlna3ZjL1ZkUEtkY2xxU1R3?=
 =?utf-8?B?RzF2b2QzNnNUZUNKSUdJelFrUDFtdzFtYmpidWlhTFZIVVBWR0V4RlIrc2tT?=
 =?utf-8?B?blc2UC9DdG1vMXpNMThDejAzZk9xaGRWR2c2TitxMnJ1VUMvOS9rNzJ5NnVI?=
 =?utf-8?B?c2pNUGFnblFSZWpqa0JycFFoQjMwWUZ2eW1BdjNCa3pnRVRVaEV2UTVRWEZx?=
 =?utf-8?B?YXNpV2ZLMnZoSHBia0lKWjNuTE1IcEE4UXBSbDN6ZFA4TzVycDRQUm1SYjFw?=
 =?utf-8?B?R2FwazI2WWJjb0thejUzNENhL1l5WUd2TXppM2FYUFpHT2tic2kwUjVKV1Ar?=
 =?utf-8?B?UUY4bi9tazU1akg5czBlY2lQMHlZRFNwek9UYzlCYTJNTm00ZzQrQXQ1bU45?=
 =?utf-8?B?U2FWOURySjNhWDRidnBrRnVVVUtQUDV2YTVXNmZvYjR4TmF3TCtIdlVERkIr?=
 =?utf-8?B?NjhKWkJ4NTZPL3ArVFI4OEdPMnZsSUlxcnRzU3puYlViNEFQNWN6Yyt0L3NO?=
 =?utf-8?B?blp0Tnd3MlRLZW1QTmM5cnUvVWVHMHcvaWszanJ0VktJUE8xbU4vUHVGZ2V0?=
 =?utf-8?B?MVp4Y0dLdmdyUllmcmNpVWNaTWRoNGV3dW5OaS90UEZxMHdmREFwRnAyVVUz?=
 =?utf-8?B?R2pqVEVCTjdHRW9SWGt3ZmRqUEg3NG1MTTk2V3BZK002T1FHcWZ0dFVmZTRV?=
 =?utf-8?B?K1VXYk9LcDJsZGJlNFlpVWJ0WnA4YjZzekd0a1hFL296MFNSN3cvTXIrUEJx?=
 =?utf-8?B?N1RCU0NacDIzQ1gxdkFhbE9tSVVKVXNEYS80cHpsZjl6VVFZWjNRM1k5bGJS?=
 =?utf-8?B?VlN0ZHZhM1MxT2puZExVS0p6amk5b3ZoTy9GeVlNRFM2NlY0bk9BalU1bUJY?=
 =?utf-8?B?S0NQYkcxaTc4NmdGVFdCQTdDOXkycFdtWXFvSVJ2UHgySmNqMEJwSTBicnhu?=
 =?utf-8?B?c2U1dHhCNU9XWXM0TUZPcEQyTEkwb1J6bUZ0U1J4aXpNcWxBU29HSEdEQjBu?=
 =?utf-8?B?azc2TGtNQ3B3Vm05azl0V0tObkZYdU9GQVhzTjZLbld4M04zMFlHeS9FeVRw?=
 =?utf-8?B?RXJRZHpJUHlCNThaSlBabm9uSnFaeHdLNWpkWkVJTzJuTlkrR3dFeURpNkdK?=
 =?utf-8?B?WW5EVTg5bGtXODJWcUZHRDZzN2p2STdidnIvYjNDSTZsTE9MeGw4SzQ1ZGlU?=
 =?utf-8?B?RzlzT0NrTVVUYnIrbURhOEVEVE0vd080Qk0rNGNmWnFwR2hwYVVUTGZlelFs?=
 =?utf-8?B?cW1xV05RZXc0TFlwOUxOczRNWmJ4ZkxtZFI0bGZuSXFXSzg3MTR0NzJtbVBL?=
 =?utf-8?B?TGUvcVE3dFBhd25FODBhaVJkdmNZTTZvc29oRDFid0dXeWloYmlOYUpSczkr?=
 =?utf-8?B?V2RSQTh1aS9UaG9sV2dNYkZFblF3Y0RtTEcvZ2F5ZFFVL2pjMllaZmZNZVNk?=
 =?utf-8?B?UmozN1AvRm50RFd2MGxZWmkrYWhad2JKLzlCamx1bGN0YlVLS3NGdlNDd3U3?=
 =?utf-8?B?TmxLYitnaTV2VXdTcDJhc1ZNQW44N0tjWmdTQnVZeEFReUh3VEhiRnQ2M1Fs?=
 =?utf-8?B?YVdMYnB3aS9ZbzlCNnlvUkxyN1V5YTVSVElhMGVrejJzaDNWNW5YcnlWemk2?=
 =?utf-8?B?dkxWbDAvTXp3SjBOM3MybGZ0T1k5VHNBUUszeGtFbDFjK29LZlRjNGZyUlFl?=
 =?utf-8?B?TU9zaXVNRFAyYWhKaE1yTXYwbnh4VnJzRGlUT1J4QStVNkYwR1EvOUREbXlM?=
 =?utf-8?B?YzV1YUwrTXM3RkQ0MVNQbHU3MlpWYnBLa2tFU0J2MTFRb2pEWmk3ZithOGx2?=
 =?utf-8?B?WVFERlF5Q0F6cDAyeDBVZ25GaHR5Q3h2N2pTK3NCbyswZ0YvZFRYRWdoTGtS?=
 =?utf-8?B?b3Q0L2E1MEk3MTdsNndBdzRhY092RDVoeEtTNjA0VUF0QjRWeCtDWmpmZHYz?=
 =?utf-8?Q?oFk9vyiiM7cuImt4NVTqMZk=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ae71d02-6c7c-4e7a-51d8-08d9d49eb437
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 01:07:14.6062
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z08/4KHfRWtnEaHdACSZWxeLhtlG8UjkBewcuLXd4XtlssVTmId+8eJ70Dfu6/GicxrQ1PyuPZJJKEyg0Vputg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3778
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/9/22 20:23, Matthew Wilcox (Oracle) wrote:
> This macro doesn't simplify the users; it's easier to just call
> compound_range_next() inside the loop.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
>   mm/gup.c | 12 ++----------
>   1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/mm/gup.c b/mm/gup.c
> index 2c51e9748a6a..7a07e0c00bf5 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -236,9 +236,6 @@ static inline void compound_range_next(unsigned long i, unsigned long npages,
>   	struct page *next, *page;
>   	unsigned int nr = 1;
>   
> -	if (i >= npages)
> -		return;
> -
>   	next = *list + i;
>   	page = compound_head(next);
>   	if (PageCompound(page) && compound_order(page) >= 1)
> @@ -249,12 +246,6 @@ static inline void compound_range_next(unsigned long i, unsigned long npages,
>   	*ntails = nr;
>   }
>   
> -#define for_each_compound_range(__i, __list, __npages, __head, __ntails) \
> -	for (__i = 0, \
> -	     compound_range_next(__i, __npages, __list, &(__head), &(__ntails)); \
> -	     __i < __npages; __i += __ntails, \
> -	     compound_range_next(__i, __npages, __list, &(__head), &(__ntails)))
> -

Yes!! Thank you.

>   static inline void compound_next(unsigned long i, unsigned long npages,
>   				 struct page **list, struct page **head,
>   				 unsigned int *ntails)
> @@ -371,7 +362,8 @@ void unpin_user_page_range_dirty_lock(struct page *page, unsigned long npages,
>   	struct page *head;
>   	unsigned int ntails;
>   
> -	for_each_compound_range(index, &page, npages, head, ntails) {
> +	for (index = 0; index < npages; index += ntails) {
> +		compound_range_next(index, npages, &page, &head, &ntails);

And now the code is more "honest and up front": items that are changed are
passed by reference, and one can see right here what those are.


>   		if (make_dirty && !PageDirty(head))
>   			set_page_dirty_lock(head);
>   		put_compound_head(head, ntails, FOLL_PIN);

Reviewed-by: John Hubbard <jhubbard@nvidia.com>


thanks,
-- 
John Hubbard
NVIDIA