Message-ID: <2017d0ad-9e76-d1d9-666a-5f2cd7632b31@gmail.com>
Date:   Tue, 11 Jan 2022 09:53:37 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: Re: [PATCH 0/13] blk: make blk-rq-qos policies pluggable and modular
Content-Language: en-US
To:     Christoph Hellwig <hch@infradead.org>
Cc:     axboe@kernel.dk, jbacik@fb.com, tj@kernel.org, bvanassche@acm.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220110091046.17010-1-jianchao.wan9@gmail.com>
 <Ydxum/2iwp6hDw68@infradead.org>
From:   Wang Jianchao <jianchao.wan9@gmail.com>
In-Reply-To: <Ydxum/2iwp6hDw68@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2022/1/11 1:36 上午, Christoph Hellwig wrote:
> On Mon, Jan 10, 2022 at 05:10:33PM +0800, Wang Jianchao wrote:
>> This patchset attempts to make blk-rq-qos framework pluggable and modular.
> 
> I really don't think making them policies modular is a good thing, and
> your new exports/APIs are a very good sign for why it is not a good
> idea.

Actually, before sent out this version,  I didn't make them modular but just
pluggable, and yes, it was because I had to export those interfaces. However,
when I made the patch to introduce a policy which support cgroup and had to
increase the BLKCG_MAX_POLS, it seemed worthy to make the previous policies
modular as we can release the blkcg slot when policy module is not installed.

In addition, our own kernel uses the policies as module. When we recommend iocost
to our customer, they love to see we needn't to reboot machine and even needn't to
stop the IO workload if upgrading of iocost is needed

Thanks
Jianchao