Message-ID: <bb83d65e-bcd8-9da8-e54b-0dde6f23434e@acm.org>
Date:   Mon, 10 Jan 2022 19:25:54 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 0/13] blk: make blk-rq-qos policies pluggable and modular
Content-Language: en-US
To:     Christoph Hellwig <hch@infradead.org>,
        Wang Jianchao <jianchao.wan9@gmail.com>
Cc:     axboe@kernel.dk, jbacik@fb.com, tj@kernel.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220110091046.17010-1-jianchao.wan9@gmail.com>
 <Ydxum/2iwp6hDw68@infradead.org>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <Ydxum/2iwp6hDw68@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/10/22 09:36, Christoph Hellwig wrote:
> On Mon, Jan 10, 2022 at 05:10:33PM +0800, Wang Jianchao wrote:
>> This patchset attempts to make blk-rq-qos framework pluggable and modular.
> 
> I really don't think making them policies modular is a good thing, and
> your new exports/APIs are a very good sign for why it is not a good
> idea.

Hi Christoph,

Personally I don't need the ability to implement blk-rq-qos 
functionality as a loadable kernel module.

When I implemented the ioprio rq-qos policy (see also blk-ioprio.c) I 
noticed that I had to make changes in the block layer core 
(blkcg_init_queue(), rq_qos_id_to_name(), blk-rq-qos.h) instead of 
having all code related to the new rq-pos policy contained in a single 
file. I think it would be an improvement if new rq-qos policies could be 
implemented in a single source file and no block layer core changes 
would be necessary.

Thanks,

Bart.