MIME-Version: 1.0
References: <20220110025203.2545903-1-kuba@kernel.org> <CAHk-=wg-pW=bRuRUvhGmm0DgqZ45A0KaH85V5KkVoxGKX170Xg@mail.gmail.com>
In-Reply-To: <CAHk-=wg-pW=bRuRUvhGmm0DgqZ45A0KaH85V5KkVoxGKX170Xg@mail.gmail.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon, 10 Jan 2022 19:42:47 -0800
Message-ID: <CAHk-=wiTN_hOyQ1_3DPgYJ_oBhwN+e29jrsj8qjqKsodRZ6r1Q@mail.gmail.com>
Subject: Re: [GIT PULL] Networking for 5.17
To:     Jakub Kicinski <kuba@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Pablo Neira Ayuso <pablo@netfilter.org>
Cc:     David Miller <davem@davemloft.net>,
        Netdev <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jan 10, 2022 at 7:31 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Merged. But I now note that this actually triggers an error when
> building with clang:
>
>   net/netfilter/nf_tables_api.c:8278:4: error: variable 'data_size' is
> uninitialized when used here [-Werror,-Wuninitialized]
>                           data_size += sizeof(*prule) + rule->dlen;
>                           ^~~~~~~~~
>
> and I think clang is entirely right.

I pushed out my trivial one-liner fix for this as commit 63045bfd3c8d
("netfilter: nf_tables: don't use 'data_size' uninitialized"). The
build error kept my clang builds from working, so waiting for any
alternate fix wasn't going to happen.

              Linus