Message-ID: <f91d9546-1621-8431-5ac7-2192adcf9482@nvidia.com>
Date:   Mon, 10 Jan 2022 20:14:04 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v2 12/28] mm: Add folio_put_refs()
Content-Language: en-US
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>, linux-mm@kvack.org
Cc:     Christoph Hellwig <hch@infradead.org>,
        William Kucharski <william.kucharski@oracle.com>,
        linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>
References: <20220110042406.499429-1-willy@infradead.org>
 <20220110042406.499429-13-willy@infradead.org>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20220110042406.499429-13-willy@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NzZiTFZLR0FjVmx6clVSWTczbXhMcDluZ1RVWHcwZVhJeU1lazU2dDc0ZjBv?=
 =?utf-8?B?eWJuaHhPNWpQc3JwUDM0eEV2VGxNQUFpcnVNMWZYNDR3MWc3U1hzMzQwNWZY?=
 =?utf-8?B?bFRWeWFkY0JPUmREUzNTZ1FETUkvbjJuRi9LSDNyTUhPTFlFQTE2UktubUdO?=
 =?utf-8?B?U0RQOW5Fd1ZhbE9XSlVFL2JKb2NxUWlHM0lBUUx0VGtqcWM5c2pBVjBCOGYz?=
 =?utf-8?B?Y3NDUFhuajRralNOR3ZOblR5YW5Ya2NobURyRzVBVnVmM2tTdHZZNDM5aWRp?=
 =?utf-8?B?QVVPUlphakJHODRJYUZaZ1ZxY2U0RHZyYUszNjFMMzVsNVFZTk1sclZEWC9l?=
 =?utf-8?B?eXRKamswR3hWVUl1STYxRXJud2IvSnN0ZVdnR3hibkwveFZIaXZLYjdnSDRm?=
 =?utf-8?B?M0VDYjVTcEt0OHo3QzJTcEZqL3cvNWNjR0hhckppMnNjcHhwTEY2aStYS3NI?=
 =?utf-8?B?aSs2SkEwNkhVSWwyWUcxWnFVRFQ2dUJPN3pQNkhpVzQ3TVlsTytFbTZ4STBS?=
 =?utf-8?B?WTJLRjlnYldCUDNzNlZmallyTTAyMkJFbUpFc0Ftb2hnTzRKRXdra2tRbTNK?=
 =?utf-8?B?YlhYeS9wYkNxRHVnMXBZck9PM3NOWHRGcEVnc3AwL1VMQ1ZEbHlWd2hSSFZo?=
 =?utf-8?B?YUJDL1l1dWdkcUVKWkx3NXgwYm1tWTU0VGUxMHoxOWh3QVpNbXRkMFpKRmVh?=
 =?utf-8?B?Y2VEKzZKSmlHOHJVS2o3RmxwR0ZtbDZwOHo4akJ2YkVpd0NmM1p1OCtUYzh6?=
 =?utf-8?B?NVNySU9BRXFqYlZmUWJza1ZBTkxnRDh5REh4K1I0S3o4N2g2ZldSVmVrWjRx?=
 =?utf-8?B?b1RWcDQ0SkNScjhVQWUvYktMSUphT2ZqWk1JNG5YRFJnaU9yOHRMekhUeE5i?=
 =?utf-8?B?WTRsMEZrY3VvbEFiZXo5aTNvMFYwVTFPb084MDhvNFQ3TmJQRUZObWhqdGdI?=
 =?utf-8?B?QkFQQlBaUWFRQm9tazA0WUFQQVM3Q0VZK1NzWnJXN2ZFenpydDhYdFd2Vk5x?=
 =?utf-8?B?cTFlcjh5Rk41STJoWTBZeUNrT3I4L003YUJWZGJQb29McVhMaW1NQVF5NnJh?=
 =?utf-8?B?dFU1ZEdYa3BISDFxamx3cUpMZG93WHZBRnFmTy9xYTE3NEErcEp1dFdPWDAx?=
 =?utf-8?B?ZEhlaDU4UFBhcUJUT3plZnE4MUljcXZTYndDa0Y1MzhqUmgxaUphbVgzUUdv?=
 =?utf-8?B?eVVYd1E3azlJTExhOERSWERwV3E4SHhsU0c0ZHVWWXVZTGVNaWxVdmF6RFdU?=
 =?utf-8?B?bEFleDd2cE5WUkxuV0pQWE16V21rVjhjMy9XeGI4Q0YvejhVVE5keU9qUzZM?=
 =?utf-8?B?VUdrWHpFV1lzTzBXWG5CZXMrY1hyazJFck9GelVzQ0ZoenYwcjgzVHVvVmJD?=
 =?utf-8?B?N2syZW9UZmtpZm5tUUN4bTNpZUpQSWdNM01DMzQ2dnFGckFzUUJUZGt2ZFJQ?=
 =?utf-8?B?c2xMWm9iMXlaZ0RvL3R2REZaZnBWSm8rRmdvUXFjNlJMeUtiZ1lOQWRyei9H?=
 =?utf-8?B?WlFPdEJxRmRoNEgxVk5aZlMycTZmQWEwUXFCRTlFOU45K0diMGF5Z3UwZU1r?=
 =?utf-8?B?SXpINlpYTnZPVkZkMjdpNHMyYWJRVU1xTUVoWXc3VTNBN0FPOExXMVo5dmdv?=
 =?utf-8?B?YW1vSWJrSDlyNVJFcFRkYzVzV3lhci9wSkxKaFVsRTlYYy84RndUZ29odmF3?=
 =?utf-8?B?UG9xVWVBNStZemhBT1M1VklPcFh1YnRqZDlPeEZaMks1QUs1RStlQzBVM1ZN?=
 =?utf-8?B?U0g5UXppajlpblpXcklRK2REOEtYbmVqZk80VS8xYTdDSXdwT25mdzRDckR3?=
 =?utf-8?B?WG9oc0krQUpSZnlnQ254aDgwMjJnSUJCU0EzZXEyNjNCNnRncldMaUxsLzIw?=
 =?utf-8?B?VHpPS1lxSEVLeExENG9pYzJtZ0N4Y0RYUFpNMVZROXVrbm0vdDQ0cS9qdHhI?=
 =?utf-8?B?MXZMakgwVDVUNlM5U25oWEhVOEhDY3l4UXNMWWFaM1RQblNPaGw4RWxIWHlr?=
 =?utf-8?B?MXBnUUdvenYzV2xnT1ZWbzk5WHNoQjBXd0Z0SzBBMGtGcUZzNWd3MWlFWFJs?=
 =?utf-8?B?QnVEVndYeVN3NFJseW01eEp6L2dETE91M1hsS2tHcncrS0pvWmc2ajJkNHRx?=
 =?utf-8?B?TGdFMC9MZ081ckJnWDEra0hiR0hxdnBQT2lpZEp1UTYvamJFUSs3c3B1ei9R?=
 =?utf-8?Q?audvWATB9fDlyHGDg6R0nFk=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef5abe60-43b8-43c5-a3cc-08d9d4b8cef7
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 04:14:06.2136
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8ckTs4sNn504D80G1Mqsa/BesdDTfgJPLDbVCqfTkxyZotouxJnDCe+HOQn/sKIT+JzvQZGRAywkciF4/Y4RQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2984
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/9/22 20:23, Matthew Wilcox (Oracle) wrote:
> This is like folio_put(), but puts N references at once instead of
> just one.  It's like put_page_refs(), but does one atomic operation
> instead of two, and is available to more than just gup.c.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
>   include/linux/mm.h | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 598be27d4d2e..bf9624ca61c3 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -1234,6 +1234,26 @@ static inline void folio_put(struct folio *folio)
>   		__put_page(&folio->page);
>   }
>   
> +/**
> + * folio_put_refs - Reduce the reference count on a folio.
> + * @folio: The folio.
> + * @refs: The number of references to reduce.

Tiny rewording suggestion, if you end up sending another version:

  * @refs: The amount to subtract from the folio's reference count.

> + *
> + * If the folio's reference count reaches zero, the memory will be
> + * released back to the page allocator and may be used by another
> + * allocation immediately.  Do not access the memory or the struct folio
> + * after calling folio_put_refs() unless you can be sure that these weren't
> + * the last references.
> + *
> + * Context: May be called in process or interrupt context, but not in NMI
> + * context.  May be called while holding a spinlock.
> + */
> +static inline void folio_put_refs(struct folio *folio, int refs)
> +{
> +	if (folio_ref_sub_and_test(folio, refs))
> +		__put_page(&folio->page);
> +}
> +
>   static inline void put_page(struct page *page)
>   {
>   	struct folio *folio = page_folio(page);


Reviewed-by: John Hubbard <jhubbard@nvidia.com>


thanks,
-- 
John Hubbard
NVIDIA