MIME-Version: 1.0
References: <tencent_7A45E1E967F13AE14B061269@qq.com>
In-Reply-To: <tencent_7A45E1E967F13AE14B061269@qq.com>
From:   Jason Wang <jasowang@redhat.com>
Date:   Tue, 11 Jan 2022 12:37:49 +0800
Message-ID: <CACGkMEvPnsDHn_gUdq2g2_Xzzqp8KVVhpaApnssYT9NT=mgm1A@mail.gmail.com>
Subject: Re: [PATCH] virtio_vdpa: Support surprise removal of virtio vdpa device
To:     =?UTF-8?B?5p2O5Lic5Y2H?= <lidongsheng@dayudpu.com>
Cc:     mst <mst@redhat.com>,
        virtualization <virtualization@lists.linux-foundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jan 11, 2022 at 11:38 AM =E6=9D=8E=E4=B8=9C=E5=8D=87 <lidongsheng@d=
ayudpu.com> wrote:
>
> When virtio vdpa device removed, the abnormal damage of the device cannot=
 be
> perceived normally, which will cause problems similar to:
>
> 43bb40c5b926
>
> Hence, add the ability to abort the command on surprise removal
>
> Signed-off-by: dongsheng li <lidongsheng@dayudpu.com>

Acked-by: Jason Wang <jasowang@redhat.com>

> ---
>  drivers/virtio/virtio_vdpa.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
> index 4a9ddb44b2a7..fd930409d190 100644
> --- a/drivers/virtio/virtio_vdpa.c
> +++ b/drivers/virtio/virtio_vdpa.c
> @@ -374,6 +374,7 @@ static void virtio_vdpa_remove(struct vdpa_device *vd=
pa)
>  {
>   struct virtio_vdpa_device *vd_dev =3D vdpa_get_drvdata(vdpa);
>
> + virtio_break_device(vd_dev->vdev);
>   unregister_virtio_device(&vd_dev->vdev);
>  }
>
> --
> 2.17.1