Date:   Tue, 11 Jan 2022 08:06:44 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Phillip Potter <phil@philpotter.co.uk>
Cc:     gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
        straube.linux@gmail.com, martin@kaiser.cx,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] staging: r8188eu: convert DBG_88E calls in
 core/rtw_iol.c
Message-ID: <20220111050644.GD1951@kadam>
References: <20220109215427.887-1-phil@philpotter.co.uk>
 <20220109215427.887-4-phil@philpotter.co.uk>
 <20220110100843.GC1951@kadam>
 <YdydYlpVzHoLy2Wh@equinox>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YdydYlpVzHoLy2Wh@equinox>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5MpqWCzUPiI09U4lujb18f7lU9W7ZZAXZf+gzpcnZOjdu3Fn7CyrhNm8j2KI?=
 =?us-ascii?Q?GBbuoSNGlMTVMHJQ8DhJJAe1KPpV6ciEopLbXytc675+XJPnIDWgDK2hYiP9?=
 =?us-ascii?Q?eb4IiTYBOt2ma9TvUyo9vjeIfJJ8mLXQ9t/F96yS878exL5jFFOyRYha+nX/?=
 =?us-ascii?Q?2PCyLbUTRQZZIk4YsQcZvR4DUUVicw2sBqqKmiLKb5SEo7wtzrB7xTjmdjLr?=
 =?us-ascii?Q?vUF4f0ILn148Iz27wuUCvp9W4KZ6rSgxPL2iwJmV9dB6E0CUP5GeJ0EIUXfB?=
 =?us-ascii?Q?Jeldye6NWfSEgobbWTF/YRi94V8IzkNq8M2rjI0d+v+Vz6BqyJzcNyaB+/zQ?=
 =?us-ascii?Q?JqiJPhwZiyxe4uQg2+eJVyBEcw9opJYczydSKkicnlDOOuEfqHxs5xD9J/Kr?=
 =?us-ascii?Q?2brKvY1RFDvNqdHiItoopaQYXiBQnOkdeyiWwRbAOKZ/LsVUTQb3E9KSmOb/?=
 =?us-ascii?Q?SfIQZkJbPBZi21IousRzoK1xLOIrs3ZyTP55398M0RJk+8rBtkQRKQ3ZhEeo?=
 =?us-ascii?Q?JVjH2Vdlij2zY/dbty+ICKukc4L916EGSrMaXE0yroV+Q0iVSMjlNXjjdy4Z?=
 =?us-ascii?Q?x4qEpRFLztjfB07YxPsn+6WdVazSVpRGdLkq7b9OLW1MCSeeV5vYTHWVOHWA?=
 =?us-ascii?Q?BWtoCLiYkzz8/PZ804dYCg6e+CRKLG6jt85ALXsos5A8F5xG4nuqpRFxFd2B?=
 =?us-ascii?Q?Wbyf4aFrV4NXSUbx4+eVRj4jNgkvcvS9U4uXCI2fUTNt4FPWRuD/F2VUOaDd?=
 =?us-ascii?Q?bvlScvfwpDbHze3Zgw6NPcbMcuqXWplMnHSRlxg85xnNMxoBKCAwzhyI5ijn?=
 =?us-ascii?Q?v63fiAARkTyEsWFbNT1UPAL2owsDVCJfm2VqhSLotFXhlHnQ1YkvsBifESzr?=
 =?us-ascii?Q?htIqe0sFXVdv1xmHOpIrXyBA37OLQ1fqAKfHlZWe6Bv4/maj85BX0IdfrDuj?=
 =?us-ascii?Q?V3r26xOcmcXdaQkkk6nYGgUSK5X97MWYkM4hFk8XmXS2nJkLi+MjXNKfmk2r?=
 =?us-ascii?Q?Kb0tDAhnHGmCtAVvHASZTpWjiPCo+098K9C7gorsPFGxzDRh2zwRwDlliflT?=
 =?us-ascii?Q?PdclcJ05K3o+fmPV8iw0YdO1oEYwGdq38NLBgtZy8wd3FaPC3QCqjD5K2UzC?=
 =?us-ascii?Q?vea050d1ZaBzBPTFhnf2qqzOh9c0z4m9ahyYYXZNj6osxXR6XGh+Hj5RyfbH?=
 =?us-ascii?Q?DVKGhTUJghj9SeB7isaeoI+9hAxQQXtuUpKZvL3Pr/qHT6ftaWXcP6OjjPEs?=
 =?us-ascii?Q?oFeXaffyAuWf0ivOirmRCujL6s/8YNRYUKVRCnNBRi9EbMvvs5HNl/gdM6HH?=
 =?us-ascii?Q?qHgDgc9BNBaUyWKr7oUbBB0S/+Xv1GhDSpvVLm8hWHRhnUS36iR4ogkz++du?=
 =?us-ascii?Q?PffH3dSf2oOcQl2kDFqVafq3UdTk0psXARqeMyxp1fkqKH8RD622DPxZ9arY?=
 =?us-ascii?Q?lpkA2T7SW+Gi73lILGuet8bRe8i4QzFwtiiup18DrYD88v4LhDrNyOHEyc+2?=
 =?us-ascii?Q?qB7wzXD/fdsfLnPauZ+vF6qxZjIuB1KCUj7M/t8Zz2p23jrdcQ9WDfzpUeJV?=
 =?us-ascii?Q?VYYzh/ItBr0pmSWdD8ZGbhG+wzrFc7aEkG8FYZDPnGeLPWnlxU0CN+5MYzxq?=
 =?us-ascii?Q?UNy064P4WCliXsbYYgDYCkp+pbdjRD+XtASqJza1F7gdW4STkWMZYcnThS+F?=
 =?us-ascii?Q?TyMdnq+W95Xyy/ll8cO3mteZwm8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bb34142-19de-4851-3ecc-08d9d4c036b7
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 05:07:06.8611
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NJ0Yhr6xLO/KEg93fHad20PC3EK5UKxUCUaMUqaiR1HW7TpTygPvcHSsPKvLMM3Ns4U3FpWpnuzIkW/qfLHvQ+qyt34OY1Wss2SkWAnh7tA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4691
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10223 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 spamscore=0
 phishscore=0 adultscore=0 suspectscore=0 mlxscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201110023
X-Proofpoint-ORIG-GUID: X8DT1FNDQtWgKMyrjn_mrUuevzta0n-T
X-Proofpoint-GUID: X8DT1FNDQtWgKMyrjn_mrUuevzta0n-T
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 10, 2022 at 08:56:02PM +0000, Phillip Potter wrote:
> On Mon, Jan 10, 2022 at 01:08:43PM +0300, Dan Carpenter wrote:
> > On Sun, Jan 09, 2022 at 09:54:23PM +0000, Phillip Potter wrote:
> > > Convert the DBG_88E macro calls in core/rtw_iol.c to use pr_debug
> > > or netdev_dbg appropriately, as their information may be useful to
> > > observers, and this gets the driver closer to the point of being
> > > able to remove DBG_88E itself.
> > > 
> > > Some calls are at points in the call chain where use of dev_dbg or
> > > netdev_dbg isn't possible due to lack of device pointer, so plain
> > > pr_debug is appropriate here.
> > > 
> > > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> > > ---
> > >  drivers/staging/r8188eu/core/rtw_iol.c | 10 ++++++----
> > >  1 file changed, 6 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/staging/r8188eu/core/rtw_iol.c b/drivers/staging/r8188eu/core/rtw_iol.c
> > > index 7e78b47c1284..923da2a9f6ae 100644
> > > --- a/drivers/staging/r8188eu/core/rtw_iol.c
> > > +++ b/drivers/staging/r8188eu/core/rtw_iol.c
> > > @@ -12,13 +12,15 @@ struct xmit_frame	*rtw_IOL_accquire_xmit_frame(struct adapter  *adapter)
> > >  
> > >  	xmit_frame = rtw_alloc_xmitframe(pxmitpriv);
> > >  	if (!xmit_frame) {
> > > -		DBG_88E("%s rtw_alloc_xmitframe return null\n", __func__);
> > > +		netdev_dbg(adapter->pnetdev,
> > > +			   "rtw_alloc_xmitframe return null\n");
> > 
> > You're going to have to send this anyway because of the compile issue.
> > 
> > I feel like you are not being aggressive enough in the debug messages
> > that you delete.  For example, this one should definitely be deleted.
> > Don't print an error message for alloc failures.
> > 
> > It would be easier to Ack a mass delete of these messages.
> > 
> > regards,
> > dan carpenter
> > 
> 
> Dear Dan,
> 
> Thank you for your feedback. I already sent a V2 series to fix the empty case
> label I left in core/rtw_mlme_ext.c, sounds like a V3 is needed though 
> based on this feedback - admittedly I have tried to be conservative and
> basically only removed commented DBG_88E calls or calls which just print the
> function name/line number so far.

Yeah.  I saw v3.  It's fine.  I'm not really trying to nak your patches.

> 
> I get what you're saying about deleting them all just being easier,
> but I've already converted several in previous series that have
> made it in. It would make sense to delete these converted calls as well
> if going for the total deletion approach. Also, I do worry some of the
> info could be useful. I'd appreciate your thoughts on this.
> 
> I am happy to delete it all by all means, just want to make sure majority
> would be happy with that approach, as opposed to a refinement of this
> approach and being more judicious with deletion of more DBG_88E calls.

In the original code DBG_88E was kind of an error level severity message
not a debug level severity.  Of course, you had to use a module option
to turn on any output at all so it's hard to judge how that works in
real life.  By making them debug level severity, you've basically
deleted them already...  Don't be a hoarder.

Once you change it to dev_dbg() then it becomes more difficult
emotionally to do a mass delete.

There is a real value to just deleting stuff.

regards,
dan carpenter