Date:   Tue, 11 Jan 2022 11:21:09 +0530
From:   Pratyush Yadav <p.yadav@ti.com>
To:     Dhananjay Phadke <dphadke@linux.microsoft.com>
CC:     Michael Walle <michael@walle.cc>,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: Add support for w25q512jvm
Message-ID: <20220111055107.tevqpnt32mzjodok@ti.com>
References: <20220109044418.4657-1-dphadke@linux.microsoft.com>
 <262a03e185c29583450180e3dc8c4e6c@walle.cc>
 <57513f5f-1e66-3758-a56b-1eced486a4df@linux.microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <57513f5f-1e66-3758-a56b-1eced486a4df@linux.microsoft.com>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 10/01/22 03:12PM, Dhananjay Phadke wrote:
> On 1/10/2022 7:10 AM, Michael Walle wrote:
> > 
> > > +??? { "w25q512jvm", INFO(0xef7020, 0, 64 * 1024, 1024),
> > 
> > OTP_INFO(256, 3, 0x1000, 0x1000)
> > 
> > should enable OTP support, could you please test this using the
> > flash_otp_{dump,info,erase,write} tools and add that line?
> 
> The board I've has HW filter between controller and NOR and doesn't seem to
> allow security reg access opcodes (read to be specific).
> 
> So long as adding this doesn't affect probe, I can add it. Otherwise, will
> have to leave it for later when that's fixed.

Please don't it if you can't test it. In that case let's just leave it 
for someone else to add later.

> 
> 
> On 1/9/2022 9:07 PM, Pratyush Yadav wrote:
> > 
> > You need to show the dumps of the SFDP and other flash parameters. See
> > [0] for an example.
> > 
> > The patch looks fine to me otherwise.
> > 
> 
> Lemme collect SFDP dump and include it in v2.
> I ended up sending stale patch that has extra comma between INFO()
> PARSE_SFDP macros, so need to re-spin anyway.
> 
> Thanks,
> Dhananjay

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.