Message-ID: <9f5369d2-a2e4-f759-7b03-562ee215f17a@nvidia.com>
Date:   Mon, 10 Jan 2022 23:01:13 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v2 19/28] gup: Convert try_grab_page() to call
 try_grab_folio()
Content-Language: en-US
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>, linux-mm@kvack.org
Cc:     Christoph Hellwig <hch@infradead.org>,
        William Kucharski <william.kucharski@oracle.com>,
        linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>
References: <20220110042406.499429-1-willy@infradead.org>
 <20220110042406.499429-20-willy@infradead.org>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20220110042406.499429-20-willy@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3kxNktXdEQ4Y1hOTThCSDNVaVdvZnpWb0V5eGZuTzY0R3NSUExtdHNBRHNH?=
 =?utf-8?B?VXB5czlzVVZSMTFQZ1FWNjNaaTJVRVlZaFIvdk9oNEdIRHhDTEk3M2Rkb05p?=
 =?utf-8?B?MUszY2J5WWZTUjdHTU95UGNSYlR3eDBLQ0pDTzZ4Wk5iZlp4MjhiZVo3YmxX?=
 =?utf-8?B?UTNRa1NhdUlDQmtjdC9OUkNMSFlpc0owakNKY2l1ZmVRSXU5QjJudm83eUN5?=
 =?utf-8?B?UVY3TW9PMm1pZHk1TCsrOVloVDYxMEdRaU85Vi9rei8vWGFDZ3BlODFLQ1Rk?=
 =?utf-8?B?N3AxQTJpR0tQM2toTytMZ3lUTzZnaloxTEJ2Vy9VQUFjOVM3YU45aktid0lW?=
 =?utf-8?B?WWg3Z3hNRWxRNjNGL2hFZ1krYWZPeHpybXdpL09pYnpsYW5wT3k0WEwvOUVB?=
 =?utf-8?B?aXpuNjV4K3kxTFU2L3F0b2JaemdtU2NhL1RqSWxtWUZDOVUwc1ZaQU42Mith?=
 =?utf-8?B?dHZPRURsb3lKYVFXVS9ZcVFIV1RYMFovWEVZN2FiNVZOQjNFOHVzSXZyUTFX?=
 =?utf-8?B?SEtEU0xEeWU1QmZadXJ6aXc1eFEwTjFZRjlENys2dzhvM1dhcWVjc283ZGJG?=
 =?utf-8?B?Ly92L2ZQMTJ2RkY1di9BRWRleHZBNUorTjRsK1FKWGJOd0ZyQWNKUHlCUllV?=
 =?utf-8?B?aWc0WDlmbCtPSWdoS3VDYVREejltMlFaUWJjMCt6TU5Wd2NudkhSVWhNQlVU?=
 =?utf-8?B?dFZBZzc3RDhBejFwZkx4ZWRLSlZaVDhES1BqOXUwNjcreEhsSVBmSk94V0tq?=
 =?utf-8?B?emRMN1ppUjdZdWZQUGpLUlVZU0RoK2JZZHk3aXlYZHA4bnZ4TWJ3a3A0WVVz?=
 =?utf-8?B?TzR3Rk40ZGZBbDZEaXo0UVpZVkErd0hwWEQwOU1wOUE0UERlYVhqUVArdkpa?=
 =?utf-8?B?UWk2UlZ6QVNlekltNDNEZXdXamJHK3ZjdkpUbzJwZTJnSTdaeGtZMm4wVEY0?=
 =?utf-8?B?RkluMENLV3pMakFMWTZoZkVqWWtKK1FGbHBhZmVZeVZSdGN3OFdvWXU0dnZz?=
 =?utf-8?B?RGQzdURjMVVJWm41N2d1aHVFdDlEN2I4aDUvYjZ1SDNESlBTRDdHdEhzV09J?=
 =?utf-8?B?YllmUGVZK1hJZjhYazRKdWg1NXlRMnBZeWlpRHQxQ2FteGdGTjFtU09Yd3Yr?=
 =?utf-8?B?QkMvb2xvM1NXWkMrM2hMcUFJMHpUSG8wUjRSTzlIT2lXREg3SDFDelVNUnEx?=
 =?utf-8?B?KzMyRk84b3JIRTJBc3ZZNEZNRVZ5U3lmQ2U2bFZwcFZkKzg2Si9OcGNKVXlS?=
 =?utf-8?B?SUNmUU5tTGd4RndRcmZIRXllMkNTVjJZcGxQc1dHemEvMHRLbWpkdWJnaEh3?=
 =?utf-8?B?Q0RDRXRRNkxWNjdoZFJieG1TK2Y3WG90N0xqa3g0RFBYQlZiUmtaZWl4Wit4?=
 =?utf-8?B?aWNQUFhTVklRcGxVd2taZ3FlQUJvZ09RbUJ6K2lrWDNOWmtBNDh6bmxGV0pp?=
 =?utf-8?B?MXdlc0E0ZDFBVXJ4K2w0T1FGeW9PeWNsVXBHZnduUExWQktnREJwQWI5S1hn?=
 =?utf-8?B?aXUyTndUQnNCV2hqMVJGZlFMbW5zalRjV3lmeE9PU1RqNERIRGc5MG12bU10?=
 =?utf-8?B?MytZVkRjS0FMOHBRZ3V1SXhPYWdJMUt1VDJTMXlwNVlmOEw0K2ZpcDdnQWhl?=
 =?utf-8?B?Qmszd2xlUmlpWkc1SjJxNnYyREhnbnRLc3lZWG13K2JCOEtqdXB3VlIwVGY5?=
 =?utf-8?B?M05ZSVMxTGJZMlllNklLN3hVTGkzTk9KdHgwWmN4L1U1SEVBKzhmTFM0Y1hC?=
 =?utf-8?B?ZnFRZlAwR3ZMVEJ6bFFKVFVvcG4xTDZ1S2d1anIwRGhoS3BNd2taVWpmNXVq?=
 =?utf-8?B?UUg4VUNCQWprcGY2UkhKQkR4dW1RcFZ0Z3haVDNjOXdpdTBWWHZpeTl0TnFK?=
 =?utf-8?B?WFZ3UGgxVTFvWjBFTTlhRi9JdnQxUXZhdmZ5Q3dPUW9CRkxoUTR5MURNOTlD?=
 =?utf-8?B?R21PeCtKend2SlRzb2FRc0JFL1lvTVV4a1VYQXV2dmlFQ2VQT2kwZlZlMDFD?=
 =?utf-8?B?UEFkSTBjMTFaYlN6c1dZUVRURkhQWUw4SEkzOUR1RG5qOG9DbmIvUFovTE5v?=
 =?utf-8?B?eXVpZmRWZTIwd0kyRmpRcENvc3JIU3VwMEZWUTBSd0ZWeTIzVU9OdUt0a1RD?=
 =?utf-8?B?SjVFTE1iejUveHhibjBUenJUTkZrNU40bG9IUWcwaVhmaVk5Mm9UQjJzN3V6?=
 =?utf-8?Q?bJsjnnFRN7z22a5l3DvsiFA=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8bfa36e-ca19-4f4a-b01a-08d9d4d0287d
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 07:01:14.8509
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jfc82pi7FDZY52b6it7mSlyX+NIrmLe3P2IWG29j/6fdhCpyk1LaBXhI+xirmQ1KfxYo1PmxT3aMqrAlZYyBGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3778
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/9/22 20:23, Matthew Wilcox (Oracle) wrote:
> try_grab_page() only cares about success or failure, not about the
> type returned.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
>   mm/gup.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: John Hubbard <jhubbard@nvidia.com>


thanks,
-- 
John Hubbard
NVIDIA

> 
> diff --git a/mm/gup.c b/mm/gup.c
> index 20703de2f107..c3e514172eaf 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -192,7 +192,7 @@ bool __must_check try_grab_page(struct page *page, unsigned int flags)
>   	if (!(flags & (FOLL_GET | FOLL_PIN)))
>   		return true;
>   
> -	return try_grab_compound_head(page, 1, flags);
> +	return try_grab_folio(page, 1, flags);
>   }
>   
>   /**