Date:   Tue, 11 Jan 2022 10:26:58 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Watson Chow <watson.chow@avnet.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: [PATCH] regulator: max20086: fix error code in
 max20086_parse_regulators_dt()
Message-ID: <20220111072657.GK11243@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hMxJa5Onon0vD2YHolW3CjRnPjLOfJiJZSZNyLXE/cSKFB6aRupFHcEEpoxq?=
 =?us-ascii?Q?X5xTDkwLpHClx2CTsbEc9vZr6rp4HtG/keAd05gpoYu/JKdlFrrcO2HPZkGU?=
 =?us-ascii?Q?ooODQBesOG99pQnq6Zl2Qz5wSvoVIvir3sFuhJtN5NEDKq6WgFEq93a2WCH0?=
 =?us-ascii?Q?L7eF+ByvZ0MbKpIrI+Tf9Hj9zBt1qpljez6Pr955ySjKTLLY6Y/Rh/1iaUdl?=
 =?us-ascii?Q?LlgSYeWB7GAMeD49Bfz/hJgbjDvpg/g4lpLKi9ukG6ydqXexC/hEY7fIbQl6?=
 =?us-ascii?Q?PnCePhyAYI4LmqSS+I0YC2lGSigQ6Lc+I2mXNSULeWk4g+5uqjlSpF79tugu?=
 =?us-ascii?Q?mbrcNeDrDi5ve3MlhEIDRfj+iO9A+5phJ1yPSusDNVJI2UOKrQph6iHVVdL1?=
 =?us-ascii?Q?YbgGswmQIFwA1BRU8YgpVZRPjKeucG21vvfcRkELGbJKDWSrnDDRc2cUF5mG?=
 =?us-ascii?Q?RVL3Ndro1aYMqMfIKhL3zceLwqG5TKDV6SHs78mWZpCp7Vi24TuYAp93uY+2?=
 =?us-ascii?Q?Y9qHJjDKmDcvS97UH2FqtySluaPmpDGTNtw7if9YwYc7LaEce9663XpppLrq?=
 =?us-ascii?Q?S1rX/f+R7Sm4BxFPopek06DXDS0BACo5TxeF2xd2pHIe+jYiFXdGj62OqVo1?=
 =?us-ascii?Q?ub66wWYp/keIVDUz74TSzBaccMcyVG/0TJYmXDuwniZzvYpNa0nLklhp02St?=
 =?us-ascii?Q?65RJdk9WWRSYIPfwKsqNEmlMoHaTbTx6VNxKuxwjRUaBvfSdLCoa3WdN9MW6?=
 =?us-ascii?Q?5/g5IP2UGh54vfSghmJJeXr3h+jF1uglOPKhmXRqv5aWEwURVaByGKYW3kQ5?=
 =?us-ascii?Q?lcdijbVtOrQlIGDr91t4Cu1XMNypDulJrupkgydwCnFX0zNVsV+WcBA+i4Ej?=
 =?us-ascii?Q?Pr/YPc5aUbF0l5yAaa5Qx6v8HoDLc+dAhux2jSwuR3dfU94PufJWgz3JpuAV?=
 =?us-ascii?Q?Fp3pzr/W1dYdwevzDVvocltE1D/gH5JPqLtSk2I6YLTjRXmD0AtpUBnDXNVn?=
 =?us-ascii?Q?CQeUYfwJNot533cmgD8Toen1YggihpV8VcJpPxdVD7VQmJEUuAEKK/0qkja2?=
 =?us-ascii?Q?R3+Bl2E5MbywahsW9zbuJ5ND0FvqogPaGzpIthQ3L23eJM/sFv8jvA+shb0Y?=
 =?us-ascii?Q?OBVsH1V1JYsD7Or7hP4ejC7BefCAhjO9ZNzoSd7IXsoa3uApLyWbdDn9FgNS?=
 =?us-ascii?Q?/gzBuLQfSSgwOfplqwqBuDCJabOthH+XIoZ7ASfQjiLPp+nw7GjPkaty2Nvm?=
 =?us-ascii?Q?6aDST5A8xcX96rvXw4d3ZDEczAvZLtL5B9tU2/3eUSvd77t0fKjFPmj2CeEW?=
 =?us-ascii?Q?jyIGSwhrz25taGMkO6KDybz/CM1jL0xa0UslvkXmtq7vJy/5uOy7KtOspMeM?=
 =?us-ascii?Q?9OMY85PFraNlGBmOFc9ZgMC4Enk9RktpG7BILxp0MHETuSjSLKY8G3VPTlCD?=
 =?us-ascii?Q?eenw2UeWGa8iIiLnJuaN5Pm+7kByqphPzlL6TJv7oq8AQHA9YwS/s7zv5NHJ?=
 =?us-ascii?Q?rKJYVw8/N+GeFl4TqiA+xY7K3iXKMe5P5koF0n0RPoziY5hw5A71n9Jo650r?=
 =?us-ascii?Q?lVR4Yj4kz322L2E+ggO97qZCZDRn7apIO8LMwNTFjjaaY8upVMuvo9e/KFXt?=
 =?us-ascii?Q?Ybgny/dj3imoFagU+UIT5HnzJswVshs8Cxlmb71DM3VUaW1lyKQbjcFXQZr8?=
 =?us-ascii?Q?HEZNXcAPfFDlORGpa9dEHfOCz/8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49c1eee9-abfd-4ac9-8c54-08d9d4d3c76e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 07:27:10.1390
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wmi9id7k4E+24YMH9dJ8oC4gCC6n/xcCc4Ftft/ERbjR7bMBFypUagJZUwF+AV9lHRwgrvQgZQsKsXvlAEb6VoLGlkfNVSWbPrr3+SzMVZ0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1824
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10223 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 spamscore=0
 mlxlogscore=999 adultscore=0 phishscore=0 malwarescore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2201110039
X-Proofpoint-ORIG-GUID: yYrTE1_7jRqBJJnaX92ptQNuGWHeZBVD
X-Proofpoint-GUID: yYrTE1_7jRqBJJnaX92ptQNuGWHeZBVD
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This code accidentally returns PTR_ERR(NULL) which is success.  It
should return a negative error code.

Fixes: bfff546aae50 ("regulator: Add MAX20086-MAX20089 driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/regulator/max20086-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/max20086-regulator.c b/drivers/regulator/max20086-regulator.c
index fbc56b043071..63aa6ec3254a 100644
--- a/drivers/regulator/max20086-regulator.c
+++ b/drivers/regulator/max20086-regulator.c
@@ -140,7 +140,7 @@ static int max20086_parse_regulators_dt(struct max20086 *chip, bool *boot_on)
 	node = of_get_child_by_name(chip->dev->of_node, "regulators");
 	if (!node) {
 		dev_err(chip->dev, "regulators node not found\n");
-		return PTR_ERR(node);
+		return -ENODEV;
 	}
 
 	for (i = 0; i < chip->info->num_outputs; ++i)
-- 
2.20.1