Message-ID: <4789f3d7-1e6c-65ad-8410-29a8a9b26c99@nvidia.com>
Date:   Mon, 10 Jan 2022 23:38:02 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v2 23/28] gup: Convert gup_huge_pud() to use a folio
Content-Language: en-US
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>, linux-mm@kvack.org
Cc:     Christoph Hellwig <hch@infradead.org>,
        William Kucharski <william.kucharski@oracle.com>,
        linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>
References: <20220110042406.499429-1-willy@infradead.org>
 <20220110042406.499429-24-willy@infradead.org>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20220110042406.499429-24-willy@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2l5MGk2VHptb2JJL3dMR0pzeXVPcVZuZDB6bHBHNk5zdU9haWlSUDM2TGxS?=
 =?utf-8?B?RjQwRVVDTVNncmhqVEhHZk42SlgrN2YrbCtMbEJVVmdwUzNOajVFSi9GenhD?=
 =?utf-8?B?VFdaQ213YlIzaVJnSS9yRzArZXpRMnZUME5WcnVjZ2YwMm9hemRZc2lGYTUw?=
 =?utf-8?B?bEpMODFDSG0xMUdJb3RpUXpXOU8yVVFJamRqVmJmSUpXKy83dkxUTWlIUnNV?=
 =?utf-8?B?bjFQd29WOS9sL0V0OWliZGMrdG5DeHM4TmtNeDlUQlh3T2tTVE55RjN5TlVC?=
 =?utf-8?B?NGozbHY3V2lpakpPQTlKK21Lb1poVlZVYVVuOC8wMzc3Sy9QRkdOTmZURkh1?=
 =?utf-8?B?RE1PSlFTblpNbFBaQUwzd0lpNlR5QjNST2Flbk0vOHloSkxyanlOakZuUDhW?=
 =?utf-8?B?ckdORXROd3NDNVZVQlpTTzYxSy9acU1VUS9kTHVIMXBSUFM3RkdBVCt2UHJj?=
 =?utf-8?B?TkxSZEZtVDZYYzBkQzllc3NyMUJ4VnhhT2pSOHh3bWFseVYyZ2dQT2Zac05D?=
 =?utf-8?B?Y25rcDFoYm5KaG42MVBkZndoVWRVZldXZkRvL2NydVM5bWlIazJOaGFLMGdO?=
 =?utf-8?B?QmxLZlVXTHBSUUJkNkhDbEVWT0RlOHRpdGJBbTVTUjNXdC9Wd1MzcmpOZXFR?=
 =?utf-8?B?eW5IcVhwaUJyMkhPQXFsNmJxeDRUb3lLbG0zclFiNGt5RW9JWFFkWnduUVZn?=
 =?utf-8?B?Y0tZSk9KTTZnMW1ZSktQRGdzWm9IZm8xWHUza2VhRjRHbUM0WXI4VmhESDhH?=
 =?utf-8?B?b2F1aW1SZ0NwUHNJdnFlS0FqVEsrL2tWeElkcEd6QU5kckd0ajNtMGZrOHdj?=
 =?utf-8?B?QjFXNW9lcEk4Z2hMK0tMZ1JsK3lOK3ArWjEwTGx3Z091K3VSWUhHRW5ObktS?=
 =?utf-8?B?SUd5dUk1eVNHVTFlaFBQQVo3S1pIMStyQlQyRTIvbWtORmE3bU90a0Q1L3V1?=
 =?utf-8?B?RlJyMjB3UFNGWFVnenRSa1dQWjZQQmtSTDFUNGIvaFF1RHBNa3pBbDZqTTR4?=
 =?utf-8?B?RTR1bVl6UEJHM0tmeG53MVJCTjRUTHhuU2dUd2ZXR1pFaEJ6S0VRYnpXSnZT?=
 =?utf-8?B?UCtWQVZYVHhDR0dSVjhMU3N1QzRUL1RGOGE0cEN2bjBSQmFCMCtUMm5yRTZ0?=
 =?utf-8?B?MGxuZTZnTzVqQkRDVmFncCsvcVFuZHRWVTRpMFRsbFFPeWhFMHowblpDallq?=
 =?utf-8?B?RkNqWmRTZVA4OTFHTDFIeVFEekROZGJCQ1dONE01aktNODBYem5RVzZRZEVK?=
 =?utf-8?B?cEpRMkdrWDR2RFo0ZVdNS2RkRmRGaXZyNGcybHQxOEVUWUhvM2oyTmVkNUM4?=
 =?utf-8?B?eVB4ZWpod2E0U2dXZjQzSjBDZCtTNlMrSVNOWGRmS1ZTcjNOZ0t5OEhKVytW?=
 =?utf-8?B?aENvaG9keVRHNXk0MndSazFRTjFSV0NnamFVMWsraFgxRDBibGJVa0w2bFZr?=
 =?utf-8?B?QllDOUdrWVhUa3lhL3NtWmZGSml4d3RWSnBtTGRObDBudTVZcHRrQmQ1UHkr?=
 =?utf-8?B?VnFudHBidWpMK0xEdFd5Q3cwYW8yYUVyZ3JzbER4Mk9PdmtGUThvZnRpV1hx?=
 =?utf-8?B?TEIvOFpLaHF4STBkNDRhMlFZR0tnTFBIRDZ1YUpDdFN4dklSMjM3YjExdFJh?=
 =?utf-8?B?SzBTaERVYWtzR3ZYdWhKZGdUTERlUDlXYW44SjBFcWJZU0hpdVNXV2p3VHZX?=
 =?utf-8?B?TjlOdGttby9IR2pDOEowTERLRm50TlowNEQ0RUpLTlVJa3c4RHJhUlRUKzR0?=
 =?utf-8?B?MEJhY2g4YkpvV2tmekhaTFV2MEVUeUZrUXFjbEFPRytUYXBXVEIyZDYzOFM3?=
 =?utf-8?B?Z2NWSzViREFCYWYyOUpZUEREK0hIMWNqYzhvYmQxRU1ERFFkSlBNVVlzcmFk?=
 =?utf-8?B?c2IzM3F0UEEzdFB1a3E2cHJISmgxRlZMWm4ydEJ4dDR5RGlCZ21BZEdDTi9v?=
 =?utf-8?B?RWtvc01HNmNCTy8yWVhQV0FtSXpyMHNKTTYwRzVEbEpTNFpWZERwOXF0aHl5?=
 =?utf-8?B?emRLTkUzL3BvMUp3WVBhdVQ5Wm9IcDEzVHhQQzI0MmErTXkzOXVrNGY2V29K?=
 =?utf-8?B?RnFDQVFSNWhyV2Z3TVA1bG9XRlowZGw1RTBOTDY3TGY2bm1PRWZ2L0dtTDJM?=
 =?utf-8?B?TXF6ekxtWVl5dG1oRitISTlXb1dlMGlDWjhzMHdZN3dLaENxWGpab2RsaWFO?=
 =?utf-8?Q?XmbWjcngohcOhJYel+jSqWM=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9eec63eb-eff3-40e5-d468-08d9d4d54d6a
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 07:38:04.3010
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C/iAaiEVXHVRfvTuq1VW6mKRC3O2h0VORn+yyRrvzCEIWLbbibGnMGvjWmRXJYBeBzs7Ow6yYTiSnScvKmrWug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3414
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/9/22 20:24, Matthew Wilcox (Oracle) wrote:
> Use the new folio-based APIs.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
>   mm/gup.c | 11 ++++++-----
>   1 file changed, 6 insertions(+), 5 deletions(-)

Reviewed-by: John Hubbard <jhubbard@nvidia.com>


thanks,
-- 
John Hubbard
NVIDIA

> 
> diff --git a/mm/gup.c b/mm/gup.c
> index a006bce2d47b..7b7bf8361558 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -2527,7 +2527,8 @@ static int gup_huge_pud(pud_t orig, pud_t *pudp, unsigned long addr,
>   			unsigned long end, unsigned int flags,
>   			struct page **pages, int *nr)
>   {
> -	struct page *head, *page;
> +	struct page *page;
> +	struct folio *folio;
>   	int refs;
>   
>   	if (!pud_access_permitted(orig, flags & FOLL_WRITE))
> @@ -2543,17 +2544,17 @@ static int gup_huge_pud(pud_t orig, pud_t *pudp, unsigned long addr,
>   	page = nth_page(pud_page(orig), (addr & ~PUD_MASK) >> PAGE_SHIFT);
>   	refs = record_subpages(page, addr, end, pages + *nr);
>   
> -	head = try_grab_compound_head(pud_page(orig), refs, flags);
> -	if (!head)
> +	folio = try_grab_folio(page, refs, flags);
> +	if (!folio)
>   		return 0;
>   
>   	if (unlikely(pud_val(orig) != pud_val(*pudp))) {
> -		put_compound_head(head, refs, flags);
> +		gup_put_folio(folio, refs, flags);
>   		return 0;
>   	}
>   
>   	*nr += refs;
> -	SetPageReferenced(head);
> +	folio_set_referenced(folio);
>   	return 1;
>   }
>