Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0420C4332F for ; Tue, 11 Jan 2022 09:00:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349103AbiAKJAC (ORCPT ); Tue, 11 Jan 2022 04:00:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236626AbiAKJAA (ORCPT ); Tue, 11 Jan 2022 04:00:00 -0500 Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DEA6C06173F; Tue, 11 Jan 2022 01:00:00 -0800 (PST) Received: by mail-ot1-x332.google.com with SMTP id o3-20020a9d4043000000b0058f31f4312fso17907786oti.1; Tue, 11 Jan 2022 01:00:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=bpi5yDslZk96fGP0AiL8cVK6M5zVjolT/YXQK+TShT4=; b=eFUOEGUfVwr+KA/dAq1Chz/htbufTyGyC7BwTd95/DvX090ijtoqnldGYGbSLkuQXR oKJNgV4K47rMHkjMou5rvfrMuJuzjDE5uQezF+MDd7CDjmcIaU2JdeJ73owOQgvs86R3 ftz0GuTOdgUMqpVHms2F0Pnaiwy3byXKNnCACETNPdd+k2I9idlRXH91q3y67mRS6jeW 9JQEOTxitLAtNw2x2X1JUjZdv0GhshpHr47QX3jyb00sv/kvKQT/Z3RAGtjJ44lJ4dyv BUIm1uUaV3u102hBloRdhg0b1QztiPlefiyGVOGhoMztdTG3JyhCCMd68lHZrDsBTG16 eNmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=bpi5yDslZk96fGP0AiL8cVK6M5zVjolT/YXQK+TShT4=; b=r7m9ueL9pK91lCrDK/B6KViuEmkGILXFpj1GwBeyvz+IEsPcLZDc7bC5w6RKlVD2/J SqxGRq0qkKLCRTD1CBA62GwkjoNV3SkeU0oUL1kFmBunY+RSwz8uyHWLLgljvHzLKcHR hIo3murZg71Vd0lq8hWZsciduYKm/AI/H/DowKuBaBsEzdB44hiUnrMkLZt0gYiLxHba rA+h0uOmYEcri3gZDdlfnKyKzgsR/LKyh+toaIMfPDMXOLYaIn854TU+6tIM6c7ThhEu erq4q4YhbimXD9Heqei3Gn5QfxH/8d7m62XZSE4Jmh90x+4nccCwKu0hD5MH9uM+799f sW8g== X-Gm-Message-State: AOAM533xfb9j1u2gd0ej/DRhaMd3UyOkiQ3eWh7ZEQDQ256zOzQ2ldH/ zNiNTiP+clN4YjAzqRgqENcOqYKkDue82Up+5D0= X-Google-Smtp-Source: ABdhPJxBtMctMZ2FSy/SM0hSNvXMghYRzhYObXWQyWPEWXbR2jnbEHYpfydwBbZo6+51vTDmuc3Po1sBuk5I6P4MSkc= X-Received: by 2002:a9d:5190:: with SMTP id y16mr2674164otg.189.1641891599946; Tue, 11 Jan 2022 00:59:59 -0800 (PST) MIME-Version: 1.0 References: <20211210154332.11526-1-brijesh.singh@amd.com> <20211210154332.11526-25-brijesh.singh@amd.com> <20211213154753.nkkxk6w25tdnagwt@amd.com> In-Reply-To: <20211213154753.nkkxk6w25tdnagwt@amd.com> From: Chao Fan Date: Tue, 11 Jan 2022 16:59:49 +0800 Message-ID: Subject: Re: [PATCH v8 24/40] x86/compressed/acpi: move EFI system table lookup to helper To: Michael Roth Cc: Dave Hansen , fanc.fnst@cn.fujitsu.com, j-nomura@ce.jp.nec.com, bp@suse.de, Brijesh Singh , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Borislav Petkov , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I am this Chao Fan, and won't be used again. Please add me with fanchao.njupt@gmail.com Many thanks. Thanks, Chao Fan Michael Roth =E4=BA=8E2021=E5=B9=B412=E6=9C=8814=E6= =97=A5=E5=91=A8=E4=BA=8C 11:46=E5=86=99=E9=81=93=EF=BC=9A > > On Fri, Dec 10, 2021 at 10:54:35AM -0800, Dave Hansen wrote: > > On 12/10/21 7:43 AM, Brijesh Singh wrote: > > > +/* > > > + * Helpers for early access to EFI configuration table > > > + * > > > + * Copyright (C) 2021 Advanced Micro Devices, Inc. > > > + * > > > + * Author: Michael Roth > > > + */ > > > > It doesn't seem quite right to slap this copyright on a file that's ful= l > > of content that came from other files. It would be one thing if > > arch/x86/boot/compressed/acpi.c had this banner in it already. Also, a > > Yah, acpi.c didn't have any copyright banner so I used my 'default' > template for new files here to cover any additions, but that does give > a misleading impression. > > I'm not sure how this is normally addressed, but I'm planning on just > continuing the acpi.c tradition of *not* adding copyright notices for new > code, and simply document that the contents of the file are mostly moveme= nt > from acpi.c > > > arch/x86/boot/compressed/acpi.c had this banner in it already. Also, a > > bunch of the lines in this file seem to come from: > > > > commit 33f0df8d843deb9ec24116dcd79a40ca0ea8e8a9 > > Author: Chao Fan > > Date: Wed Jan 23 19:08:46 2019 +0800 > > AFAICT the full author list for the changes in question are, in > alphabetical order: > > Chao Fan > Junichi Nomura > Borislav Petkov > > Chao, Junichi, Borislav, > > If you would like to be listed as an author in efi.c (which is mainly jus= t a > movement of EFI config table parsing code from acpi.c into re-usable help= er > functions in efi.c), please let me know and I'll add you. > > Otherwise, I'll plan on adopting the acpi.c precedent for this as well, w= hich > is to not list individual authors, since it doesn't seem right to add Aut= hor > fields retroactively without their permission.