MIME-Version: 1.0
References: <20220111011239.452837-1-jiasheng@iscas.ac.cn>
In-Reply-To: <20220111011239.452837-1-jiasheng@iscas.ac.cn>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Tue, 11 Jan 2022 10:42:41 +0100
Message-ID: <CAMuHMdXr4aeTZmjgznunLtZFQusEW7Rw=q3FjTNa1jcgGwkoDQ@mail.gmail.com>
Subject: Re: [PATCH] dmaengine: sh: rcar-dmac: Check for error num after dma_set_max_seg_size
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     Vinod <vkoul@kernel.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Zou Wei <zou_wei@huawei.com>,
        dmaengine <dmaengine@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 11, 2022 at 2:12 AM Jiasheng Jiang <jiasheng@iscas.ac.cn> wrote:
> As the possible failure of the dma_set_max_seg_size(), it should be
> better to check the return value of the dma_set_max_seg_size().
>
> Fixes: 97d49c59e219 ("dmaengine: rcar-dmac: set scatter/gather max segment size")
> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds