Message-ID: <ab107cb4-3ba5-9d22-2e40-fada05c3579f@xs4all.nl>
Date:   Tue, 11 Jan 2022 10:58:10 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.4.1
Subject: Re: [PATCH] media: vidtv: Check for null return of vzalloc
Content-Language: en-US
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, dwlsalmeida@gmail.com,
        mchehab@kernel.org
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211231075019.1894177-1-jiasheng@iscas.ac.cn>
From:   Hans Verkuil <hverkuil@xs4all.nl>
In-Reply-To: <20211231075019.1894177-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 31/12/2021 08:50, Jiasheng Jiang wrote:
> As the possible failure of the vzalloc(), e->encoder_buf might be NULL.
> Therefore, it should be better to check it like the kzalloc() in order
> to guarantee the success of the initialization.
> 
> Fixes: f90cf6079bf6 ("media: vidtv: add a bridge driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>  drivers/media/test-drivers/vidtv/vidtv_s302m.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/media/test-drivers/vidtv/vidtv_s302m.c b/drivers/media/test-drivers/vidtv/vidtv_s302m.c
> index d79b65854627..d7907f1ae530 100644
> --- a/drivers/media/test-drivers/vidtv/vidtv_s302m.c
> +++ b/drivers/media/test-drivers/vidtv/vidtv_s302m.c
> @@ -455,6 +455,11 @@ struct vidtv_encoder
>  		e->name = kstrdup(args.name, GFP_KERNEL);
>  
>  	e->encoder_buf = vzalloc(VIDTV_S302M_BUF_SZ);
> +	if (!e->encoder_buf) {

This doesn't free e->name!

Actually, the same issue is also present later in this function:

        ctx = kzalloc(priv_sz, GFP_KERNEL);
        if (!ctx) {
                kfree(e);
                return NULL;
        }

Regards,

	Hans

> +		kfree(e);
> +		return NULL;
> +	}
> +
>  	e->encoder_buf_sz = VIDTV_S302M_BUF_SZ;
>  	e->encoder_buf_offset = 0;
>