Message-ID: <f8b4606a-e3ec-e452-f291-7ac36c69f8cd@marcan.st>
Date:   Tue, 11 Jan 2022 20:10:14 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: Re: [PATCH v1] usb: typec: tipd: keep default interrupts enabled
 during probe()
Content-Language: en-US
To:     Martin Kepplinger <martin.kepplinger@puri.sm>,
        heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org,
        sven@svenpeter.dev, hdegoede@redhat.com
Cc:     kernel@puri.sm, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220110163559.711404-1-martin.kepplinger@puri.sm>
From:   Hector Martin <marcan@marcan.st>
In-Reply-To: <20220110163559.711404-1-martin.kepplinger@puri.sm>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/01/11 1:35, Martin Kepplinger wrote:
> Commit 9990f2f6264c ("usb: typec: tipd: Enable event interrupts by default")
> writes a fixed set of interrupts to TPS_REG_INT_MASK1. In case interrupts
> had been enabled by the firmware by default, these get disabled now
> which can break use cases. Only append to what is already enabled instead.
> 

I'm confused. The kernel drives the hardware, it needs to enable only
the interrupts it can handle. Do you have some kind of firmware trying
to share access to the same I2C port that needs other interrupts? That
sounds like a recipe for trouble... or am I misunderstanding things?

If the *kernel* needs other interrupts enabled to make something work,
then they should also be enabled unconditionally, and you'd have to
check the IRQ handler to make sure it actually handles it.

-- 
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub