Date:   Tue, 11 Jan 2022 13:28:21 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc:     Petr Mladek <pmladek@suse.com>, linux-kernel@vger.kernel.org,
        Steven Rostedt <rostedt@goodmis.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [PATCH v1 1/1] vsprintf: Move space out of string literals in
 fourcc_string()
Message-ID: <Yd1p1XckKtdPyKSr@smile.fi.intel.com>
References: <20220110205558.11876-1-andriy.shevchenko@linux.intel.com>
 <308b7158-7c2a-cc98-6091-14dae2b2cbba@rasmusvillemoes.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <308b7158-7c2a-cc98-6091-14dae2b2cbba@rasmusvillemoes.dk>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Jan 11, 2022 at 11:26:21AM +0100, Rasmus Villemoes wrote:
> On 10/01/2022 21.55, Andy Shevchenko wrote:
> > The literals "big-endian" and "little-endian" may be potentially
> > occurred in other places. Dropping space allows compiler to
> > "compress" them by using only a single copy.
> 
> Nit: it's not the compiler which does that, but the linker.

Ah, I stand corrected, thanks!

> > -	strcpy(p, orig & BIT(31) ? " big-endian" : " little-endian");
> > +	*p++ = ' ';
> > +	strcpy(p, orig & BIT(31) ? "big-endian" : "little-endian");
> >  	p += strlen(p);
> 
> Hm, ok, those two strings do occur a lot with of_property_read_bool()
> and friends. But if you're micro-optimizing anyway, why not drop the
> strlen() and say p = stpcpy(...) instead?

Why not? I'll do it for v2.

Any thoughts / comments on the
https://lore.kernel.org/lkml/20220110205049.11696-1-andriy.shevchenko@linux.intel.com/T/#u?
I'm asking since dependency and I would like to know if we still want that
fix or not.

-- 
With Best Regards,
Andy Shevchenko