From:   "Penigalapati, Sandeep" <sandeep.penigalapati@intel.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
CC:     Song Liu <songliubraving@fb.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        John Fastabend <john.fastabend@gmail.com>,
        "Brouer, Jesper" <brouer@redhat.com>, Yonghong Song <yhs@fb.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        KP Singh <kpsingh@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "Martin KaFai Lau" <kafai@fb.com>
Subject: RE: [Intel-wired-lan] [PATCH v4 net-next 9/9] ixgbe: respect metadata
 on XSK Rx to skb
Thread-Topic: [Intel-wired-lan] [PATCH v4 net-next 9/9] ixgbe: respect
 metadata on XSK Rx to skb
Thread-Index: AQHX7D0fZ5JsDE1k70OElN7bbzlE2qxd6sdg
Date:   Tue, 11 Jan 2022 11:52:12 +0000
Message-ID: <MW3PR11MB4554E0499E598B382155A48E9C519@MW3PR11MB4554.namprd11.prod.outlook.com>
References: <20211208140702.642741-1-alexandr.lobakin@intel.com>
 <20211208140702.642741-10-alexandr.lobakin@intel.com>
In-Reply-To: <20211208140702.642741-10-alexandr.lobakin@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?e/A0XSulY9bW8A+3+1w3Srun1kJs6E6e7ejZ4U4H2jHvtmryK40blqeE30?=
 =?iso-8859-1?Q?mliKx9Ye/k3MNsesdta/LjFYs/xR5plL7zg2DMVE1jIMz62QTW5YXz+vab?=
 =?iso-8859-1?Q?QNOraeJgpX8D6mg459HegJMPocmEM3lS2NHRMDqJ6AcRHsJMlLssgSdBmQ?=
 =?iso-8859-1?Q?j1wRTpQOwWuR8vOsYNu3k/5RBLqmiuQ3Tz8HHjv230kqHCpNInVFH/jhen?=
 =?iso-8859-1?Q?qeC7B4iKZYJyCr6GCXSp4wniC9ebmEe9x6UrmCSadeR3W2EGy2nsApfnwx?=
 =?iso-8859-1?Q?UVjPZSYALcCpZXGqQUdri9VIi9eCOySyVnm/X3smjzPDhF7jdUdIxJrOxu?=
 =?iso-8859-1?Q?70syosJzidtLF1vTIf7PBkCeqVZ2Lu6dvpYjDTD4QoPXc7jmWLVTGeqgnt?=
 =?iso-8859-1?Q?kUlwWml0tJcjssobk13PlckVldPNnXOxh138Z0Vz8GPkPi9W89x4YHobta?=
 =?iso-8859-1?Q?OjCsgarTLa/tHP8rk6Sy5EMe254cUmCtIneumIEDD0ljF0SYuSfypKTBOn?=
 =?iso-8859-1?Q?mEDfOhDV8gAegGNuTFklm9r9KACWHTegHAsZBsyh3AwlkDTm8n1vHtJozR?=
 =?iso-8859-1?Q?GZB64/1LjVemRl8siAz4oLTBBGm4hc4GM6tOFqtpDAAR8RW6FmBQfJxWUP?=
 =?iso-8859-1?Q?/R6474SWM+xFsCkJmBZwjsmzZzFX16LL/FQwCvOOrhGVeEYEUa5ImsTPPF?=
 =?iso-8859-1?Q?vgs4ibqhccFdCawVWQEZFQxbF2QZ5sS4R6pjTB5k7dkgtung8izIisR9uK?=
 =?iso-8859-1?Q?rNEb+++InDbDpO6I2lFHYBfwzIwcQKUNz4ANgLSgjNQlTruj3SPPBSrP9B?=
 =?iso-8859-1?Q?74MqMVMrVHk5DzHnJpSAbz0LasnQWbWXNivuB7YNFf9N8uFStK6OXV7qPx?=
 =?iso-8859-1?Q?fqGlRonGGteqKI8IzSi6yeidNZPOD0pTO1TKQBo9hcGrpCE7A4biaJeXsm?=
 =?iso-8859-1?Q?5xPkfokwD9aVae9zzk+tHErru0MHltA08rYwu15dJI5Tk3+i2tWvFDq/Zd?=
 =?iso-8859-1?Q?Z0C3l7QxueNW+f3UxXuxn1yV418e25fNuO6YZHSKvvnUO2RBNa6B47Fx4o?=
 =?iso-8859-1?Q?mqaCYYVQDY0rh+c2h48Ow5B1dbKSPjGOPlfO0DiEPAUO448zDhUT2A8Dkl?=
 =?iso-8859-1?Q?HT7RKs3lDLXeO90ExHeD6Ublu7kF/KfsCo4G9zJ/F23evvg4IRawJ1Awvj?=
 =?iso-8859-1?Q?q7Nu+XDsNXwnAur2JYinAaLy11sa5K6Odoe3wlKE5Nf8fR4R+PsGfjH9Oq?=
 =?iso-8859-1?Q?sRYTq+ikViubOnVdSMlvythkVBmY3pBnjPECRVIbRGm0szAObzRmoIdAXy?=
 =?iso-8859-1?Q?cCibduX7Z9BMhnniMg5LyccUHy5LKaTGdN/0KgMSTY9KKYcsq3aeT0DS5J?=
 =?iso-8859-1?Q?iv7kFQWu3QQOlNg3cJNniEFHBnKlFd+8apVkXF8pjMtpGVvjnp5qz7ywn6?=
 =?iso-8859-1?Q?54+wmCyYGq/PzrUuwpUakUu271gQrGlHXC1jqiNwwm15XmvdAIAa3lzsHE?=
 =?iso-8859-1?Q?tK6lbL0dzWuWDr7/YCoIEJxu54S7q0chhexcI0JuR/gZR+AWVXhs9/BJ0f?=
 =?iso-8859-1?Q?m6b69ZCoJuNIh97ilf/Tq5bE+RfiyT1QCNY880quqw98AVbiU9Y8q+n3jT?=
 =?iso-8859-1?Q?2XOZUX0ayjFNOqW++Wuq0vFZOd4iPrETnjo/IaX7weOzZCyIFvWrrBAgOQ?=
 =?iso-8859-1?Q?XBsPwFmL3wfB2uFEewVFJmXiiYI6hTnUDP/rrsXJX6Cm58HCsTlkxCd1oc?=
 =?iso-8859-1?Q?/39A=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4554.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b57e6402-7484-4ea2-3674-08d9d4f8ce36
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2022 11:52:12.5023
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vOwCBlmyUpj9S9Zjzs9CURTRq5w1srmsfzxnd7HqzbRhbT61sRaV8Ppdb/NnF4W8ppzJTS+46Uynx870pJB13uHhlM5+E+m0/wvkWUgBPwI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5934
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
>Alexander Lobakin
>Sent: Wednesday, December 8, 2021 7:37 PM
>To: intel-wired-lan@lists.osuosl.org
>Cc: Song Liu <songliubraving@fb.com>; Alexei Starovoitov <ast@kernel.org>;
>Andrii Nakryiko <andrii@kernel.org>; Daniel Borkmann
><daniel@iogearbox.net>; John Fastabend <john.fastabend@gmail.com>;
>Jesper Dangaard Brouer <brouer@redhat.com>; Yonghong Song
><yhs@fb.com>; Jesper Dangaard Brouer <hawk@kernel.org>; KP Singh
><kpsingh@kernel.org>; Jakub Kicinski <kuba@kernel.org>;
>netdev@vger.kernel.org; linux-kernel@vger.kernel.org; David S. Miller
><davem@davemloft.net>; Bj=F6rn T=F6pel <bjorn@kernel.org>;
>bpf@vger.kernel.org; Martin KaFai Lau <kafai@fb.com>
>Subject: [Intel-wired-lan] [PATCH v4 net-next 9/9] ixgbe: respect metadata=
 on
>XSK Rx to skb
>
>For now, if the XDP prog returns XDP_PASS on XSK, the metadata will be los=
t
>as it doesn't get copied to the skb.
>Copy it along with the frame headers. Account its size on skb allocation, =
and
>when copying just treat it as a part of the frame and do a pull after to "=
move"
>it to the "reserved" zone.
>net_prefetch() xdp->data_meta and align the copy size to speed-up
>memcpy() a little and better match ixgbe_costruct_skb().
>
>Fixes: d0bcacd0a130 ("ixgbe: add AF_XDP zero-copy Rx support")
>Suggested-by: Jesper Dangaard Brouer <brouer@redhat.com>
>Suggested-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
>Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
>Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
>---
> drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
Tested-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>