Date:   Tue, 11 Jan 2022 14:16:01 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Javier Martinez Canillas <javierm@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        dri-devel@lists.freedesktop.org,
        Kris Karas <bugs-a21@moonlit-rail.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Peter Robinson <pbrobinson@gmail.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH v2 0/2] video: A couple of fixes for the vga16fb driver
Message-ID: <20220111131601.u36j6grsvnir5gvp@houat>
References: <20220110095625.278836-1-javierm@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5rhk7fpudnheurb4"
Content-Disposition: inline
In-Reply-To: <20220110095625.278836-1-javierm@redhat.com>
Precedence: bulk


--5rhk7fpudnheurb4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Jan 10, 2022 at 10:56:23AM +0100, Javier Martinez Canillas wrote:
> This patch series contains two fixes for the vga16fb driver. I looked at
> the driver due a regression reported [0], caused by commit d391c5827107
> ("drivers/firmware: move x86 Generic System Framebuffers support").
>=20
> The mentioned commit didn't change any logic but just moved the platform
> device registration that matches the vesafb and efifb drivers to happen
> later. And this caused the vga16fb driver to be probed even in machines
> that don't have an EGA or VGA video adapter.
>=20
> This is a v2 of the patch series that addresses issues pointed out by
> Geert Uytterhoeven.
>=20
> Patch #1 is fixing the wrong check to determine if either EGA or VGA is
> used and patch #2 adds a check to the driver to only be loaded for EGA
> and VGA 16 color graphic cards.

For both patches,

Acked-by: Maxime Ripard <maxime@cerno.tech>

Maxime

--5rhk7fpudnheurb4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYd2DEQAKCRDj7w1vZxhR
xbXXAP4gpuUuyyTwx3PEj37oaIJQF37qaFBZHNDqYNK9DJonuQD+LsvkihtOL+7n
xXiJmQtTvSoH/8OE236YGI56zT1kvAQ=
=fqNz
-----END PGP SIGNATURE-----

--5rhk7fpudnheurb4--